Repository navigation
R0A: execute existing CH1 FX rack and Orbit inside real native 10CH+4AUX graph #144
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Merged
masarray
merged 3 commits into
main
from
feature/r0-unified-ch1-fx-native-routing-20261029
Oct 29, 2026
Merged
Changes from all commits
Commits
Show all changes
3 commits
Select commit
Hold shift + click to select a range
File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -0,0 +1,22 @@ | ||
| # R0A — Execute existing CH1 vendor FX inside 10CH native routing render | ||
|
|
||
| Baseline `81c892f39996689c63b5704dcc060a9c42f0339d`; owner production mandate: [#143](https://github.com/masarray/arsonmix/issues/143). | ||
|
|
||
| ## Delivered (native integration, not a cosmetic LAB rename) | ||
|
|
||
| - `LiveChannelFxGraph` now has a strictly optional, callback-scoped, non-owning **CH1 external insert lane**. The host supplies its existing `LiveGraphHandoff::Cycle` lease while rendering native 10CH+4AUX: no second output mix, no second host, no VST instance copy, no new realtime allocation/lock. | ||
| - The CH1 multi-insert rack is run in the same CH1 PRE/POST send/master topology, with exactly the original processor addresses and Orbit parameter ownership. Pre-existing vendor settings/tails are not reinitialized on route apply. Existing per-insert bypass envelopes execute in this lane. | ||
| - Native apply refuses duplicate CH1 inserts and any latency-reporting CH1 processor (including bypassed) until PDC exists. Re-enabling latent plugins during active routing is independently rejected. | ||
| - DRY-only Show capture now checks the borrowed legacy CH1 FX count, not only the separate Routing LAB `fxCount`; missing count also fails closed. GUI SAVE gate and native regression test enforce this. Existing physical device/epoch, muted structural APPLY, graph revision, no active independent clock and real-port gates remain authoritative. | ||
| - The old `LiveDryRoutingLab` / native UI action names remain as **internal compatibility** at this stage. Preserving controls and safety until R0B/R1 avoids presenting a broken main-window GUI. | ||
| - New core regression asserts genuine CH1 external DSP inside a prepared 10-channel graph, one invocation per audio block, no RT allocation, no duplicate plugin instance, dry fallback identity. Existing graph and UI tests stay intact. | ||
|
|
||
| ## Still outstanding before R0 is DONE | ||
|
|
||
| - **R0B production activation:** replace two mutually exclusive control workflows with a single startup native mixer session, and migrate/orchestrate CH1 FX ADD/REMOVE/MOVE/preset/Orbit operations without detached callback or device epoch invalidation. Current CH1 structural edit while routing active is explicitly blocked; do not claim full performance-mode lifecycle or remove STOP yet. This is a safety gate, not a cosmetic UI milestone. | ||
| - Do not show unassigned CH2..10 as live; connect physically via ACK. Product-level ROUTING/PATCH UI (matrix) follows as R1 after native R0B. The current LAB name persists in old UI until the real operational split is removed; no dishonest label-only change. | ||
| - Hardware #15 crackle, proper PDC, vendor crash isolation, continuous scene/VST3 state recall, physical output patches and full hardware FAT are separate gates. | ||
|
|
||
| ## Validation | ||
|
|
||
| The extended `ARMixLiveChannelFxTests` executes a simulated real JUCE channel processor and verifies no allocation on the native callback loop; Windows MSVC CTest and Chromium UI smoke should be required on this PR before merge. CI alone does **not** validate audio hardware. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Oops, something went wrong.
Oops, something went wrong.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Uh oh!
There was an error while loading. Please reload this page.