Skip to content

P0 GUI: channel-aware FX Racks, yellow-green toolbar and machined fader bed (#95) - #97

Closed
masarray wants to merge 5 commits into
mainfrom
fix/p0-fx-rack-fader-premium-20261027
Closed

masarray wants to merge 5 commits into
mainfrom
fix/p0-fx-rack-fader-premium-20261027

Conversation

@masarray

@masarray masarray commented Oct 27, 2026 •

Copy link
Copy Markdown
Owner

P0 implemented from latest reconciled main (includes merged PR #96)

This is the GUI P0 slice of Issue #95, not a claim of complete multi-channel native DSP or live-safe FX reorder.

  • MIX: all 10 channel strips plus MASTER display six consistent rack slots, with a visible ADD FX affordance and truthful native state. CH1 retains real JUCE VST3/editor/bypass. CH2–10 and MASTER open their selected FX Rack and explicitly report routing pending instead of pretending mock EQ/compressors affect sound.
  • FX RACK: native channel selector covers CH1–10 + MASTER, preserves channel/master selection. Standalone preview supports a MASTER chain editor and refresh after adding/bypassing. No fake plugin instantiated by unsupported native channels.
  • Toolbar: all seven BTN-180 action pads are muted yellow-green at rest (OFF #adc875; selected #b9cf77) instead of white/grey; dark legible captions, same approved seven-layer physical shadows, 1px click, unchanged semantic device/MUTE/SOLO/rail palettes.
  • Fader: static full-height recessed dark bed + independent narrow black groove behind original 36×77 ARI cap. No CSS blur/glow/filter/motion; existing detent calibration, drag behavior and native fader mapping preserved.
  • Native perf: unchanged Channel 1 VST processing and Orbit; CH2–10/MASTER markup patched only once per rebuilt strip via signature guards, not every 12Hz status tick. No audio callback, LiveAudioEngine.h, ASIO/WASAPI, device or graph mutation changes.
  • CSS-source/build/offline parity maintained; JS contract smoke extended. Branch reconciled with merged PR P0 GUI rendering: 7px LED dirty-write gate and idempotent native status (#56) #96 pointer/meter dirty-write optimizations, not overwritten.

Verification

Chromium/Firefox UI smoke, native Windows MSVC+CTest/build, CSS compilation/parity, stable button and fader assets required. The Windows first review run passed native JS/CTest/build/package; UI tests identified old palette and master-context expectations which are corrected in this branch. Do not mark complete until CI on exact final head is green.

Explicit non-goals

P1 native per-channel routing and graphs, P2 atomic drag reorder, and P3 full DSP + hardware FAT remain open under #95. #15 0-VST audio qualification and #56 standard-PC pointer field performance remain open.

Copy link
Copy Markdown
Owner Author

Superseded by approved folded-metal fader PR #120 and consolidated FX interaction/reorder PR #122 (main@15450e64). This outdated GUI branch must not overwrite the native bridge, meter/Orbit or new FX logic. Retained as a historical design reference.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant