Repository navigation
P0 GUI: restore true folded-metal fader recess on 10 channels + MASTER in latest build - #120
Merged
Conversation
…ER with offline parity and computed-style regression
Codex Review SummaryThis comment shows the latest Codex review activity on this pull request.
ℹ️ About Codex in GitHubYour team has set up Codex to review pull requests in this repo. Reviews are triggered when you
Codex reacts with 👀 while any review is running, comments if it has suggestions, and reacts with 👍 once all reviews finish with no findings. |
This was referenced Oct 28, 2026
Closed
P0: integrate FX drag + atomic reorder into latest main without losing bypass/Orbit/meter/fader
#122
Merged
Closed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fix: missing true machined slider recess in the latest Windows build
User reported that the fader thumb travel area did not have the expected bent-metal smooth recess. Root cause: dedicated PR #102 containing the final 46px smooth full-height recess was still OPEN, and main/Windows
main@4951f3bonly contained the old travel-length::before/::afterstyling. PR #97 was also OPEN and retained a more rectangular, brighter design.This cherry-picks ONLY the physical fader recess CSS, NOT the unmerged FX reorder/audio graph/single-instance code from PR #102, into the latest approved GUI baseline:
min(46px,100%), gentle four-sided inset folds and softened lips, no glowing/white rectangular frame, no CSS gradient/blur or motion; independent center black 5px slit, full thumb stroke.web/styles-src/42-mixer-premium.css, compiledweb/styles.cssand offlineAR-MIX-Live-FX-Host-Standalone-v0.3.htmlin byte-for-byte parity; no stale WebView2 artifact.tests/fader_asset_test.pywith source-owned recess and no per-frame filters plus Playwrighttests/ui_smoke.pyvalidating computed pseudo-element bay/slit geometry/color/border for all 11 faders. CI screenshots remain available on UI smoke run.Gate: exact PR head Chromium/Firefox GUI + Windows native/build/CTest and SHA-attested artifacts PASS. Physical human review needed for visual finish; do not claim screenshot-based pixel approval based on structural CSS checks alone.
Reference: PR #102 planned recess. Do not merge old PR #102 wholesale after this without conflict-aware reconciliation.