Skip to content

P0 GUI: restore true folded-metal fader recess on 10 channels + MASTER in latest build - #120

Merged
masarray merged 1 commit into
mainfrom
fix/gui-true-machined-fader-recess-main-20261028
Oct 28, 2026
Merged

masarray merged 1 commit into
mainfrom
fix/gui-true-machined-fader-recess-main-20261028

Conversation

@masarray

Copy link
Copy Markdown
Owner

Fix: missing true machined slider recess in the latest Windows build

User reported that the fader thumb travel area did not have the expected bent-metal smooth recess. Root cause: dedicated PR #102 containing the final 46px smooth full-height recess was still OPEN, and main/Windows main@4951f3b only contained the old travel-length ::before/::after styling. PR #97 was also OPEN and retained a more rectangular, brighter design.

This cherry-picks ONLY the physical fader recess CSS, NOT the unmerged FX reorder/audio graph/single-instance code from PR #102, into the latest approved GUI baseline:

  • single graphite bay bounded by min(46px,100%), gentle four-sided inset folds and softened lips, no glowing/white rectangular frame, no CSS gradient/blur or motion; independent center black 5px slit, full thumb stroke.
  • all 10 source channels + MASTER, same 36x77px silver/rose-gold original thumb PNG, unchanged precise 38px detent and gain dB ruler, fixed level-meters, and no new event handlers or RT/audio callback changes.
  • update source-owned web/styles-src/42-mixer-premium.css, compiled web/styles.css and offline AR-MIX-Live-FX-Host-Standalone-v0.3.html in byte-for-byte parity; no stale WebView2 artifact.
  • extend tests/fader_asset_test.py with source-owned recess and no per-frame filters plus Playwright tests/ui_smoke.py validating computed pseudo-element bay/slit geometry/color/border for all 11 faders. CI screenshots remain available on UI smoke run.
  • Keeps current portable Studio P1–P3, Orbit, fader and meter ballistics, 10CH prepared routing tests and concurrent audio work intact. No DSP/JS/native code touched.

Gate: exact PR head Chromium/Firefox GUI + Windows native/build/CTest and SHA-attested artifacts PASS. Physical human review needed for visual finish; do not claim screenshot-based pixel approval based on structural CSS checks alone.

Reference: PR #102 planned recess. Do not merge old PR #102 wholesale after this without conflict-aware reconciliation.

…ER with offline parity and computed-style regression
@chatgpt-codex-connector

chatgpt-codex-connector Bot commented Oct 28, 2026 •

Copy link
Copy Markdown

Codex Review Summary

This comment shows the latest Codex review activity on this pull request.

Review Status Commit Review trigger
📝 Code Review ✅ Completed 2026-10-28T00:58:45.722225Z c2bccd5 PR opened
ℹ️ About Codex in GitHub

Your team has set up Codex to review pull requests in this repo. Reviews are triggered when you

  • Open a pull request for review
  • Mark a draft as ready
  • Comment "@codex review" or "@codex security review".

Codex reacts with 👀 while any review is running, comments if it has suggestions, and reacts with 👍 once all reviews finish with no findings.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant