Skip to content

perf(gui): 30fps native LED meter with responsive attack and gravity release (#56) - #100

Merged
masarray merged 5 commits into
mainfrom
perf/p0-native-meter-ballistics-30fps-20261027
Oct 27, 2026
Merged

masarray merged 5 commits into
mainfrom
perf/p0-native-meter-ballistics-30fps-20261027

Conversation

@masarray

Copy link
Copy Markdown
Owner

User goal and screenshot review

User's Windows 11 Pro native EXE screenshot shows a stepped, rigid channel-1 LED meter. Request: cap meter FPS, fast upward response, slower naturally accelerating fall, smoother but lightweight rendering, plus audit for globally professional GUI.

Source-grounded diagnosis

JUCE already publishes real native status at 12 Hz (src/Main.cpp). Previous live meter output in web/bridge.js reduces the level by a constant -5 per 12Hz callback. Rendering makes fixed-palette 7px LED segments, optimized in PR #96. GPU compositor hardware measurements still missing.

Implementation

  • Native status supplies raw, unchanged input and master peak targets; no callback-count-based release logic.
  • web/app.js adds one lazy shared visual scheduler using 34ms timeout → single requestAnimationFrame, at most ~29.4 scheduled visual frames/s for up to 4 native LED targets. No one-RAF-per-strip, no perpetual idle timer, stops when settled.
  • 18ms exponential attack, then elapsed-time based gravity fall (14 unit/s initial, +230 units/s², cap 100 units/s). Bounded delta, no overshoot. Reduced-motion and ?metermotion=direct opt-out.
  • One-time startup zero-clear uses the direct painter for all unrouted preview channels, so no 16-channel animation Map is created. On scene/FX redraw, prune detached DOM nodes; background tabs cancel pending animations.
  • Preserve exact meter colors/geometry, audio data cadence, CLIP/peak, faders/PAN, Orbit, native DSP, scene snapshots and BTN-180.
  • Standalone embedded app.js JS byte-for-byte synchronized; CSS untouched.
  • Adds deterministic Chromium ballistic math regressions plus native scheduler static-contract test.

Visual audit and concurrent work

ARD and screenshot-based prioritized visual audit. Parallel PR #97 owns the FX Rack/selection/button/fader visual changes; this patch must preserve and reconcile against PR #97, not overwrite it.

Merge gates

@chatgpt-codex-connector

chatgpt-codex-connector Bot commented Oct 27, 2026 •

Copy link
Copy Markdown

Codex Review Summary

This comment shows the latest Codex review activity on this pull request.

Review Status Commit Review trigger
📝 Code Review ✅ Completed 2026-10-27T14:09:49.330999Z 681f22e PR opened
ℹ️ About Codex in GitHub

Your team has set up Codex to review pull requests in this repo. Reviews are triggered when you

  • Open a pull request for review
  • Mark a draft as ready
  • Comment "@codex review" or "@codex security review".

Codex reacts with 👀 while any review is running, comments if it has suggestions, and reacts with 👍 once all reviews finish with no findings.

@masarray
masarray merged commit 6cafdc5 into main Oct 27, 2026
2 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant