Repository navigation
perf(gui): 30fps native LED meter with responsive attack and gravity release (#56) - #100
Merged
Merged
Conversation
Codex Review SummaryThis comment shows the latest Codex review activity on this pull request.
ℹ️ About Codex in GitHubYour team has set up Codex to review pull requests in this repo. Reviews are triggered when you
Codex reacts with 👀 while any review is running, comments if it has suggestions, and reacts with 👍 once all reviews finish with no findings. |
…r instead of removed 12Hz step variables
…e-release removal
…tive meter change
5 tasks
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
User goal and screenshot review
User's Windows 11 Pro native EXE screenshot shows a stepped, rigid channel-1 LED meter. Request: cap meter FPS, fast upward response, slower naturally accelerating fall, smoother but lightweight rendering, plus audit for globally professional GUI.
Source-grounded diagnosis
JUCE already publishes real native status at 12 Hz (src/Main.cpp). Previous live meter output in web/bridge.js reduces the level by a constant
-5per 12Hz callback. Rendering makes fixed-palette 7px LED segments, optimized in PR #96. GPU compositor hardware measurements still missing.Implementation
web/app.jsadds one lazy shared visual scheduler using 34ms timeout → single requestAnimationFrame, at most ~29.4 scheduled visual frames/s for up to 4 native LED targets. No one-RAF-per-strip, no perpetual idle timer, stops when settled.?metermotion=directopt-out.Visual audit and concurrent work
ARD and screenshot-based prioritized visual audit. Parallel PR #97 owns the FX Rack/selection/button/fader visual changes; this patch must preserve and reconcile against PR #97, not overwrite it.
Merge gates