Skip to content

P0: restore real MASTER L/R LED visibility (preview-only FX CSS collision) - #104

Merged
masarray merged 3 commits into
mainfrom
fix/p0-master-meter-preview-opacity-20261028
Oct 27, 2026
Merged

masarray merged 3 commits into
mainfrom
fix/p0-master-meter-preview-opacity-20261028

Conversation

@masarray

Copy link
Copy Markdown
Owner

Root cause verified against latest main

Screenshot: Channel 1 input meter has actual green LEDs, MASTER L/R dark. LiveAudioEngine.h reports both peakLeft and peakRight and shared 30fps presenter receives them. web/bridge.js::patchMixer wrongly sets data-preview="1" on MASTER purely because its FX/pan are preview-only. Injected native CSS .strip[data-preview="1"] .meter-fill{opacity:0!important} then forces both real MASTER L/R LED fills invisible.

Surgical fix

  • MASTER gets data-fx-preview="1" instead; remove incorrect channel-wide data-preview.
  • Defense in depth: CSS applies preview-only hiding and dimming exclusively to .strip:not(.master-strip)[data-preview="1"].
  • CH2–10 remain dark because audio routing is genuinely unavailable, not because a fake meter is injected.
  • MASTER L/R use real engine output peaks; unchanged native sampling, RT callback, peak hold, clip latch, dual-channel renderer, gravity release, GPU cap, 7-shadow button design, FX Orbit and all FX reorder branches.
  • Regression: real browser-native bridge injection with stub JUCE status (test only) verifies opacity MASTER L/R vs inactive CH2, and test-only nonzero arMixStatus causes both MASTER bars to show LED clips. Static Node contract prevents future preview selector regression.

Reconciled latest merged PR #100 at main@6cafdc5d, concurrent PR #101 CI, PR #102 FX reorder and PR #103 Orbit. No cherry-picking/overwrites of their pending features. Documented ARD with actual root cause.

Merge gates

  • Chromium / Firefox UI smoke including native bridge test
  • Windows native compile + CTest + packaged artifact
  • review feedback resolved, latest main checked and safe merge
  • postmerge exact-main gates green
  • real hardware confirms audible/master output meter correlation (master can correctly be dark when monitor muted).

@chatgpt-codex-connector

chatgpt-codex-connector Bot commented Oct 27, 2026 •

Copy link
Copy Markdown

Codex Review Summary

This comment shows the latest Codex review activity on this pull request.

Review Status Commit Review trigger
📝 Code Review ✅ Completed 2026-10-27T20:54:49.457266Z 62627b3 PR opened
ℹ️ About Codex in GitHub

Your team has set up Codex to review pull requests in this repo. Reviews are triggered when you

  • Open a pull request for review
  • Mark a draft as ready
  • Comment "@codex review" or "@codex security review".

Codex reacts with 👀 while any review is running, comments if it has suggestions, and reacts with 👍 once all reviews finish with no findings.

@chatgpt-codex-connector chatgpt-codex-connector Bot left a comment

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

💡 Codex Review

Here are some automated review suggestions for this pull request.

Reviewed commit: 62627b3396

ℹ️ About Codex in GitHub

Your team has set up Codex to review pull requests in this repo. Reviews are triggered when you

  • Open a pull request for review
  • Mark a draft as ready
  • Comment "@codex review".

If Codex has suggestions, it will comment; otherwise it will react with 👍.

Codex can also answer questions or update the PR. Try commenting "@codex address that feedback".

Comment thread tests/ui_smoke.py Resolved
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant