Repository navigation
P0: restore real MASTER L/R LED visibility (preview-only FX CSS collision) - #104
Merged
Merged
Conversation
Codex Review SummaryThis comment shows the latest Codex review activity on this pull request.
ℹ️ About Codex in GitHubYour team has set up Codex to review pull requests in this repo. Reviews are triggered when you
Codex reacts with 👀 while any review is running, comments if it has suggestions, and reacts with 👍 once all reviews finish with no findings. |
There was a problem hiding this comment.
💡 Codex Review
Here are some automated review suggestions for this pull request.
Reviewed commit: 62627b3396
ℹ️ About Codex in GitHub
Your team has set up Codex to review pull requests in this repo. Reviews are triggered when you
- Open a pull request for review
- Mark a draft as ready
- Comment "@codex review".
If Codex has suggestions, it will comment; otherwise it will react with 👍.
Codex can also answer questions or update the PR. Try commenting "@codex address that feedback".
This was referenced Oct 27, 2026
Closed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Root cause verified against latest main
Screenshot: Channel 1 input meter has actual green LEDs, MASTER L/R dark.
LiveAudioEngine.hreports bothpeakLeftandpeakRightand shared 30fps presenter receives them.web/bridge.js::patchMixerwrongly setsdata-preview="1"on MASTER purely because its FX/pan are preview-only. Injected native CSS.strip[data-preview="1"] .meter-fill{opacity:0!important}then forces both real MASTER L/R LED fills invisible.Surgical fix
data-fx-preview="1"instead; remove incorrect channel-widedata-preview..strip:not(.master-strip)[data-preview="1"].arMixStatuscauses both MASTER bars to show LED clips. Static Node contract prevents future preview selector regression.Reconciled latest merged PR #100 at
main@6cafdc5d, concurrent PR #101 CI, PR #102 FX reorder and PR #103 Orbit. No cherry-picking/overwrites of their pending features. Documented ARD with actual root cause.Merge gates
mainchecked and safe merge