Repository navigation
fix(orbit): contextual VST3 parameter dropdowns and exact Near/Far metre endpoints - #103
Conversation
… sampled ellipse endpoint capture
Codex Review SummaryThis comment shows the latest Codex review activity on this pull request.
ℹ️ About Codex in GitHubYour team has set up Codex to review pull requests in this repo. Reviews are triggered when you
Codex reacts with 👀 while any review is running, comments if it has suggestions, and reacts with 👍 once all reviews finish with no findings. |
There was a problem hiding this comment.
💡 Codex Review
Here are some automated review suggestions for this pull request.
Reviewed commit: e6c37d04f3
ℹ️ About Codex in GitHub
Your team has set up Codex to review pull requests in this repo. Reviews are triggered when you
- Open a pull request for review
- Mark a draft as ready
- Comment "@codex review".
If Codex has suggestions, it will comment; otherwise it will react with 👍.
Codex can also answer questions or update the PR. Try commenting "@codex address that feedback".
| const elevationSel=orbit.elevationSelection>=0?orbit.elevationSelection: | ||
| (running&&orbit.shape===shape?orbit.elevationIndex:orbit.preferredElevation); | ||
| const valid=options.some(p=>p.index===selected); | ||
| const valid=candidates("azimuth").some(p=>p.index===selected); |
There was a problem hiding this comment.
Initialize the candidate filter before validating selections
Opening the native ORBIT popup calls renderOrbit(), which now invokes candidates("azimuth") before the const candidates initializer executes. This throws ReferenceError: Cannot access 'candidates' before initialization on every render, even with an empty parameter list, so the popup never renders its controls and users cannot start Orbit. Reproduced by executing the actual renderOrbit() function in Node; move the candidate-filter declaration above its first use.
Useful? React with 👍 / 👎.
Windows hardware reproduction
0.1–30 mnext to its label. A user selecting Far=2 m hears/sees1.99 minstead of the intended setpoint.Scoped correction
30mlabels leaking into the dropdown. Does not change mixer theme or other FX workflows.Qualification
CI tests math, bridge and build; physical dearVR PRO 2 is still required to validate vendor distance, perceived seam and acoustic response. No claim of measured spatial DSP correctness. One PR commit to minimize Actions waste; branch rooted on main
6cafdc5, keep independent lean-CI PR #101 untouched.