Skip to content

fix(orbit): contextual VST3 parameter dropdowns and exact Near/Far metre endpoints - #103

Merged
masarray merged 4 commits into
mainfrom
fix/orbit-context-exact-distance-20261028
Oct 27, 2026
Merged

masarray merged 4 commits into
mainfrom
fix/orbit-context-exact-distance-20261028

Conversation

@masarray

Copy link
Copy Markdown
Owner

Windows hardware reproduction

  • The Distance selector displays unrelated Gain/Reverb/X/Y/Z and a confusing vendor maximum 0.1–30 m next to its label. A user selecting Far=2 m hears/sees 1.99 m instead of the intended setpoint.

Scoped correction

  • Contextual plugin parameter selectors: Azimuth / Distance / Elevation dropdowns show only automatable parameters matching their semantic role and exclude Scale/Range/Width/Occlusion. Existing vendor indices remain authoritative; no guessed parameter mapping. Dropdown labels are concise names only. The vendor maximum is still enforced as a validation bound but no longer presented as a selected Orbit preset value.
  • Exact meter mapping: Pure C++ inversion searches the plateau of the vendor's formatted VST3 parameter text, selects its midpoint and round-trips exactly to the requested displayed metre value. A metre value not representable by the vendor's resolution returns a readable error, rather than silently accepting 1.99 m as 2 m. No assumption that plugin distance mapping is linear.
  • Actual ellipse endpoints: capture near/far phase-extremum crossings between 60 Hz ticks and publish the exact normalized user setpoint for that control tick. Avoid catch-up bursts for long stalls; preserve existing initial 300 ms easing. No audio callback work, new threads or extra plugins.
  • Regression: Windows C++ Release CTest for nonlinear/quantized vendor mapping and extremum crossings; Chromium real FX popup selector tests to prevent unrelated VST3 parameters and 30m labels leaking into the dropdown. Does not change mixer theme or other FX workflows.

Qualification

CI tests math, bridge and build; physical dearVR PRO 2 is still required to validate vendor distance, perceived seam and acoustic response. No claim of measured spatial DSP correctness. One PR commit to minimize Actions waste; branch rooted on main 6cafdc5, keep independent lean-CI PR #101 untouched.

@chatgpt-codex-connector

chatgpt-codex-connector Bot commented Oct 27, 2026 •

Copy link
Copy Markdown

Codex Review Summary

This comment shows the latest Codex review activity on this pull request.

Review Status Commit Review trigger
📝 Code Review ✅ Completed 2026-10-27T20:42:24.875120Z e6c37d0 PR opened
ℹ️ About Codex in GitHub

Your team has set up Codex to review pull requests in this repo. Reviews are triggered when you

  • Open a pull request for review
  • Mark a draft as ready
  • Comment "@codex review" or "@codex security review".

Codex reacts with 👀 while any review is running, comments if it has suggestions, and reacts with 👍 once all reviews finish with no findings.

@chatgpt-codex-connector chatgpt-codex-connector Bot left a comment

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

💡 Codex Review

Here are some automated review suggestions for this pull request.

Reviewed commit: e6c37d04f3

ℹ️ About Codex in GitHub

Your team has set up Codex to review pull requests in this repo. Reviews are triggered when you

  • Open a pull request for review
  • Mark a draft as ready
  • Comment "@codex review".

If Codex has suggestions, it will comment; otherwise it will react with 👍.

Codex can also answer questions or update the PR. Try commenting "@codex address that feedback".

Comment thread web/bridge.js Outdated
const elevationSel=orbit.elevationSelection>=0?orbit.elevationSelection:
(running&&orbit.shape===shape?orbit.elevationIndex:orbit.preferredElevation);
const valid=options.some(p=>p.index===selected);
const valid=candidates("azimuth").some(p=>p.index===selected);

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

P1 Badge Initialize the candidate filter before validating selections

Opening the native ORBIT popup calls renderOrbit(), which now invokes candidates("azimuth") before the const candidates initializer executes. This throws ReferenceError: Cannot access 'candidates' before initialization on every render, even with an empty parameter list, so the popup never renders its controls and users cannot start Orbit. Reproduced by executing the actual renderOrbit() function in Node; move the candidate-filter declaration above its first use.

Useful? React with 👍 / 👎.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant