Skip to content

feat(gui): contextual GAIN/FX RACK and safe Sends-on-Faders console workflow - #604

Merged
3 commits merged into
mainfrom
feat/console-contextual-gain-sof-20261112
Nov 13, 2026
Merged

3 commits merged into
mainfrom
feat/console-contextual-gain-sof-20261112

Conversation

@masarray

Copy link
Copy Markdown
Owner

Purpose

A single contextual console based on the existing approved /preview/ GUI, grounded in Yamaha DM7 StageMix, Waves LV1 Fader Flip, Allen & Heath Avantis, and Studio One SEND racks. No duplicate mixer UI.

Shipped on branch (browser reference UI)

  • Interlocked GAIN / FX RACK toolbar view; the selected bank's original FX section shows compact digital trim knob + dB LCD or the original FX slot list without touching FX state. MAIN strip, faders, sockets, meters and approved hardware PNGs stay in place.
  • Sends on Faders has clear SEND MIX → bus context; source FX cell displays the target route, actual POST-FADER/PRE-FX state and the same approved Harmonice PNG PRE/POST artwork. MUTE/SOLO stay channel controls.
  • SOF PRE/POST now edits only the selected target send EdgeId, not all outgoing sends. Outside SOF, mixed multi-send PRE/POST no longer silently rewrites the entire send inventory.
  • Critical routing safety: moving an SOF fader to −60 dB changes only existing send gain and never removes the WIRE. Moving a fader without a send does not create a hidden WIRE; the fader is disabled until the route is explicitly connected.
  • Fail closed for unadmitted native input Gain (the native bridge hides the demo-only GAIN view). The native bridge already hides SOF for lack of acknowledged native send-gain operations.

Tests/evidence

  • In-editor V8 JavaScript syntax parse and scoped invariants PASS (no auto CONNECT/REMOVE in setSofLevel; native gate; pinned MAIN; original FX state).
  • New Chromium smoke at 1366×768, 1680×900, 1920×1080 checks interlock, knob/LCD, SOF context, approved PRE/POST sprite, explicit WIRE requirement, normal mode restoration and no JS errors. Test is committed but CI has not been run yet.

Boundaries / follow-up

  • Not yet native DSP: PRE in browser graph currently means pre-FX, not verified post-insert/pre-fader. A true pre-fader tap, native per-ChannelId digital gain, per-EdgeId tap/level/ON ACK/readback, and real ASIO FAT require a subsequent integrated PCM milestone. Do not label this a fully working Windows feature or publish release from this PR.
  • No new PCM callback, VST3 reload, WIRE route admission, CSS replacement skin or modified raster button asset.
  • Leave PR draft until exact-SHA UI qualification and any failed checks are resolved. Avoid duplicate Windows or FAT runs for GUI-only prototype.

Sources

  • Yamaha DM7 StageMix FADER MODE and SENDS PRE/SEND ON user guide
  • Waves eMotion LV1 Classic Console Sends-On-Faders and AUX source tap docs
  • Allen & Heath Avantis Pre Mix binding
  • Studio One send device rack pre/post level/pan docs

@cloudflare-workers-and-pages

cloudflare-workers-and-pages Bot commented Nov 12, 2026 •

Copy link
Copy Markdown

Deploying arsonmix with  Cloudflare Pages  Cloudflare Pages

Latest commit: 3b2e4f0
Status:⚡️  Build in progress...

View logs

Copy link
Copy Markdown
Owner Author

/arsonmix-ci ui 730cf9e

Copy link
Copy Markdown
Owner Author

/arsonmix-ci ui 274d0db

@masarray
masarray force-pushed the feat/console-contextual-gain-sof-20261112 branch from 274d0db to 0bd69fe Compare November 12, 2026 14:01

Copy link
Copy Markdown
Owner Author

/arsonmix-ci ui 0bd69fe

Copy link
Copy Markdown
Owner Author

/arsonmix-ci ui 3b2e4f0

Copy link
Copy Markdown
Owner Author

Owner-approved contextual GAIN/FX RACK + SOF PRD/ARD merged into main in docs-only #609 (93525087404e63288cffe8383ef0c8f989f3c825): PRD and ARD. Root AGENTS.md also contains a READ FIRST link.

Per current live integration plan, #606 already includes the browser contextual GUI changes from #604 and is the more advanced product branch; refresh current heads and reconcile there rather than double-merging this PR. Required future native work: actual ChannelId Input Gain before FX, true POST-INSERT PRE_FADER distinct from PRE_FX, selected EdgeId gain/tap/send ON controls with installed PCM ACK/readback, and physical FAT. SEND minimum/OFF retains WIRE; a demo Pages view is not native audio proof. No GUI asset redesign or duplicate mixer.

Copy link
Copy Markdown
Owner Author

Integration handoff from user-approved Harmonice v9 PFL FontMatched artwork, implemented separately in PR #610 without altering your active SOF branch.

Important SOF contract to preserve when reconciling with latest main:

  • MAIN MIX key row remains MUTE / SOLO / PRE–POST (routing control).
  • In SOF audio strips, the key row is MUTE / SOLO / blue PFL; BUS/FX and MASTER use 2 keys. Your per-EdgeId PRE/POST remains in the contextual SEND/FX panel, NOT the key row.
  • Reuse exact harmonice-thin-flat-v9-pfl-font-matched-57x30.png from site/preview-buttons/assets and existing v9 MUTE/SOLO sprite/CSS owner. Do not recreate in CSS or duplicate renderer.
  • Browser PFL is visual reference only, channel cue state. Clear on SOF exit. Native PFL remains unavailable/disabled until independent MONITOR L/R pre-fader PCM route + ACK/readback; never silently mix cue into MAIN.
  • Integration points from Mixer keys v9: approved MUTE/SOLO/PFL in Sends on Faders #610: strip(t) uses sofPfl = sofEnabled && t.kind==='audio' and hasTap = t.kind!=='master' && !sofEnabled; CSS frame mapping uses data-hw-kind="pfl" and the standalone 2-frame PNG. Browser Stage D checks the real SOF toolbar workflow.

This deliberately does not push into or merge your branch while SOF is being developed; please forward-port these decisions during your own reconciliation. Contract: docs/HARMONICE_PHYSICAL_KEYS_SOF_CONTRACT.md in #610.

masarray added a commit that referenced this pull request Nov 12, 2026
* Integrate MUTE/SOLO/PFL in SOF only while preserving MAIN PRE/POST and native cue safety

* Use exact approved blue PFL OFF/ON raster and v9 OFF shadow in SOF key row

* Ship the PFL FontMatched alpha PNG in the same Pages/native GUI assembler

* Add exact approved PFL FontMatched OFF/ON transparent PNG sprite (2×57x30)

* Account for approved PFL extension sprite in exact Pages/native asset inventory

* Lock exact approved PFL raster hash and workspace/native safety in fast key contracts

* Use explicit PNG signature bytes for approved PFL raster contract

* Chromium verifies blue PFL raster, state and SOF-only visibility in existing Stage D session

* Document approved physical key ownership, SOF PFL safety and PR #604 forward-port contract

Copy link
Copy Markdown
Owner Author

P0 user correction now codified in PR #612 (#612): the approved v9 FontMatched physical key row must be MUTE / SOLO / PFL in default MAIN MIX, not just in SOF. PR #610 previously showed PRE/POST in MAIN, which the user explicitly rejected. Keep PFL in BOTH MAIN MIX and SOF and MASTER at MUTE/SOLO. The exact PNG files/CSS hardware owner must not be repainted. PRE/POST send tap is per-EdgeId in WIRE inspector and your contextual SEND CONTROLS, never replace the third physical PFL key or mass-retarget all sends. Browser cue remains visual-only and native requires independent MONITOR L/R with ACK. This is a forward-port requirement: merge/rebase from latest main (#612 after its tests) before integrating #604, without regressing GAIN/FX/SOF work.

Copy link
Copy Markdown
Owner Author

Heads-up: owner-approved tactile GUI correction is now merged as #613, main SHA dbade63. Forward-port before merging this draft: Main Mix source channel fader physical unity detent (7px capture/12px release, Alt bypass, final change to native ACK); taller shared source/MASTER/rail fader height; WIRE 460ms OUT→IN spring + 190ms settle; and fully continuous, brighter 5.6px selected real SVG jacket with transparent click hitbox. Preserve exact approved MUTE/SOLO/PFL PNGs and your distinct contextual SOF FX/GAIN/SonKu work. Do not cherry-pick an old index.html that reverts main key/fader/wire fixes. UI-only change, not evidence of physical PCM/ASIO.

@masarray masarray closed this pull request by merging all changes into main in 79cedaf Nov 13, 2026
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant