Skip to content

feat(native): real Input Gain, per-EdgeId PRE/POST & ramped SEND ON/OFF + PCM tests - #614

Draft
masarray wants to merge 26 commits into
mainfrom
feat/send-edge-enabled-native-contract-20261113
Draft

masarray wants to merge 26 commits into
mainfrom
feat/send-edge-enabled-native-contract-20261113

Conversation

@masarray

@masarray masarray commented Nov 13, 2026 •

Copy link
Copy Markdown
Owner

Native GAIN + PRE/POST + SEND ON/OFF (one PCM graph)

Owner spec: PRD · ARD (approved and merged #609).

Implemented on this draft branch

  1. Real DIGITAL INPUT GAIN before channel FX (not mic preamp/fader/send): ChannelId model, 0..16 linear range with intended −24..+24 dB logical edit, realtime target and 64-sample slew in the existing callback; time/epoch/revision-checked native publisher and accepted session persistence through recompile. .smix field default unity for legacy.
  2. One exact EdgeId PRE_FADER/POST_FADER tap: role validation prevents edits on exclusive PRIMARY OUT, retains EdgeId/gain/ON. The native PRE_FADER PCM tap is post-processing and pre-channel-fader. The legacy Pages PRE_FX split is NOT this tap. Existing legacy snapshot string SPLIT_PRE remains for compatibility; the new tapStage explicitly says PRE_FADER or POST_FADER.
  3. SEND ON/OFF separately from WIRE and gain: ChannelSendRef.enabled, .smix backward-compatible serialization, truthful LOGICAL_ONLY state, true native accepted routing view. OFF does NOT remove the cable, retarget tap, reset send pan/gain or affect primary OUT. A realtime per-EdgeId enable target ramps the existing send gain to zero over 64 samples without a structural rebuild; ON restores saved gain with the same ramp. Gain edits cannot silently unmute a disabled edge.
  4. Control-thread/GUI truth: New LOGICAL_ONLY controls SET_INPUT_GAIN, SET_SEND_ENABLED, SET_SEND_TAP validate channel/edge and stale revisions. Real Windows WebView2 / installed PCM commands are not yet admitted and remain fail-closed (no fake button).
  5. Deterministic test improvement: existing Linux C++20 fast workflow now compiles and executes the full native PCM session test as well as offline roster tests, in one lightweight job; no duplicate Windows or Chromium pipeline. Added PCM tests of input gain before nonlinear FX, 64-sample output ramps, post-FX PRE vs POST at channel fader zero, ON/OFF unchanged graph/EdgeId, session restore, and invalid/primary/stale rejection.

Evidence / exact status

  • Candidate HEAD: 90f64bad4a8bb906f24503512886d908c904b759.
  • Linux C++20 logical + deterministic native PCM PASS at this exact head, both compile-and-run steps green. Earlier failed intermediate test was corrected before final head and is not treated as qualification.
  • This branch touches C++ core/graph/logical/session/CI and two tests, not approved HTML/CSS/PNG/SVG or hardware I/O.
  • No Windows native host acceptance, real ASIO/FAT or user-test installer is claimed. The automatic fast native-contract check is tracked separately. Heavy Windows native/FAT is deferred until the code is integrated with the current GUI/SonKu branch so the same source need not be rebuilt twice.

Next integrated milestone (not delivered here)

@cloudflare-workers-and-pages

cloudflare-workers-and-pages Bot commented Nov 13, 2026 •

Copy link
Copy Markdown

Deploying arsonmix with  Cloudflare Pages  Cloudflare Pages

Latest commit: 90f64ba
Status: ✅  Deploy successful!
Preview URL: https://9b21ee22.arsonmix.pages.dev
Branch Preview URL: https://feat-send-edge-enabled-nativ.arsonmix.pages.dev

View logs

@masarray masarray changed the title feat(native): independent per-EdgeId SEND ON/OFF, persisted state and PCM regression feat(native): pre-FX digital Gain, per-EdgeId PRE/POST, SEND ON/OFF and PCM tests Nov 13, 2026
@masarray masarray changed the title feat(native): pre-FX digital Gain, per-EdgeId PRE/POST, SEND ON/OFF and PCM tests feat(native): real Input Gain, per-EdgeId PRE/POST & ramped SEND ON/OFF + PCM tests Nov 13, 2026

Copy link
Copy Markdown
Owner Author

Cross-PR integration note (2026-11-13): GUI/bridge SOF target-ID, PRE selection and native reset safety is merged into the advanced #606 SonKu/contextual-console branch via #620 (merge fab6e6d).

The latest #606 already has Input Gain, independent SEND enabled, native SET_TAP and installed control-intent support in several of the SAME source files as this #614 draft. Please compare exact native DSP semantics and deterministic PCM test coverage before integrating #614. Do NOT blindly merge the overlapping core files or overwrite #606 SonKu, approved PNG/fader, #613/#616/#618 geometry fixes. Reuse unique tests/defect repairs in one canonical PCM authority; no second callback.

Both fast tests passed on #620 exact source SHA 25fa8c0. These do not prove actual Windows ASIO or full Chromium FAT, so maintain fail-closed native admission until exact final integrated build is qualified.

Copy link
Copy Markdown
Owner Author

Integration reconciliation 2026-11-13: The existing #606 branch already carried PCM implementations for native input trim, SEND enable gate and 64-sample ramps, so wholesale merge of #614 would duplicate/overwrite publisher/graph changes. Non-duplicating logical EdgeId SEND ON/OFF + PRE/POST editor, accepted-session API parity, and #614's offline/PCM regression coverage were forward-ported via #623, now merged into #606 at dc84e8d2c499f2c4a7b0d85db48fd02dc2a2df91 (Linux PCM and native-source quick checks PASS). #614 must NOT be double-merged. Review its remaining EdgeId-level publisher implementation improvements, separate PRE_FX vs PRE_FADER semantics, and installed Windows/ASIO qualification against #606 before deciding whether any additional targeted changes are needed. #606 remains draft; main not updated.

This branch has not been deployed

No deployments
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant