You signed in with another tab or window. Reload to refresh your session.You signed out in another tab or window. Reload to refresh your session.You switched accounts on another tab or window. Reload to refresh your session.Dismiss alert
{{ message }}
Repository navigation
refactor(gui): one WIRE/BUS/MAIN EdgeId gesture and gain presentation ViewModel (GUI-3) - #774
GUI-3 — native approved /preview/ presentation only
Baseline: GUI-1 #769, canonical GUI-2 #773 merged to main. Overlapping GUI-2 alternative #772 closed without merge. Audited current AGENTS, #708 factory reset, #614 native send/tap and older #661, #635 drafts; do not own their native session/WIRE engine or visual layout.
Real source ownership moved
Pure web/approved-wire-view-model.js now owns one exact uint64 string ChannelId+EdgeId parallel SEND selector, gain draft mapping (-60 dB floor = zero PCM), accepted dB/pending readback for inspector/SOF, stale/re-targeted graph rejection versus unchanged-gain no-op, and legacy inspector MODE → real PRE_FADER/POST_FADER gesture mapping.
Existing approved bridge admittedParallelWire, requestWireGain, flushWireGains, nativeWireGainReadback, and MODE handler are consumers of the same selectors instead of five independently duplicated checks. Accepted native controller/ACK/readback and original WIRE signal/gesture DOM remain the only route authority.
Critical invariant: PRIMARY_OUT/ROUTE_ONLY is never an editable SEND, even to MAIN; legitimate PARALLEL_SEND to either BUS or MAIN remains supported. Never address native EdgeId via JS Number, track label or WebView ordinal.
Native-only bundler stages this module before the bridge; existing public /preview/ layout/CSS/PNG untouched. Test both real assembled Chromium injection and exact asset parity.
Three new deterministic Node contracts for exact ids, duplicate/retargeted edges, gain floor/pending readback/tap labels and stale graph; existing fader/native bridge harness updated to use actual module.
Measurable delta
WIRE bridge: 4133 → 4119 lines (-14 net); old per-handler math/conditional policies removed, no new event emitter or native action.
One 48-line pure read model; 7 changed JS/test/bundle files total.
Zero C++/PCM/ASIO/DSP/VST3/FX editor/.smix schema/CSS/HTML/PNG changes; no new browser mixer engine or standalone WIRE authority.
Finish gate
Fast UI/native/release exact head + one full Chromium compiled native /preview/ gate, then reconcile current main and required gate before merge. Windows physical hardware/acoustic tests and installer NOT RUN for GUI-only work.
Parallel GUI-3 overlap: PR #775 opened and touches the SAME 7 files/module (approved-wire-view-model.js), with expanded edgePresentation/SOF selectors. Its fast UI/native initially failed stale source-regex assertions at 89c6af3; #774 fast UI/native/release PASS at 10e4d659, full native Chromium #44230005903 running. Neither PR should merge blindly alongside the other. Review #775's broader helpers vs #774's isolated gainDraft/flushDecision and retain only one canonical implementation after exact-head full Chromium + required gate. No force-push or JS routing owner duplication.
Live audit finds overlapping PR #775 at head 05539e3e26b8c35e01bfee1f2a23b93ae9a319a9 (base main@87a1abe439fd3d5cc205338e2758cba1d9c0cff7), modifying all 7 of the same files including web/approved-wire-view-model.js. #775 adds materially broader native edgePresentation (explicit PRIMARY vs PARALLEL SEND incl MAIN/BUS), acceptedParallelEdge, tap/SOF eligibility and fail-closed gain readback; therefore it is the preferred GUI-3 canonical architecture rather than merging two WIRE ViewModels.
This alternative #774 is 10e4d659777ddbde37ccca66ecc681c313742899. Fast native/UI/release PASS44229833178, 44229833027, 44229833038. Full native /preview/ Chromium 44230005903 was running at review time; source parity on this alternative does NOT justify replacing #775. No hardware Windows/ASIO/DSP changes, no force push or cross-thread branch merge.
The unique pure, isolated helpers in #774 for possible targeted future forward-port to #775 are (1) gainDraft mapping WIRE -60 dB to zero PCM and retaining graph identity, and (2) flushDecision returning STALE / UNROUTED / UNCHANGED / SEND to avoid replay into another graph. Both would REMOVE the corresponding existing bridge conditions rather than duplicate them. Do not bulk merge #774 or import its entire ViewModel.
STATUS:#774 CLOSED WITHOUT MERGE; GUI-3 target #775 still needs exact-head full Chromium, required gate and merge. Tindakan operator: none.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
GUI-3 — native approved /preview/ presentation only
Baseline: GUI-1 #769, canonical GUI-2 #773 merged to main. Overlapping GUI-2 alternative #772 closed without merge. Audited current AGENTS, #708 factory reset, #614 native send/tap and older #661, #635 drafts; do not own their native session/WIRE engine or visual layout.
Real source ownership moved
web/approved-wire-view-model.jsnow owns one exact uint64 stringChannelId+EdgeIdparallel SEND selector, gain draft mapping (-60 dB floor = zero PCM), accepted dB/pending readback for inspector/SOF, stale/re-targeted graph rejection versus unchanged-gain no-op, and legacy inspector MODE → real PRE_FADER/POST_FADER gesture mapping.admittedParallelWire,requestWireGain,flushWireGains,nativeWireGainReadback, and MODE handler are consumers of the same selectors instead of five independently duplicated checks. Accepted native controller/ACK/readback and original WIRE signal/gesture DOM remain the only route authority.PRIMARY_OUT/ROUTE_ONLYis never an editable SEND, even to MAIN; legitimatePARALLEL_SENDto either BUS or MAIN remains supported. Never address native EdgeId via JS Number, track label or WebView ordinal.Measurable delta
Finish gate
Fast UI/native/release exact head + one full Chromium compiled native /preview/ gate, then reconcile current main and required gate before merge. Windows physical hardware/acoustic tests and installer NOT RUN for GUI-only work.