Skip to content

refactor(mvvm): extract exact native WIRE/EdgeId readback ViewModel (GUI-3) - #775

Merged
masarray merged 9 commits into
mainfrom
refactor/mvvm-native-wire-readback-gui3-20261118
Nov 18, 2026
Merged

masarray merged 9 commits into
mainfrom
refactor/mvvm-native-wire-readback-gui3-20261118

Conversation

@masarray

Copy link
Copy Markdown
Owner

GUI-3: WIRE/EdgeId readback ViewModel — source implementation

HASIL: Extracted the authoritative-native presentation decisions, not the native graph or DSP, from the /preview/ WebView2 web/approved-native-bridge.js into pure web/approved-wire-view-model.js:

  • edgePresentation: PRIMARY OUT, PARALLEL SEND, legacy SPLIT, native PRE_FADER tap, unity MAIN/BUS OUT, exact independent sends (including SEND to MAIN), dB, SEND enable; explicit native primaryOutput is authoritative, legacy fallback used only when flag absent.
  • acceptedParallelEdge + parallelEdge: canonical decimal-string ChannelId+EdgeId policy, rejects stale/duplicate/wrong-source/PRIMARY edge and any unavailable native operation.
  • gainReadback: installed parallel SEND gain and pending view values, no unbound fabricated view edge.
  • canEditTap, gestureTap, sofAvailable: logical-offline vs physically admitted PRE/POST/SOF eligibility without JS audio authority.
  • Bridge now delegates these decisions and keeps the original native controller/ACK, pending queues, UI ordinal maps, DOM, renderer, SOF gesture dispatcher. No second state store, dispatcher, mixer graph or plugin lease.

Visual and safety: No CSS/HTML/PNG, public Pages, C++, native PCM/DSP, ASIO, FX plugin/editor, .smix or automatic output arm changes. Native-only assembled /preview/ stages VM ahead of existing bridge. Existing regression harnesses receive VM; new negative/fail-closed selector tests include 64-bit EdgeIds, same-destination PRIMARY vs SEND, source mismatch, duplicate, stale/retained and missing capabilities, and no optimistic audio.

STATUS: KODE DIBUAT, DRAFT PR / UNMERGED until exact-head CI. Base 87a1abe439fd3d5cc205338e2758cba1d9c0cff7. Fast contracts and one full native-assembled Chromium qualification are required; do not merge on green fast CI alone. C++/MSVC/physical FAT NOT RUN (presentation-only refactor).

AMAN DIPAKAI? Not a new installer or hardware-qualified build. Existing accepted main remains unchanged until PR merged.

TINDAKAN ANDA: TIDAK PERLU MELAKUKAN APA-APA.

LANGKAH BERIKUTNYA: Resolve real fast contract failures, run Full Chromium on exact milestone head, reconcile main and required merge gate, then squash merge if all pass. Continue MV-3 canonical native read-model only as later standalone verified scope.

Copy link
Copy Markdown
Owner Author

GUI-3 parallel reconciliation (nonblocking): PR #774 independently implements the same native web/approved-wire-view-model.js + bridge + exact bundled /preview/ at 10e4d659777ddbde37ccca66ecc681c313742899 (fast UI/native/release PASS; exact-head full Chromium run #44230005903 in progress). Do not merge both. #775 is more extensive in edge presentation/SOF/readback but fast UI/native currently FAIL on a stale source-location regex in tests/approved_native_m2_contract.test.cjs (const tap=["PRE_FADER","POST_FADER"].includes(edge.tapStage) moved to pure VM). Review/change contract to assert behavior in VM, not move the old expression back into bridge. Unique #774 functions not obviously present in #775 are pure gainDraft (-60dB→0) and flushDecision (stale identity/retarget/unchanged no-op), keeping the original accepted controller and no native graph change. Please converge on ONE verified canonical PR; do not overwrite either independent branch. Source must be compared at exact HEAD before merge.

@cloudflare-workers-and-pages

cloudflare-workers-and-pages Bot commented Nov 18, 2026 •

Copy link
Copy Markdown

Deploying arsonmix with  Cloudflare Pages  Cloudflare Pages

Latest commit: 05539e3
Status: ✅  Deploy successful!
Preview URL: https://1fd05821.arsonmix.pages.dev
Branch Preview URL: https://refactor-mvvm-native-wire-re.arsonmix.pages.dev

View logs

Copy link
Copy Markdown
Owner Author

/arsonmix-ci ui 05539e3

@masarray
masarray marked this pull request as ready for review November 18, 2026 03:38
@chatgpt-codex-connector

chatgpt-codex-connector Bot commented Nov 18, 2026 •

Copy link
Copy Markdown
Codex Review Summary: ✅ Completed

This comment shows the latest Codex review activity on this pull request.

Review Status Commit Review trigger
📝 Code Review ✅ Completed 2026-11-18T03:40:19.331094Z 05539e3 Draft marked ready
ℹ️ About Codex in GitHub

Your team has set up Codex to review pull requests in this repo. Reviews are triggered when you

  • Open a pull request for review
  • Mark a draft as ready
  • Comment "@codex review" or "@codex security review".

Codex reacts with 👀 while any review is running, comments if it has suggestions, and reacts with 👍 once all reviews finish with no findings.

@masarray
masarray merged commit 4b75377 into main Nov 18, 2026
43 checks passed

Copy link
Copy Markdown
Owner Author

OWNER DELIVERY — GUI-3: WIRE/EdgeId Modular MVVM • 18 November 2026

HASIL: native /preview/ WIRE now uses one pure 88-line web/approved-wire-view-model.js for exact ChannelId+EdgeId admission, PRIMARY OUT vs parallel SEND projection (including SEND to MAIN), real native PRE_FADER vs legacy SPLIT tap, SEND scalar gain/enable readback, MIDI-safe 64-bit-as-string identities, rejected wrong/stale/duplicate edges and SOF/PRE-POST eligibility. The existing web/approved-native-bridge.js deletes the corresponding mixed presentation logic (~4,133 → 4,109 lines) and keeps the same DOM and existing native controller/request/ACK/readback and one graph. Native-assembled only; public /preview/ byte parity remains.

STATUS: MERGED MAIN: PR #775, verified squash commit 4b753772923ecf1afcc9d9eb341608d3e22559a9 and exact feature HEAD 05539e3e26b8c35e01bfee1f2a23b93ae9a319a9. No other thread PR branch merged/rewritten.

AMAN DIPAKAI? YA as a source-only presentation refactor that passed deterministic/Chromium tests and retains the accepted GUI. BELUM as a newly built/installed/hardware-tested Windows release; no audio-engine behavior claims.

TINDAKAN ANDA: TIDAK PERLU MELAKUKAN APA-APA.

BUKTI (exact HEAD 05539e3e26b8c35e01bfee1f2a23b93ae9a319a9): Fast UI 44230668147 PASS; Fast Native 44230668142 PASS; Full assembled Chromium 44230819958 PASS (109/109 completed workflow steps); Ready-state Fast UI 44231845602 PASS, Fast Native 44231845725 PASS; Required Merge Gate 44231845936 SUCCESS, final GitHub commit status SUCCESS. Initial obsolete source-location regex test failed on old PR HEAD; updated to assert the moved real policy; all tests retained, two new negative selector tests. No Windows MSVC/CTest or physical ASIO FAT required/run: C++/PCM untouched. No installer produced; postmerge push CI in progress at merge.

LANGKAH BERIKUTNYA: Next small, tested MV-3 native read-model consolidation or remaining WIRE transaction presentation, with exactly one native ChannelId/EdgeId graph/readback authority. Keep primary ASIO fastpath, .smix, FX leases and accepted /preview/ unchanged. Independent IO-1 PR #771 not touched.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant