Skip to content

refactor(gui): complete native FX Rack M4 roster and bypass ACK/readback ViewModel - #776

Merged
masarray merged 4 commits into
mainfrom
refactor/gui2-fx-readback-settlement-20261118
Nov 18, 2026
Merged

masarray merged 4 commits into
mainfrom
refactor/gui2-fx-readback-settlement-20261118

Conversation

@masarray

Copy link
Copy Markdown
Owner

GUI-2 follow-up — reuse the already merged FX Rack VM

Canonical GUI-2 source is merged PR #773, not competing PR #772 (closed without merge). This PR only forward-ports previously unmerged unique presentation responsibilities after review, without creating another FX Rack ViewModel or native dispatcher. Open PR #775 independently owns WIRE GUI-3 and #731 owns the native Win32 plugin editor lifecycle; neither is altered here.

Meaningful extraction

  • Extend existing web/approved-fx-rack-view-model.js with pure m4Presentation, nativePowerSettlement, m4RackSettlement. The M4 selector maps only verified installed instanceId, catalogId, per-slot bypass and channel-rack bypass; missing/fake instance IDs fail closed.
  • Remove old M4 catalogue slot selection, M4 ACK/readback settlement and native ChannelId FX bypass settlement conditionals from web/approved-native-bridge.js. It now consumes the canonical ViewModel for these decisions.
  • Native ChannelId pending requests carry captured device epoch. The same plugin ID or bypass state after a device change cannot falsely complete a stale request. ACK alone still never establishes bypass success.
  • Three pure Node regression tests: exact 64-bit instance identity and catalogue changes, ACK + later matching installed readback, different device epoch/changed plugin token and M4 route revision/authority invalidation.

Scope / measurement

  • 3 JS/test source files only, no C++/ASIO/DSP/FX editor/window, no new schema, dispatcher, GUI HTML/CSS/PNG, or bundled module. Existing production /preview/ FX ViewModel is the one shipped and loaded before bridge.
  • Bridge 4133 -> 4125 lines; FX ViewModel 69 -> 115 lines. Reduction isn't success alone: the old conditions are removed and replaced by 3 pure independently testable projection functions.
  • Required: exact HEAD fast UI+native, native-assembled Chromium and merge-gate before merge. Do not claim physical audio, Windows installer or user speaker listening from browser CI.

@cloudflare-workers-and-pages

cloudflare-workers-and-pages Bot commented Nov 18, 2026 •

Copy link
Copy Markdown

Deploying arsonmix with  Cloudflare Pages  Cloudflare Pages

Latest commit: d80598a
Status:🚫  Build failed.

View logs

@masarray
masarray marked this pull request as ready for review November 18, 2026 03:45

Copy link
Copy Markdown
Owner Author

GUI-2 FX Rack exact-head qualification checkpoint

Reconciled against merged GUI-3 WIRE main 4b753772923ecf1afcc9d9eb341608d3e22559a9 without force; current PR head d80598af602ed9e823b2b040ec90497483ea0c88 and behind=0. Only FX ViewModel/approved bridge/existing Node contracts changed; no WIRE ViewModel, native C++/ASIO/DSP, plugin editor HWND or approved visual assets modified. The single native FX and mixer authority remains intact.

Fast UI PASS 44232481249; fast native Node/Python/PCM contracts PASS 44232481178. Three new pure regression tests cover M4 exact FX instance/metadata, ACK+installed-state bypass settlement and epoch/revision/instance mismatch. Full native-assembled Chromium follows as one exact SHA ui dispatch; physical Windows hardware listening and installer NOT RUN.

Copy link
Copy Markdown
Owner Author

/arsonmix-ci ui d80598a

@chatgpt-codex-connector

chatgpt-codex-connector Bot commented Nov 18, 2026 •

Copy link
Copy Markdown
Codex Review Summary: ✅ Completed

This comment shows the latest Codex review activity on this pull request.

Review Status Commit Review trigger
📝 Code Review ✅ Completed 2026-11-18T03:47:10.244845Z d80598a Draft marked ready
ℹ️ About Codex in GitHub

Your team has set up Codex to review pull requests in this repo. Reviews are triggered when you

  • Open a pull request for review
  • Mark a draft as ready
  • Comment "@codex review" or "@codex security review".

Codex reacts with 👀 while any review is running, comments if it has suggestions, and reacts with 👍 once all reviews finish with no findings.

@masarray
masarray merged commit f920c5d into main Nov 18, 2026
43 of 44 checks passed

Copy link
Copy Markdown
Owner Author

FINAL GUI-2 FX Rack follow-up — MERGED MAIN (18 November 2026)

HASIL: Extended the ONE canonical FX Rack ViewModel shipped by #773 with M4 FX catalog/instance presentation, ChannelId bypass ACK+installed readback correlation and M4 rack revision settlement. Old inline decisions were removed from approved-native-bridge.js. Native FX requests capture device epoch; ACK alone, replaced plugin token, changed device epoch and M4 stale route revision cannot falsely confirm a bypass. FX HWND editor ownership remains native, separate #731.

RECONCILIATION: Overlapping alternative #772 remains CLOSED UNMERGED; ported unique reviewed functions into canonical model only. Concurrent GUI-3 #775 was merged and preserved by a non-force, two-parent merge in this PR. No second WIRE/FX ViewModel, native dispatcher or PCM graph.

STATUS: SUDAH MERGED KE MAIN. PR #776 exact tested HEAD d80598a, final squash/main SHA f920c5d.

MEASURABLE: FX Rack VM 69→115 lines, three pure independent selectors, native bridge 4109→4101 lines (-8) relative to merged GUI-3 baseline, three deterministic Node tests and exactly three JS/test source files. Initial CI red was malformed new-test regex syntax, fixed before qualification; latest UI/native/full Chromium all PASS. ZERO C++, ASIO, DSP, VST3 owner, HTML/CSS/PNG or session schema changes.

BUKTI: Fast UI PASS https://github.com/masarray/arsonmix/actions/runs/44232655113 ; fast native PASS https://github.com/masarray/arsonmix/actions/runs/44232655452 ; full exact-head native assembled Chromium GUI PASS https://github.com/masarray/arsonmix/actions/runs/44232706024 ; protected merge gate PASS https://github.com/masarray/arsonmix/actions/runs/44232655695 . Physical vendor ASIO/Windows installer and audio listening NOT RUN.

AMAN DIPAKAI? YA for source tests and merged GUI code; BELUM verified as a new installed Windows binary or physical audio FAT. TINDAKAN ANDA: TIDAK PERLU MELAKUKAN APA-APA.

BERIKUTNYA: GUI maintainability verification and one fresh feature-extension scenario against latest main, after auditing active branches. Do not repeat merged MV-2/GUI-1/GUI-2/GUI-3 or alter #731 native editor lifecycle.

masarray added a commit that referenced this pull request Nov 18, 2026
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant