Repository navigation
refactor(gui): complete native FX Rack M4 roster and bypass ACK/readback ViewModel - #776
Conversation
GUI-2 FX Rack exact-head qualification checkpointReconciled against merged GUI-3 WIRE main Fast UI PASS 44232481249; fast native Node/Python/PCM contracts PASS 44232481178. Three new pure regression tests cover M4 exact FX instance/metadata, ACK+installed-state bypass settlement and epoch/revision/instance mismatch. Full native-assembled Chromium follows as one exact SHA |
|
/arsonmix-ci ui d80598a |
Codex Review Summary: ✅ CompletedThis comment shows the latest Codex review activity on this pull request.
ℹ️ About Codex in GitHubYour team has set up Codex to review pull requests in this repo. Reviews are triggered when you
Codex reacts with 👀 while any review is running, comments if it has suggestions, and reacts with 👍 once all reviews finish with no findings. |
FINAL GUI-2 FX Rack follow-up — MERGED MAIN (18 November 2026)HASIL: Extended the ONE canonical FX Rack ViewModel shipped by #773 with M4 FX catalog/instance presentation, ChannelId bypass ACK+installed readback correlation and M4 rack revision settlement. Old inline decisions were removed from approved-native-bridge.js. Native FX requests capture device epoch; ACK alone, replaced plugin token, changed device epoch and M4 stale route revision cannot falsely confirm a bypass. FX HWND editor ownership remains native, separate #731. RECONCILIATION: Overlapping alternative #772 remains CLOSED UNMERGED; ported unique reviewed functions into canonical model only. Concurrent GUI-3 #775 was merged and preserved by a non-force, two-parent merge in this PR. No second WIRE/FX ViewModel, native dispatcher or PCM graph. STATUS: SUDAH MERGED KE MAIN. PR #776 exact tested HEAD d80598a, final squash/main SHA f920c5d. MEASURABLE: FX Rack VM 69→115 lines, three pure independent selectors, native bridge 4109→4101 lines (-8) relative to merged GUI-3 baseline, three deterministic Node tests and exactly three JS/test source files. Initial CI red was malformed new-test regex syntax, fixed before qualification; latest UI/native/full Chromium all PASS. ZERO C++, ASIO, DSP, VST3 owner, HTML/CSS/PNG or session schema changes. BUKTI: Fast UI PASS https://github.com/masarray/arsonmix/actions/runs/44232655113 ; fast native PASS https://github.com/masarray/arsonmix/actions/runs/44232655452 ; full exact-head native assembled Chromium GUI PASS https://github.com/masarray/arsonmix/actions/runs/44232706024 ; protected merge gate PASS https://github.com/masarray/arsonmix/actions/runs/44232655695 . Physical vendor ASIO/Windows installer and audio listening NOT RUN. AMAN DIPAKAI? YA for source tests and merged GUI code; BELUM verified as a new installed Windows binary or physical audio FAT. TINDAKAN ANDA: TIDAK PERLU MELAKUKAN APA-APA. BERIKUTNYA: GUI maintainability verification and one fresh feature-extension scenario against latest main, after auditing active branches. Do not repeat merged MV-2/GUI-1/GUI-2/GUI-3 or alter #731 native editor lifecycle. |
GUI-2 follow-up — reuse the already merged FX Rack VM
Canonical GUI-2 source is merged PR #773, not competing PR #772 (closed without merge). This PR only forward-ports previously unmerged unique presentation responsibilities after review, without creating another FX Rack ViewModel or native dispatcher. Open PR #775 independently owns WIRE GUI-3 and #731 owns the native Win32 plugin editor lifecycle; neither is altered here.
Meaningful extraction
web/approved-fx-rack-view-model.jswith purem4Presentation,nativePowerSettlement,m4RackSettlement. The M4 selector maps only verified installed instanceId, catalogId, per-slot bypass and channel-rack bypass; missing/fake instance IDs fail closed.web/approved-native-bridge.js. It now consumes the canonical ViewModel for these decisions.Scope / measurement
/preview/FX ViewModel is the one shipped and loaded before bridge.4133 -> 4125lines; FX ViewModel69 -> 115lines. Reduction isn't success alone: the old conditions are removed and replaced by 3 pure independently testable projection functions.