Repository navigation
refactor(mv3): one canonical native PCM/M4/offline read-model selector - #777
Conversation
…read-model selector
… and negative readbacks
Deploying arsonmix with
|
| Latest commit: |
1e1162c
|
| Status: | ✅ Deploy successful! |
| Preview URL: | https://5d406df9.arsonmix.pages.dev |
| Branch Preview URL: | https://refactor-mv3-authoritative-n.arsonmix.pages.dev |
…nstead of removed bridge branches
|
/arsonmix-ci ui aca543c |
|
/arsonmix-ci ui 1e1162c |
Owner checkpoint — MV-3 canonical native read-model (2026-11-18)HASIL: Merged the independent FX Rack PR #776 from The actual feature is one pure schema-v6 readback authority selector, no UI state store: STATUS: KODE DIBUAT + KODE DIUJI FAST, OPEN DRAFT / NOT MERGED. Exact reconciled PR HEAD AMAN DIPAKAI? Existing merged main stays unchanged. This branch is BELUM a newly installed Windows release, physical multi-vendor ASIO or hardware FAT. No GUI visual, .smix format, DSP/VST3, audio driver, native C++ or output rearm changes. TINDAKAN ANDA: TIDAK PERLU MELAKUKAN APA-APA. LANGKAH BERIKUTNYA: only mark Ready and merge after exact-SHA full Chromium PASS, required gate SUCCESS and fresh main/PR reconciliation. Keep independent native IO-1 PR #771 untouched. |
Codex Review Summary: ✅ CompletedThis comment shows the latest Codex review activity on this pull request.
ℹ️ About Codex in GitHubYour team has set up Codex to review pull requests in this repo. Reviews are triggered when you
Codex reacts with 👀 while any review is running, comments if it has suggestions, and reacts with 👍 once all reviews finish with no findings. |
OWNER DELIVERY — MV-3 Modular MVVM: satu native read-model authority • 18 Nov 2026HASIL: Existing single STATUS: MERGED MAIN. PR #777 squash commit AMAN DIPAKAI? YA for the merged, fully-tested source-level GUI/readback refactor. BELUM an installed/released Windows binary or tested physical 2-vendor ASIO setup; no new installer, Windows MSVC/CTest, or hardware FAT performed, because there were no C++/PCM changes. TINDAKAN ANDA: TIDAK PERLU MELAKUKAN APA-APA. BUKTI: Final combined exact-head Fast UI #44234572716 PASS (247 relevant UI Node contract tests, 0 failed), Fast Native #44234572689 PASS, Full Chromium #44235017840 PASS 109/109 workflow steps, Ready-state Fast UI #44235896543 PASS, Fast Native #44235896545 PASS, Required Merge Gate #44235897687 SUCCESS. Initial outdated path-match contract on old head failed but was repaired to assert exactly the same real policy in moved file; test coverage was NOT removed. New tests cover wrong epoch, unadmitted LIVE, retained quiet device, offline revision/permission mismatch, M4 priority and canonical ChannelId/EdgeId. Postmerge CI on main separately running, do not claim postmerge PASS until verified. LANGKAH BERIKUTNYA: Continue one new meaningful modularization slice (native logical/session use-case separation only where real duplicate policy remains), preserving one accepted PCM/VST3 graph and /preview/; independent multi-device IO-1 #771 and FX editor #731 remain separate and require their own evidence. |
Post-merge verification follow-up — main
|
Post-merge quality verification (same exact commit, 2026-11-18)Main SHA POSTMERGE UI RUN 44236089782: attempt 1 FAIL at Stage C compiled CSS vs source screenshot pixel parity, default 1366×768; computed style comparison succeeded, PNG hashes did not match. One targeted retry of only the failed Full Chromium job on same exact main SHA (no code, CSS, baseline, YAML or threshold changes) then completed SUCCESS 109/109 steps, including Stage C. This indicates a nondeterministic comparison, not a merge-time source delta; exact cause remains unproven. Permanent follow-up Issue #778 tracks root cause, failed-image diff capture and deterministic visual settle, with strict negative CSS mismatch failure preserved. The initial failure is retained in Actions history; it was not suppressed or converted to success. Fast UI and Fast Native postmerge: PASS. Required Merge Gate postmerge: SUCCESS 44237415383. Windows MSVC/CTest 44236089857 IN PROGRESS as of last check, automatically run; C++ unchanged; do not count it as passed yet. No installer or physical ASIO FAT was delivered. HASIL/STATUS: MV-3 remains MERGED MAIN; canonical schema-v6 read-model and merged FX Rack #776 preserved. AMAN DIPAKAI: source refactor tested; physical installation/new release not qualified. TINDAKAN ANDA: TIDAK PERLU MELAKUKAN APA-APA. Next: keep Issue #778 separate from MVVM; continue one native application/service boundary slice once the next main and concurrent work have been audited. |
MV-3: canonical schema-v6 native read-model selection (implementation)
Outcome / HASIL: There is now one pure
selectNativeReadModel(next,verifiedM4)selector in the existingweb/approved-native-contract.js, consuming the already normalizedarMixConsoleSnapshot(schema v6). It selects exactly one ofCHANNEL_ID,M4,LOGICAL_ONLY,NEEDS_REMAP,STALE,UNADMITTEDorINVALID; preserves canonical uint64-string ChannelId/EdgeId identity, physical output authority and native session epoch. An offline.smixmay be displayed only when PCM, M4, physical output and stale revisions cannot overrule it. Offline view explicitly hasadmitted:false,productLive:falseand no telemetry. An installedCHANNEL_IDview is EXACTLY the reconciled native snapshot, not a clone or JS-owned session. A retained graph wins over stale offline metadata but never rearms hardware.Old responsibility removed:
web/approved-native-bridge.jsno longer duplicates the 20+ predicates for logical availability, virtual snapshot construction, stale session selection, M4/native authority, or ChannelId admission. It consumes the single selector; existing control dispatch, ACK/readback, pending rollbacks, DOM/layout, UI gesture and one PCM renderer are unchanged. No new transport, store, event bus, status cache, native manager, DSP/FX logic or parallel render authority.Deterministic tests:
tests/milestone_a_single_authority.test.cjsnow checks the moved real authority boundary plus independent regression scenarios using the actual schema-v6 normalizer: installed/live and exact uint64 IDs, unadmitted fake CHANNEL_ID, epoch mismatch, invalid snapshot reference, correctly sandboxed editable/read-only offline .smix, revision and physical output rejection, M4 precedence, retained device-loss replay safety and explicit source-path removal. Existing ACK/readback, WIRE/SOF/FX/Gain, negative stale request and native assembled Chromium tests are retained.Conflicts: PR #776 independently owns FX Rack M4 roster/bypass and touches different regions of bridge/test. This PR does not copy or merge #776. Native IO-1 PR #771 untouched.
STATUS: KODE DIBUAT, DRAFT — NOT MERGED; complete fast native/UI and required gate on exact HEAD, then one Full Chromium native-assembled GUI on final SHA; verify main reconciliation. No C++/graph changes, so no required Windows MSVC/CTest and no hardware FAT. Do not invent physical audio claims.
AMAN DIPAKAI? Existing merged main remains untouched until green CI and merge; no new Windows installer has been built. TINDAKAN ANDA: TIDAK PERLU MELAKUKAN APA-APA.
LANGKAH BERIKUTNYA: solve exact CI failures without weakening tests; reconcile #776 if it merges before this PR, and deliver one merged slice after exact-SHA GUI proof.