Repository navigation
fix(sof): WIRE inspector PRIMARY OUT unity vs parallel SEND to MAIN + accepted readback - #630
Merged
masarray merged 8 commits intoNov 13, 2026
Conversation
…nds incl MAIN; native edits await PCM readback
…r readback without DOM rebuild
…AIN, pending slider and tap rollback
…ove native inspector adaptations into assembler
…sible native-only assembler hooks
…sert public Pages untouched
…IRE inspector hook
masarray
marked this pull request as ready for review
November 13, 2026 03:35
masarray
merged commit Nov 13, 2026
5b806c7
into
feat/8d-sonku-p0-editor-recovery-20261113
12 checks passed
Codex Review Summary: ❌ FailedThis comment shows the latest Codex review activity on this pull request.
ℹ️ About Codex in GitHubYour team has set up Codex to review pull requests in this repo. Reviews are triggered when you
Codex reacts with 👀 while any review is running, comments if it has suggestions, and reacts with 👍 once all reviews finish with no findings. |
|
You have reached your Codex usage limits for code reviews. You can see your limits in the Codex usage dashboard. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Why
A native WIRE inspector still disabled SEND LEVEL whenever destination was MAIN, even for a real parallel SEND, while exposing a fake editable level for an exclusive PRIMARY OUT to BUS. The event handler also ran demo-acceptance/rebuild after native input/change.
What changed
canWireGain,canWireTap) and reuses the SAME authoritatively accepted edge guard for incoming send scalar gain. A send to MAIN remains valid; PRIMARY BUS is fixed unity.wireGraphCommit, browser undo history, full DOM repaint or premature success toast on native input/change.Base is PR #606 (already includes #623/#626), not
main; duplicate #604/#614 not blindly merged. One existing JUCE callback unchanged. Windows exact-SHA #606 started before these changes and must not be mislabeled as qualification of this new SHA. Real ASIO FAT still separate.