Skip to content

fix(sof): WIRE inspector PRIMARY OUT unity vs parallel SEND to MAIN + accepted readback - #630

Merged
masarray merged 8 commits into
feat/8d-sonku-p0-editor-recovery-20261113from
fix/sof-wire-inspector-primary-send-20261113
Nov 13, 2026
Merged

masarray merged 8 commits into
feat/8d-sonku-p0-editor-recovery-20261113from
fix/sof-wire-inspector-primary-send-20261113

Conversation

@masarray

Copy link
Copy Markdown
Owner

Why

A native WIRE inspector still disabled SEND LEVEL whenever destination was MAIN, even for a real parallel SEND, while exposing a fake editable level for an exclusive PRIMARY OUT to BUS. The event handler also ran demo-acceptance/rebuild after native input/change.

What changed

  • Native bridge exposes exact accepted ChannelId+EdgeId / capability inspection (canWireGain, canWireTap) and reuses the SAME authoritatively accepted edge guard for incoming send scalar gain. A send to MAIN remains valid; PRIMARY BUS is fixed unity.
  • Original approved WIRE inspector renders one scalar gain and PRE/POST control with correct native capability. No new control card, no artwork/layout changes.
  • Native gain gestures coalesce via the already-installed 32ms queue; numeric readout shows PENDING until independent native readback. No optimistic wireGraphCommit, browser undo history, full DOM repaint or premature success toast on native input/change.
  • Native-only bundle syncs the inspector accepted gain without a strip repaint. PRE/POST select springs back to last accepted position until actual structural readback.
  • Fast node test executes the actual inspector renderer/event handlers under a native bridge fixture: PRIMARY BUS blocked, PARALLEL MAIN accepted, pending slider, tap accepted rollback, no demo graph authority.

Base is PR #606 (already includes #623/#626), not main; duplicate #604/#614 not blindly merged. One existing JUCE callback unchanged. Windows exact-SHA #606 started before these changes and must not be mislabeled as qualification of this new SHA. Real ASIO FAT still separate.

@cloudflare-workers-and-pages

cloudflare-workers-and-pages Bot commented Nov 13, 2026 •

Copy link
Copy Markdown

Deploying arsonmix with  Cloudflare Pages  Cloudflare Pages

Latest commit: ba7c712
Status:⚡️  Build in progress...

View logs

@masarray
masarray marked this pull request as ready for review November 13, 2026 03:35
@masarray
masarray merged commit 5b806c7 into feat/8d-sonku-p0-editor-recovery-20261113 Nov 13, 2026
12 checks passed
@chatgpt-codex-connector

Copy link
Copy Markdown
Codex Review Summary: ❌ Failed

This comment shows the latest Codex review activity on this pull request.

Review Status Commit Review trigger
📝 Code Review ❌ Failed 2026-11-13T03:35:44.296062Z
We couldn’t complete this review. Comment @codex review to try again.
5e86f45 Draft marked ready
ℹ️ About Codex in GitHub

Your team has set up Codex to review pull requests in this repo. Reviews are triggered when you

  • Open a pull request for review
  • Mark a draft as ready
  • Comment "@codex review" or "@codex security review".

Codex reacts with 👀 while any review is running, comments if it has suggestions, and reacts with 👍 once all reviews finish with no findings.

@chatgpt-codex-connector

Copy link
Copy Markdown

You have reached your Codex usage limits for code reviews. You can see your limits in the Codex usage dashboard.
To continue using code reviews, you can upgrade your account or add credits to your account and enable them for code reviews in your settings.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant