Repository navigation
V64 WIRE: reverse the unplug whip from OUT while cable reels in - #637
Merged
Merged
Conversation
…ence of falling/hanging phases
Codex Review Summary: ❌ FailedThis comment shows the latest Codex review activity on this pull request.
ℹ️ About Codex in GitHubYour team has set up Codex to review pull requests in this repo. Reviews are triggered when you
Codex reacts with 👀 while any review is running, comments if it has suggestions, and reacts with 👍 once all reviews finish with no findings. |
|
You have reached your Codex usage limits for code reviews. You can see your limits in the Codex usage dashboard. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Owner visual correction (13 November 2026)
V63's FALL → HANG → REEL animation is explicitly rejected: it looks artificial. The desired motion is one continuously flexible cable: after a valid IN unplug, the free cable is immediately pulled back into its actual OUT socket while a travelling, damped sinusoidal whip starts at OUT and runs toward the moving loose end. This is the reverse of approved plug-in (IN → OUT).
Implementation
wireRetractPoseandwireRetractPathData: wave front moves from OUT parameter t=0 toward free end t=1; physical OUT and free endpoints are pinned, sag shrinks with remaining length, 1–2 softly damped lobes taper along the cable and decay to zero as it retracts.Tests
Update existing scoped real Chromium V60/V63 smoke to check actual physical drag/unplug graph removal, immediate free-end motion toward OUT, fixed endpoints, OUT-first wave before free-end movement, later arrival, complete retraction, zero residual ghost hitbox; remove the invalid fall/hang expectations.
Use fast PR contracts, then one full Chromium qualification on main before Pages publication.
Coordination
No changes to concurrent SOF #604/#630, native sends #614, FX, faders or existing approved PFL art.