Repository navigation
V63 WIRE: length-adaptive short cable whip and physically hanging unplug/reel - #631
Merged
Merged
Conversation
…eling cable with trailing ripple
… timing with trailing flutter
Codex Review Summary: ❌ FailedThis comment shows the latest Codex review activity on this pull request.
ℹ️ About Codex in GitHubYour team has set up Codex to review pull requests in this repo. Reviews are triggered when you
Codex reacts with 👀 while any review is running, comments if it has suggestions, and reacts with 👍 once all reviews finish with no findings. |
|
You have reached your Codex usage limits for code reviews. You can see your limits in the Codex usage dashboard. |
Deploying arsonmix with
|
| Latest commit: |
3d2751b
|
| Status: | ✅ Deploy successful! |
| Preview URL: | https://6a789c78.arsonmix.pages.dev |
| Branch Preview URL: | https://fix-v63-adaptive-wire-whip-h.arsonmix.pages.dev |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
User feedback on V62 (13 Nov 2026)
Keep the approved long-cable look (>2 channels). At short distances, a 14+px multi-lobe sine makes the cable look stiff/jagged. Scale impulse amplitude, wavelength (broader/simpler single curl), and wavefront travel smoothly from 1-channel distances up to 3+ channels. Damped IN→OUT launch and welded sockets remain.
Plug-out should visibly FALL, HANG, then be PULLED. V62 began reeling after 200ms and limited cable to SEND clip+48px. V63 introduces deterministic
fall 320ms → slack hang 150ms → reel 660ms. Free plug X remains still while falling and hanging. Soft line sag increases to create a visible hanging belly below the bay (overlay clipped only to viewport), then reel draws plug back to OUT with a small bounded travelling flex. Overlay remains noninteractive, self-cleans, respects reduced-motion and is cancelled if the same source accepts a new connection. Routing REMOVE happens immediately; this never simulates audio or creates a graph edge.Engineering and qualification
site/preview-v2/index.htmlUI renderer and its existing Playwright test changed; no CSS layering, PNG, DSP, native PCM or audio callback edits.Coordination
Keep parallel #630 SOF/WIRE inspector and #614 native gain/sends authority intact. This is a browser-only visual motion refinement and cannot override per-EdgeId or native ACK semantics.