Skip to content

fix(gui): stable SOF target ID and unambiguous PRE/POST per send - #620

Merged
masarray merged 12 commits into
feat/8d-sonku-p0-editor-recovery-20261113from
feat/sof-stable-target-ux-20261113
Nov 13, 2026
Merged

masarray merged 12 commits into
feat/8d-sonku-p0-editor-recovery-20261113from
feat/sof-stable-target-ux-20261113

Conversation

@masarray

@masarray masarray commented Nov 13, 2026 •

Copy link
Copy Markdown
Owner

Contextual-console GAIN / PRE-POST / SEND UX — stacked safely on SonKu #606

Scope: one approved /preview/ mixer. Only four UI/bridge/test files. This is a stacked PR targeting feat/8d-sonku-p0-editor-recovery-20261113 (#606), not a competing GUI or a rewrite of the native engine (#614). Integrate after the base PR is stable.

Code changes

  • SOF target uses stable local strip ID, mapped by the existing native bridge to exact decimal-string ChannelId, not mutable BUS/FX name. Target survives rename and layer/bank switching without sending controls to the wrong bus. sofTarget stays a presentation label only.
  • Native selectedNativeSofEdge() and partial readback now match sofTargetId; native scope exports only a read-only ID getter, no second renderer, no new DSP.
  • One contextual PRE/POST key can change one explicitly selected EdgeId; the channel-wide hardware key is disabled when multiple outgoing sends are ambiguous or when there are no sends. No accidental bulk tap edits and no hidden modification of the future WIRE default.
  • SOF displays honest NO SEND, PRIMARY ROUTE, OFF · saved level, and PRE-FX/PRE-FADER/POST-FADER context. An absent SEND no longer paints as pressed ON. Real SEND ON can still restore the stored gain.
  • Render order fixed: choose SOF destination before painting the current bank. Avoid stale strip contents after deleting/renaming a BUS.
  • Preserve existing approved v9 hardware PNG, fader artwork and travel, SonKu editor, mute/solo/PFL, FX chain and geometry. No global CSS/fader owner edits.
  • Strengthen browser Playwright smoke at 1366×768, 1680×900, 1920×1080: selected BUS option uses ID; rename retains target; SOF only changes the matched send; Gain/FX view restores; no phantom send and verified approved sprite.
  • Reconciled latest 8D-SonKu: native binaural DSP, studio orbit GUI, smooth motion and headphone FAT #606 advancement through merge commit fd7496f84a78bad65a897748675cd1ee57d9d362, with no file overlap with its latest SonKu editor changes. Four changed paths only.

UX reference

Yamaha DM7 StageMix PRE/SEND ON in SOF + Waves eMotion LV1 Fader Flip selected AUX and distinct pre-processing / post-insert pre-fader / post-fader taps. Patterns only, no copied vendor art/code.

Important limitation and completion gate

Final focused improvements and evidence

  • Native GAIN view no longer unconditionally rejects every JUCE instance; now it admits view switching only after an audio channel advertises acknowledged nativeGainAvailable. No fake DSP gain, and return to FX RACK preserves all inserts.
  • Double-click gain dial requests 0 dB via existing native SET_INPUT_GAIN intent, not speculative t.trim; Pages resets through its normal input/change handler.
  • Double-click a fader during SOF resets the selected accepted EdgeId send through requestWireGain, never native M4/SET_FADER MAIN. MAIN mode still resets the actual fader to 0 dB. No SEND auto-create.
  • Added regression tests for native bridge delegation plus Pages GAIN unity, selected-BUS rename and per-view behavior. All branch source changes are renderer/bridge/build-assembler/tests only.
  • Exact head 25fa8c022f4efbf8ff123523286ba1a5fe52b9c6: fast UI contract PASS and fast native-source contract PASS. The UI smoke workflow's full Chromium jobs were skipped, so do not claim full viewport FAT, native JUCE build, physical ASIO or public release.
  • Safe to integrate to 8D-SonKu: native binaural DSP, studio orbit GUI, smooth motion and headphone FAT #606 development branch; still needs upstream/main reconciliation and one deliberate exact-SHA visual/native qualification with the actual final candidate.

@cloudflare-workers-and-pages

cloudflare-workers-and-pages Bot commented Nov 13, 2026 •

Copy link
Copy Markdown

Deploying arsonmix with  Cloudflare Pages  Cloudflare Pages

Latest commit: 25fa8c0
Status:⚡️  Build in progress...

View logs

@masarray
masarray marked this pull request as ready for review November 13, 2026 01:18
@chatgpt-codex-connector

Copy link
Copy Markdown
Codex Review Summary: ❌ Failed

This comment shows the latest Codex review activity on this pull request.

Review Status Commit Review trigger
📝 Code Review ❌ Failed 2026-11-13T01:18:43.223405Z
We couldn’t complete this review. Comment @codex review to try again.
25fa8c0 Draft marked ready
ℹ️ About Codex in GitHub

Your team has set up Codex to review pull requests in this repo. Reviews are triggered when you

  • Open a pull request for review
  • Mark a draft as ready
  • Comment "@codex review" or "@codex security review".

Codex reacts with 👀 while any review is running, comments if it has suggestions, and reacts with 👍 once all reviews finish with no findings.

@chatgpt-codex-connector

Copy link
Copy Markdown

You have reached your Codex usage limits for code reviews. You can see your limits in the Codex usage dashboard.
To continue using code reviews, you can upgrade your account or add credits to your account and enable them for code reviews in your settings.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant