Repository navigation
Conversation
…nest no-send state
…esets through native intent
…reset uses installed intent
masarray
marked this pull request as ready for review
November 13, 2026 01:18
Codex Review Summary: ❌ FailedThis comment shows the latest Codex review activity on this pull request.
ℹ️ About Codex in GitHubYour team has set up Codex to review pull requests in this repo. Reviews are triggered when you
Codex reacts with 👀 while any review is running, comments if it has suggestions, and reacts with 👍 once all reviews finish with no findings. |
|
You have reached your Codex usage limits for code reviews. You can see your limits in the Codex usage dashboard. |
masarray
merged commit Nov 13, 2026
fab6e6d
into
feat/8d-sonku-p0-editor-recovery-20261113
12 of 13 checks passed
This was referenced Nov 13, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Contextual-console GAIN / PRE-POST / SEND UX — stacked safely on SonKu #606
Scope: one approved
/preview/mixer. Only four UI/bridge/test files. This is a stacked PR targetingfeat/8d-sonku-p0-editor-recovery-20261113(#606), not a competing GUI or a rewrite of the native engine (#614). Integrate after the base PR is stable.Code changes
sofTargetstays a presentation label only.selectedNativeSofEdge()and partial readback now matchsofTargetId; native scope exports only a read-only ID getter, no second renderer, no new DSP.fd7496f84a78bad65a897748675cd1ee57d9d362, with no file overlap with its latest SonKu editor changes. Four changed paths only.UX reference
Yamaha DM7 StageMix PRE/SEND ON in SOF + Waves eMotion LV1 Fader Flip selected AUX and distinct pre-processing / post-insert pre-fader / post-fader taps. Patterns only, no copied vendor art/code.
Important limitation and completion gate
Final focused improvements and evidence
nativeGainAvailable. No fake DSP gain, and return to FX RACK preserves all inserts.t.trim; Pages resets through its normal input/change handler.requestWireGain, never native M4/SET_FADER MAIN. MAIN mode still resets the actual fader to 0 dB. No SEND auto-create.25fa8c022f4efbf8ff123523286ba1a5fe52b9c6: fast UI contract PASS and fast native-source contract PASS. The UI smoke workflow's full Chromium jobs were skipped, so do not claim full viewport FAT, native JUCE build, physical ASIO or public release.