Repository navigation
feat(sof): exact EdgeId logical SEND/tap + native PCM gain/send regression gate - #623
Merged
masarray merged 6 commits intoNov 13, 2026
Conversation
…ching primary OUT
…gical gain restore
…th accepted revisions
masarray
marked this pull request as ready for review
November 13, 2026 02:40
masarray
merged commit Nov 13, 2026
dc84e8d
into
feat/8d-sonku-p0-editor-recovery-20261113
4 of 5 checks passed
Codex Review Summary: ❌ FailedThis comment shows the latest Codex review activity on this pull request.
ℹ️ About Codex in GitHubYour team has set up Codex to review pull requests in this repo. Reviews are triggered when you
Codex reacts with 👀 while any review is running, comments if it has suggestions, and reacts with 👍 once all reviews finish with no findings. |
|
You have reached your Codex usage limits for code reviews. You can see your limits in the Codex usage dashboard. |
This was referenced Nov 13, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
GAIN / PRE-POST / SEND — integrated logical + native PCM proof on top of #606
Stacked on #606, which already includes GUI #620 and existing installed per-EdgeId SEND/Gain command path. Intentionally does not copy #614's overlapping PCM publisher/graph classes or touch approved /preview/ HTML/CSS/PNG/SVG.
Changes
DynamicChannelRosterwithsetSendEnabledandsetSendTapusing an exact existing parallel EdgeId. Reject unknown/primary edges; preserve wire topology, send gain and destination, and independent MAIN OUT.SET_SEND_ENABLEDandSET_SEND_TAPfor LOGICAL_ONLY session editing (not physical ASIO admission); add independentsendEnabledand exacttapStagereadback. WIREenabledremains true even when audio SEND OFF, preserving visibility.DynamicAcceptedSessionAPI parity for native pre-insert Input Gain and per-EdgeId SEND ON/OFF, using already-existing 8D-SonKu: native binaural DSP, studio orbit GUI, smooth motion and headphone FAT #606 publisher and PCM methods, not duplicate atomics.Integration constraints