Repository navigation
fix(sof): native WIRE inspector PRE/POST uses accepted EdgeId tap, not PRE-FX demo mode - #626
Merged
masarray merged 4 commits intoNov 13, 2026
Conversation
masarray
marked this pull request as ready for review
November 13, 2026 03:12
masarray
merged commit Nov 13, 2026
065cc64
into
feat/8d-sonku-p0-editor-recovery-20261113
12 of 13 checks passed
Codex Review Summary: ❌ FailedThis comment shows the latest Codex review activity on this pull request.
ℹ️ About Codex in GitHubYour team has set up Codex to review pull requests in this repo. Reviews are triggered when you
Codex reacts with 👀 while any review is running, comments if it has suggestions, and reacts with 👍 once all reviews finish with no findings. |
|
You have reached your Codex usage limits for code reviews. You can see your limits in the Codex usage dashboard. |
This was referenced Nov 13, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Focused integrated GAIN/PRE/POST/SEND GUI recovery
requestNativeTapowner shared by the SOF button and WIRE inspector. The approved native GUI's legacy MODE gesture now translates to one exactSET_TAPon accepted ChannelId+EdgeId through the existingAPPLY_WIRE_TRANSACTIONcontract. No optimistic graph/UI mutation, no startup replay of tap changes, no second PCM callback.tapStagefor offline/native projection while preserving legacy semantics where no modern tapStage exists. A PRE_FADER native send is no longer presented as a PRE FXsplitroute.SEND LEVELin native; disables tap when installed native PCM capability is absent. Public Pages reference retains its historical PRE FX / Follow Fader meanings and original controls.mainnot a target.Reference semantics: Yamaha DM7 bus-specific PRE and SEND ON, Waves LV1 PRE vs INP, Studio Pro post-insert PRE-FADER; these are behavior patterns, not copied assets.