Skip to content

fix(sof): native WIRE inspector PRE/POST uses accepted EdgeId tap, not PRE-FX demo mode - #626

Merged
masarray merged 4 commits into
feat/8d-sonku-p0-editor-recovery-20261113from
fix/sof-native-tap-inspector-20261113
Nov 13, 2026
Merged

masarray merged 4 commits into
feat/8d-sonku-p0-editor-recovery-20261113from
fix/sof-native-tap-inspector-20261113

Conversation

@masarray

Copy link
Copy Markdown
Owner

Focused integrated GAIN/PRE/POST/SEND GUI recovery

  • One requestNativeTap owner shared by the SOF button and WIRE inspector. The approved native GUI's legacy MODE gesture now translates to one exact SET_TAP on accepted ChannelId+EdgeId through the existing APPLY_WIRE_TRANSACTION contract. No optimistic graph/UI mutation, no startup replay of tap changes, no second PCM callback.
  • Separate post-insert PRE_FADER from historical PRE_FX/SPLIT_PRE. Use accepted tapStage for offline/native projection while preserving legacy semantics where no modern tapStage exists. A PRE_FADER native send is no longer presented as a PRE FX split route.
  • WIRE inspector shows PRE FADER / POST FADER and SEND LEVEL in native; disables tap when installed native PCM capability is absent. Public Pages reference retains its historical PRE FX / Follow Fader meanings and original controls.
  • Node regression covers inspector MODE→SET_TAP exact edge, rejected rollback; independent contract ACK is not enough, accepted readback at the advanced revision must prove PRE_FADER and preserve EdgeId/gain/SEND ON.
  • No CSS/PNG/SVG/fader/wire geometry changes; source is stacked on 8D-SonKu: native binaural DSP, studio orbit GUI, smooth motion and headphone FAT #606 (which already includes feat(sof): exact EdgeId logical SEND/tap + native PCM gain/send regression gate #623). No Windows real ASIO proof claimed; only merge to 8D-SonKu: native binaural DSP, studio orbit GUI, smooth motion and headphone FAT #606 after fast tests pass. main not a target.

Reference semantics: Yamaha DM7 bus-specific PRE and SEND ON, Waves LV1 PRE vs INP, Studio Pro post-insert PRE-FADER; these are behavior patterns, not copied assets.

@cloudflare-workers-and-pages

cloudflare-workers-and-pages Bot commented Nov 13, 2026 •

Copy link
Copy Markdown

Deploying arsonmix with  Cloudflare Pages  Cloudflare Pages

Latest commit: 95febc6
Status:⚡️  Build in progress...

View logs

@masarray
masarray marked this pull request as ready for review November 13, 2026 03:12
@masarray
masarray merged commit 065cc64 into feat/8d-sonku-p0-editor-recovery-20261113 Nov 13, 2026
12 of 13 checks passed
@chatgpt-codex-connector

Copy link
Copy Markdown
Codex Review Summary: ❌ Failed

This comment shows the latest Codex review activity on this pull request.

Review Status Commit Review trigger
📝 Code Review ❌ Failed 2026-11-13T03:12:08.793212Z
We couldn’t complete this review. Comment @codex review to try again.
95febc6 Draft marked ready
ℹ️ About Codex in GitHub

Your team has set up Codex to review pull requests in this repo. Reviews are triggered when you

  • Open a pull request for review
  • Mark a draft as ready
  • Comment "@codex review" or "@codex security review".

Codex reacts with 👀 while any review is running, comments if it has suggestions, and reacts with 👍 once all reviews finish with no findings.

@chatgpt-codex-connector

Copy link
Copy Markdown

You have reached your Codex usage limits for code reviews. You can see your limits in the Codex usage dashboard.
To continue using code reviews, you can upgrade your account or add credits to your account and enable them for code reviews in your settings.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant