Repository navigation
Conversation
Deploying arsonmix with
|
| Latest commit: |
aacab31
|
| Status: | ✅ Deploy successful! |
| Preview URL: | https://ef9865cd.arsonmix.pages.dev |
| Branch Preview URL: | https://fix-caption-press-visible-ux.arsonmix.pages.dev |
masarray
added a commit
that referenced
this pull request
Nov 13, 2026
…st safety into consolidated UX candidate Reconcile latest #665 FRONT-up and bounded 25 Hz live native SonKu gestures plus #663 guitar art validation and click material, preserving approved caption #660, SonKu SPACE #655, LMS #635, SOF, WIRE and canonical GUI. One combined exact SHA for qualified CI; no public release.
This branch has not been deployed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Native Windows caption pressed state — user-confirmed Alpha.22 defect
Field evidence: hover colors on Close/Minimise/Maximise do work in Alpha.22, but clicking does not visibly illuminate the bright palette as approved (e.g., Built-in FX Close button).
Verified JUCE 8.0.15 cause
Button::mouseUpfirst sets the state back to hover and then immediately dispatches the listener's native Minimise/Maximise/Close command, all within one message-loop turn. JUCE's redraw is asynchronous, so a quick click often never paints the bright down state. Close/minimise hide the parent before JUCE can paint at all. The prior #577/#578 approved semantic palette is correct.Corrective change
MixerCaptionButton::internalClickCallbackto hold one 160ms painted pressed face and defer exactly one unchanged JUCE DocumentWindow listener command via a one-shot message-thread timer.paintButtonusesdown || pendingClick_to make the bright red/green/amber palette and original dark-contrast SVGs visible after mouse release.Reconciliation gate: no micro-release
This PR is a source fix only, do not publish another alpha from this PR alone. Reconcile into one later GUI/UX integrated candidate with active #655 (SonKu and previously staged GAIN/FX/SOF GUI), #635 (LMS GUI native contracts) where safe, and keep unrelated stacked drafts #629/#643/#647/#649 and #604/#606 from being double merged. SonKu hardware/physical ASIO and Loudspeaker Management safety remain independent qualifications; avoid auto merging unverified drafts.
Run low-cost fast/native CI and one Windows compile if necessary. The actual Windows mouse test on final integrated build remains required before claiming UX complete.