Skip to content

fix(caption): make bright pressed feedback visible before native window action - #660

Draft
masarray wants to merge 4 commits into
mainfrom
fix/caption-press-visible-ux-reconcile-20261113
Draft

masarray wants to merge 4 commits into
mainfrom
fix/caption-press-visible-ux-reconcile-20261113

Conversation

@masarray

Copy link
Copy Markdown
Owner

Native Windows caption pressed state — user-confirmed Alpha.22 defect

Field evidence: hover colors on Close/Minimise/Maximise do work in Alpha.22, but clicking does not visibly illuminate the bright palette as approved (e.g., Built-in FX Close button).

Verified JUCE 8.0.15 cause

Button::mouseUp first sets the state back to hover and then immediately dispatches the listener's native Minimise/Maximise/Close command, all within one message-loop turn. JUCE's redraw is asynchronous, so a quick click often never paints the bright down state. Close/minimise hide the parent before JUCE can paint at all. The prior #577/#578 approved semantic palette is correct.

Corrective change

  • Override MixerCaptionButton::internalClickCallback to hold one 160ms painted pressed face and defer exactly one unchanged JUCE DocumentWindow listener command via a one-shot message-thread timer.
  • paintButton uses down || pendingClick_ to make the bright red/green/amber palette and original dark-contrast SVGs visible after mouse release.
  • Preserve existing SVGs, hover colors, 34px targets, native focus fixes fix(window): restore native caption hover/pressed controls through WebView2 focus #656, window shortcuts and standard actions. No CSS/JS/ASIO/PCM/continuous timer, no persistent always-on-top and no audio processing changes.
  • Extend existing caption structural test with one-shot, no-double-command, correct native callback contract.

Reconciliation gate: no micro-release

This PR is a source fix only, do not publish another alpha from this PR alone. Reconcile into one later GUI/UX integrated candidate with active #655 (SonKu and previously staged GAIN/FX/SOF GUI), #635 (LMS GUI native contracts) where safe, and keep unrelated stacked drafts #629/#643/#647/#649 and #604/#606 from being double merged. SonKu hardware/physical ASIO and Loudspeaker Management safety remain independent qualifications; avoid auto merging unverified drafts.

Run low-cost fast/native CI and one Windows compile if necessary. The actual Windows mouse test on final integrated build remains required before claiming UX complete.

@cloudflare-workers-and-pages

cloudflare-workers-and-pages Bot commented Nov 13, 2026 •

Copy link
Copy Markdown

Deploying arsonmix with  Cloudflare Pages  Cloudflare Pages

Latest commit: aacab31
Status: ✅  Deploy successful!
Preview URL: https://ef9865cd.arsonmix.pages.dev
Branch Preview URL: https://fix-caption-press-visible-ux.arsonmix.pages.dev

View logs

masarray added a commit that referenced this pull request Nov 13, 2026
…st safety into consolidated UX candidate

Reconcile latest #665 FRONT-up and bounded 25 Hz live native SonKu gestures plus #663 guitar art validation and click material, preserving approved caption #660, SonKu SPACE #655, LMS #635, SOF, WIRE and canonical GUI. One combined exact SHA for qualified CI; no public release.

This branch has not been deployed

No deployments
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant