Repository navigation
fix(guitar-fx): ship real built-in Guitar FX through approved FX Picker and native PCM - #607
Conversation
…d asset acceptance
… workflow interactions
…d design-only UX guardrails
…d control mutations
…teral concatenated path
…et FIR wet PCM core
…g FX lease/catalog
…trip and malformed restore rejection
|
/arsonmix-ci native c548d6e |
…fade and native ACK
… edits on device restart
… and realtime ACK-bound controls
…ware focus editor
…sfade, restart-safe stale packet fence
… latest approved main
…rive bypass changes
…DC and CI CPU baseline
|
/arsonmix-ci fat a773a6e |
…ck FX picker catalog
…in native FX picker
…nding logical ACK semantics
…picker and real insert ACK
…icker integration
… current installer/UI main
|
/arsonmix-ci ui 5b68eea |
…ixer Chromium scenario
|
/arsonmix-ci ui 2fab34a |
…ssion onto current main
|
/arsonmix-ci fat 03ba6ec |
GFX audit / delivery checkpoint — 13 Nov 2026 (verified from live GitHub)Verified candidate: Exact-SHA Windows delivery is now COMPLETE/SUCCESS, not still running:
Important delivery boundary: the installed main-based application still lacks Guitar FX because this branch is unmerged. The two links above are source-qualified field-preview builds, not public/stable release proof. The GitHub workflow's dispatch metadata refers to main but logs demonstrate checkout/packaging from the exact GFX PR SHA. Remaining hard gates:
This checkpoint closes the Windows FAT result verification task; physical qualification and product promotion remain open. |
…ar FX P0 No overlapping files with native Guitar FX integration. Preserve both latest approved V66 WIRE UI/tests from main and verified GuitarRigProcessor/FX Picker from #607. Source FAT #43377503898 and 92/92 CTest were verified at parent 03ba6ec; new merge SHA still requires targeted CI. Physical Hi-Z/ASIO FAT is a separate field gate, not claimed.
Codex Review Summary: ❌ FailedThis comment shows the latest Codex review activity on this pull request.
ℹ️ About Codex in GitHubYour team has set up Codex to review pull requests in this repo. Reviews are triggered when you
Codex reacts with 👀 while any review is running, comments if it has suggestions, and reacts with 👍 once all reviews finish with no findings. |
|
You have reached your Codex usage limits for code reviews. You can see your limits in the Codex usage dashboard. |
Tracking epic: #608
Product objective
Start ArSonMix Guitar FX as a maintainable single native FX insert program, with a clear user journey and a reproducible original hardware PNG system. Do not add a second audio callback, a separate mixer, or a browser PCM engine.
Deliverables in this foundation PR
scripts/build_guitar_fx_assets.mjs.design-references/guitar-fx/editor-prototype.html: preset categories/search, signal chain, focused editor, block bypass, bounded drag reorder (AMP/CAB paired), knob control, A/B, tuner placeholder and design JSON export.docs/guitar-fx/GUITAR_FX_FOUNDATION_20261113.md: native host ownership, state schema, resource policy, acceptance tests, licensing and staged milestones.engine/builtin_fx/guitar/GuitarProgramModel.h: bounded 16-block stable-ID program validation, normalized parameter mutation and fail-closed reorder. No JUCE/PCM host changes; portable C++ test and scoped Linux CI.Boundaries
/preview/, native ChannelId/EdgeId graph and currently approved mixer controls/buttons.src/, existingengine/core/,web/,site/preview, device or installer. Only a new unregistered pure program-model header is added underengine/builtin_fx/guitar/.Focused verification
node scripts/build_guitar_fx_assets.mjs node --test tests/guitar_fx_assets_contract.test.mjs c++ -std=c++20 -O2 -Wall -Wextra -Werror -pedantic tests/guitar_fx_program_model_test.cpp -o /tmp/guitar-program-test && /tmp/guitar-program-testVisual review: open
design-references/guitar-fx/editor-prototype.htmllocally; check 1280/1440/1920 desktop dimensions, browser collapse, button/focus/bypass distinction, amp vs cab vs pedal focus and realistic PNG quality. Native Windows/FAT are intentionally not dispatched for this design-only foundation.Next product milestone
M1 playable: native
GuitarRigProcessorregistered once inNativeBuiltInFx, bounded gate/drive/amp/cab, versioned state, generic editor/ACK readback, genuine PCM from Hi-Z channel through existing WIRE to MAIN, and physical ASIO guitar FAT. This requires a separate cohesive vertical integration, not mere visual promotion.Verified exact-SHA evidence (2026-11-13)
d160885622c4f01989708abbf86cd97189fb4428.M1 first-sound native DSP candidate — 2026-11-13
At the exact PR HEAD, this work extends beyond the initial design foundation:
Exact-SHA asset/C++ and fast UI/native CI PASS at c548d6e.
One owner-dispatched native Windows job: https://github.com/masarray/arsonmix/actions/runs/43326382778 — initially RUNNING; inspect current job for final result.
Native live-editor milestone — 2026-11-13
df56da63ddbd35d7b29f1b9f0edc69caa82fa908includes merge-base reconciliation withmain@cf49c56eb3bbd4b44bf7bed3a04c3c1530b28de6(nonoverlapping paths preserved).GuitarRigProcessornow supports CONTROL-prepared immutable 4-stage programs through bounded 4-slot SPSC, audio-callback ACK, monotonic request IDs, 128-sample dual-DSP crossfade, same-PDC FIR, and stale-rate packet cancellation on device restart.engine/builtin_fx/GuitarRigEditor.his a native JUCE editor inside the existing FxInstance editor lease (not a second PCM graph/WebView/mixer). It loads ORIGINAL indexed PNG art embedded by production CMake, has one focused module panel, 4 fast tone presets, real peak meters, and keyboard/mouse sliders. Logical-only/no-callback state never falsely reports a live meter or completed edit.src/NativeBuiltInFx.hregisters the one existing host identity and hasEditor; browser FX picker dynamically receives the native registry so no optimistic JS-only plugin stub was added.GATE > DRIVE > AMP > CABis accepted by this editor and DSP. Compression/reverb/modulation, actual NAM models and verified capture IRs remain separate future DSP work, not fake selectable stages..smixcapture is gated on accepted/ACKed state. A closed editor does not strand completions; no heap, locks, file IO, model preparation, or second callback in realtime.P0 Windows regression RCA and source repair — 2026-11-13
BinaryData::amp_head_class_a_png,cabinet_dual_12_png,pedal_overdrive_png,knob_brushed_metal_pngnot generated. JUCE omits hyphens when generating C++ resource member identifiers, as independently evidenced by productionBinaryData::arsonmix256_pngforarsonmix-256.png.ampheadclassa_png,cabinetdual12_png,pedalgate_png,pedaloverdrive_png, andknobbrushedmetal_png(with matchingSize) in the production native editor.ARMixAssetscontract. New Gate focus illustration uses its own original asset. Sequenced native program transitions so an active crossfade cannot be interrupted by a second edit.67b526ad8847a07840cc227b66c04f840ea9fcd1, mergeable draft; preserve single approved/preview/and one native JUCE PCM callback.M1 active-audio reliability milestone — 2026-11-13
New product behavior: Previously
GuitarRigProcessor::processBlock()did not consume queued tone edits when the insert was ON; the existing FX host drains native mailboxes only while fully bypassed, and EQ/COMP/Harmonice do the normal active-path drain in their own PCM processing. This stranded Guitar FX preset/knob edits during actual playing. Corrected to consume one bounded edit inside the SAME active realtime block, with no new callback or device graph.Snapshot integrity: added
pending_atomic intent counter, incremented before SPSC publish, decremented only after accepted callback ACK or restart cancellation.stateSnapshotQuiescent()now denies capture during the queue-pop → completion-publish gap, preventing stale.smixsnapshots. Added 32-frame stepped crossfade queue regression, active-PCM ACK, and device-restart cancellation coverage.Editor lifecycle: drains previous PCM completions before displaying reopened tone, so closing a native editor window before the timer handles ACK no longer displays stale accepted settings. All new changes are covered in targeted source/native tests.
Integration: reconciled with current approved
main@de7ad861930bf03ca35f783a59395e42386ca26d, preserving its mixer-fader CSS changes (no path overlap). Current exact PR HEADc40c661f7fe1d7d31f5d7233003a9a4bfdc9d934remains a draft.Evidence: previous Windows exact-SHA MSVC + native CTest SUCCESS at
67b526ad8847a07840cc227b66c04f840ea9fcd1. At current HEAD, all five fast/check lanes succeed: guitar asset validation, fast native, harmony verification, native preset targeted Windows CTest, UI Chromium smoke.Exactly one new field-preview FAT build requested: Windows FAT / verified ZIP. It includes full Windows MSVC and CTest; do not also dispatch native for the same SHA. Follow GFX_FIELD_ACCEPTANCE.md for actual physical Hi-Z/ASIO validation.
Do not mark M1 shipped until FAT job completes, its ZIP integrity/provenance is verified, and real interface/guitar listening (round-trip latency, routing, tone changes, saved state, device switch) is reported separately. No NAM or cabinet capture claim.
M1.5 professional live-rig update — 2026-11-13
Exact candidate SHA:
2f7c5ea5a8d4bfe9e7e6286bd3728bcc324133a8, reconciled with approvedmain@a123fd9775a9013f44f6f1df50305893c734f3d2(no overlapping files; preserves /preview/ WIRE changes). Full 5-lane fast CI passed at this exact SHA.Product code in this PR:
engine/builtin_fx/guitar/GuitarFactoryTones.h. Engine and native editor now share the same values and names; any actual parameter or bypass deviation correctly becomes Custom..smixFX blob; old v1 single-tone state is migrated into both banks. Malformed bank/size/ID/parameter rejects atomically.Research / future strategy: Professional workflow and DSP architecture. The core reference workflows are NI Guitar Rig rack, Helix Native snapshots, and MIT NeuralAmpModelerCore (library license is not a license for external model captures).
Quality evidence: the previous exact-SHA first-sound Windows FAT SUCCEEDED on
c40c661f, publishing verified Windows ZIP and installer artifacts; that preview predates this A/B/FIR update. The current exact-SHA combined Windows MSVC/CTest and field ZIP run was dispatched once: FAT #43355170393; final result is not asserted until the run completes. Hardware guitar/Hi-Z/ASIO FAT, licensed measured cabinet IR and any NAM quality claims remain pending. Keep PR draft until those gates.M1.6 Windows red-to-green recovery and seamless playing (2026-11-13)
legacy.getSize()==188beforejuce::MemoryOutputStream::flush(), which leaves spare MemoryBlock capacity until flush/destruction. Fix checksgetDataSize(), flushes, then checks the exact serialized 188-byte v1 payload. JUCE official docs: https://docs.juce.com/master/classjuce_1_1MemoryOutputStream.html.RealtimeNativeFxControl::onRealtimeBypasscallback now tells Guitar FX when the host is fully bypassed. A partial transition is finalized without waiting forever for skipped wet PCM; queued A/B programs ACK while bypassed. On full bypass, stale 32-sample cabinet / gate history is reset so old notes do not replay on wet resume.main@2740dcf767a24f82c5c0e8a7aa747fd33f8c4165:56b9dadf8cf1bb1080cd325ffc09e11d963db24a. Before FAT, confirm exact-SHA fast CI green. Do not confuse previous Windows FAT failure with release success. Physical ASIO audition / validated audio tone / NAM assets remain unproven.M2 antialiasing + musical Gate milestone — 2026-11-13
New code beyond M1.6 (under this PR):
GuitarOversampling2x.h: always-on CONTROL-prepared polyphase 33-tap FIR interpolation/decimation around nonlinear Drive/Amp ONLY (no new thread/callback/heap); native-rate Gate/CAB retained. Dry preamp delay stays warm through the enabled stages.setLatencySamples(GuitarRigCore::processingLatencySamples).Evidence: Previous M1.6 exact-SHA FAT #43358470139 SUCCEEDED with 92 native CTests and Windows installer/ZIP artifacts. Those artifacts predate the M2 2× audio processing and are NOT a current-M2 release qualification.
Current M2 candidate: PR HEAD
a773a6e5a76f0ace4d8e89f64fdeb413d929773b, base main383cf1927498d9c3f557110d71825363077b5be6. Fast checks pass or are finishing; do not claim Windows M2 success until an exact SHA FAT succeeds and publishes a verified ZIP. Remain draft pending guitar/Hi-Z/ASIO physical listening, actual xrun/CPU benchmarks, model/IR licenses and visual approval.Research basis: JUCE Oversampling latency/filter tradeoffs, FabFilter Pro-G stereo linking and Ableton Gate hold/release. New M2 DSP architecture and qualification.
One exact-SHA M2 FAT was dispatched (NO duplicate native job): run #43363114517, candidate
a773a6e5a76f0ace4d8e89f64fdeb413d929773b. Fast native preflight already SUCCESS; Windows MSVC + full 92-CTest bundle in progress at recording. Release remains blocked pending exact-SHA job SUCCESS + artifact publication + physical Hi-Z/ASIO qualification.P0 end-user regression: Guitar FX absent from FX Picker (13 Nov 2026)
Owner field report: Guitar FX cannot be found in the installed app FX Picker. Root cause is a release/integration gap, NOT a DSP success: this complete Guitar FX work was still DRAFT/unmerged PR #607, so any main-based installed build does not contain the native GuitarRigProcessor. Separately the compiled WebView bridge's initial
nativeBuiltinscatalog lackedarmix.builtin.guitar-rig.v1even inside PR, making first picker opening unreliable untilarMixCatalogarrived.Fixed on this branch:
web/approved-native-bridge.jsnow registers Guitar FX Rig / Guitar alongside EQ, Compressor, Harmonice with EXACT same identity asGuitarRigProcessor::catalogIdentityand C++NativeBuiltInFxregistry'sshowInPicker=true. The bridge still replaces its pre-event list with the actual nativearMixCatalog.builtInssnapshot, so old binaries cannot silently claim Guitar processing. ExistingsetNativeCatalog→renderFastPickerandLOAD_INSERT→ACK→snapshotare reused; no fake demo audio or separate FX picker.Regression:
tests/approved_native_m2_contract.test.cjsasserts C++/bridge ID parity, visibility, and native insert ACK path;tests/approved_native_offline_logical_smoke.pyactually opens original compiled Chromium FX Picker (first-open plus native catalog), searches Guitar and emits a logical ADD_FX_REFERENCE as LAST offline action without wrongly claiming a PCM INSERT. First full UI run #43375981087 verified item visibility and catalog binding but encountered a test sequencing bug: the inserted pending logical command prevented subsequent CREATE_CHANNEL test. Moved the pending click to the last workspace action, preserving both tests. One targeted retry #43376716371.Hard delivery gate: after actual Chromium picker PASS, reconcile with latest main, run one exact-SHA Windows FAT build producing a user-test ZIP and installer. Only then promote verified code to main if allowed; do not claim the user's currently installed main build magically contains this draft. Physical Hi-Z/ASIO listening remains separately pending and no public stable release is authorized by CI alone.
GFX picker owner deliverable checkpoint — 13 Nov 2026
feat/guitar-fx-foundation-assets-ux-20261113was never part of main-based installed builds. Owner's missing-Guitar FX observation is expected on that older binary, even though previous FAT DSP passed.web/approved-native-bridge.jsbuilt-ins witharmix.builtin.guitar-rig.v1, exact native descriptor parity. Browser picker shows Guitar FX Rig under Guitar, searchable by "guitar" without VST3 scan, with real LOAD_INSERT/ACK/readback.a6b8a3f4c98f7c8552442ffb1ae68f990034f2e0without path overlap. Current exact source SHA03ba6ecc2065a6b7e0057b4db0f674be5e78068ahas 5/5 fast checks successful, production native registry tests and actual Chromium picker steps passed.