Repository navigation
P0 integrated release candidate: SonKu SPACE + Guitar FX + V67 WIRE + verified Windows field build - #654
Merged
Conversation
Remove startup WebView toBack() and present native mixer one time at GUI-ready with transient Windows foreground Z-order lift. Preserve silent health-probe isolation; fast contract and exact-head Windows native CI passed.
#645) * fix(gui): V67 restore energetic short-span WIRE whip and loose-tip reel * test(chromium): prove adjacent WIRE whip energy against V66 long-span baseline * test(chromium): correct raw regex parsing for sampled adjacent WIRE path * test(chromium): exercise adjacent wire via real drag and accept incoming/outgoing path projections * test(chromium): adapt legacy V43 wave regression to V66 sampled path and 680ms motion * test(chromium): align historical V15 physical controls with canonical PFL key * test(chromium): scope outdated V15 fixture to its real WIRE drag/BUS routing ownership
…Picker (#607) Integrate one existing native JUCE guitar FX insert with Gate, Drive, Amp, CAB, 2x anti-aliasing, A/B .smix state, authentic active-PCM ACK and non-fake UI meters. Browser picker catalog is aligned to native identity. Preserve current main WIRE and startup flow. Exact source parent 03ba6ec Windows FAT 92/92 CTests and verified field-preview installer/ZIP; reconciled c904034 all five targeted PR workflows passed. Physical Hi-Z/ASIO audition and public stable release remain explicitly unqualified.
Replay all validated #617 CI hunks onto latest native/guitar main, keeping both histories and existing full native/FAT public release gates. Correct final-package provenance: assign FIELD_PREVIEW_FULL_CTEST_NOT_RUN BEFORE independent ZIP verifier, check source SHA, and do NOT inject a FIELD-PREVIEW.txt file after verification. Final artifact remains strict allowlisted and carries hash-verified EXE, GUI and hardware FAT tools. Only scoped CI dispatcher/workflow/tests/docs change; no mixer DSP or UI.
…compile (#653) ci(P0): verified exact-SHA portable Windows field preview without full CTest compile
…eld preview into SonKu M4 Replay 16 modified files from the exact prior main baseline into M4 using uniquely matching hunks, including CMake, native host, UI and tests. Resolve only two semantic overlaps by retaining BOTH SonKuSpatialProcessor and GuitarRigProcessor in single native registry and FX Picker. Import all 28 new Guitar FX assets, DSP and tests from exact main tree blobs, including binary PNG hashes. Two Git parents preserve full source histories. No alternate audio callback, forced branch update, speculative GUI route or public release. Candidate requires fast native/UI, Chromium and exact-SHA Windows field qualification.
… existing scoped Chromium runner
masarray
marked this pull request as ready for review
November 13, 2026 08:04
masarray
merged commit Nov 13, 2026
028f8d6
into
feat/8d-sonku-m4-reconciled-native-20261113
17 of 18 checks passed
Codex Review Summary: ❌ FailedThis comment shows the latest Codex review activity on this pull request.
ℹ️ About Codex in GitHubYour team has set up Codex to review pull requests in this repo. Reviews are triggered when you
Codex reacts with 👀 while any review is running, comments if it has suggestions, and reacts with 👍 once all reviews finish with no findings. |
|
You have reached your Codex usage limits for code reviews. You can see your limits in the Codex usage dashboard. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Cohesive product integration (not another audio engine)
Two-parent Git merge candidate:
f8535bf37a91fa394b95106d0fc44daee05b4e40(parents qualified SonKu M4 #649630c881b...and latest main9c17e926...). This carries the fully native Guitar FX from #607, current WIRE V67 short-cable UX, Windows startup foreground #646 and cheap exact-SHA Windows field-build workflow #653 into SonKu M4's one authoritative JUCE graph and SPACE engine.Reconciliation evidence
src/NativeBuiltInFx.handweb/approved-native-bridge.jsreconciled by hand to keep bothSonKuSpatialProcessorandGuitarRigProcessorin the one installed native FX registry and approved picker; no duplicate callback, WebAudio, mock plugin, or bypass of ChannelId/EdgeId/ACK/readback./preview/retains the exact genuine main V67 WIRE changes plus SonKu approved rendering; no arbitrary palette/font redesign. Windows field preview provenance is tagged before independent final package verification.Acceptance
Exact SHA fast Linux native/PCM, GUI/provenance and custom guitar assets, combined Chromium SonKu/FX/WIRE; then one owner-dispatched
/arsonmix-ci field <headSHA>to produce an artifact for hands-on ASIO/VST3/WIRE/Guitar/SonKu tests. Full Windows CTest, hardware XRUN and public installer release gates remain separate, not claimed by field preview. Do not merge this into #649 until automated cross-feature tests are green; #649 remains draft.