Skip to content

Guitar FX Rig epic — realistic original assets, single-host UX, playable DSP and ASIO FAT #608

Open

Description

@masarray

Milestone B verified triage — 2026-11-17: P1 / guitar-fx / feature / planned. Classification ≠ completion of product feature or physical FAT.

Scope / release boundary: Visual acceptance pending; experimental visuals must not replace approved GUI.

Exit criteria:

  • Present original licensed transparent pedal and amp bodies without prepunched control holes, with separate knobs/switches/LED and correct hitboxes/shadows.
  • Verify native JUCE Guitar IN→pedal→amp→cab IR→channel FX→MAIN signal, meaningful presets, ASIO/reopen and visually accepted captured preview.

Canonical issue ledger. Preserve historical evidence below; no speculative merging or rewriting approved audio.


Product charter

Make ArSonMix a practical professional live-guitar rig: Guitar IN (Hi-Z) → native Guitar FX insert (pedals → amp model → cabinet IR) → existing channel FX/fader/WIRE → verified MAIN/BUS/physical output. A guitarist should be able to choose a factory tone and play without hardware multi-effect pedals, additional device callbacks, or a separate DAW.

The UX must evoke realistic amplifier and stompbox hardware with original licensed PNG assets, but preserve ordinary, ergonomic DAW habits: focused editor, always-visible chain, truthful state, low text noise, compact controls, preset-first workflow and accessible keyboard/editing.

Ownership contract (do not fork the host)

One native GuitarRigProcessor registered through src/NativeBuiltInFx.h, following src/NativeFxControlRequest.h and existing FX leases, readback, .smix restore. Keep one JUCE realtime callback and accepted ChannelId/EdgeId PCM authority, the one approved /preview/ mixer, existing host editor owner, stable instance IDs, safe device switch. Reconcile concurrent #605 editor auto-open and #604 GAIN/FX Rack, rather than overwriting their work. Harmonice remains a separate vocal effect.

Milestone checklist

  • F0 code foundation committed on PR fix(guitar-fx): ship real built-in Guitar FX through approved FX Picker and native PCM #607: original amp/cab/pedal/knob/LED assets, reproducible PNG generator, focus-editor UX contract, design-only interactive editor and fast asset test source.
  • F0 verification: confirm byte-identical generated assets, baseline desktop screenshot, keyboard/pointer tests, realistic visual quality approved, and merge PR fix(guitar-fx): ship real built-in Guitar FX through approved FX Picker and native PCM #607 without regressing live /preview/.
  • M1 playable vertical slice: native processor + Gate/Drive/Amp/Cab IR; actual DSP wet PCM fixture, safe bypass, generic typed editor/ACK/readback, accepted .smix program state, CH05 Hardware IN → FX → MAIN and SOURCE ONLY routing fixtures; one exact-SHA native qualification.
  • M1 physical ASIO FAT: actual guitar/interface Hi-Z, input trim, headphone and MAIN, noise/crackle/dropouts, 44.1/48/96 kHz and 64/128/256 frames where device supports, measured round-trip latency, load/rebind, A/B continuity; no automated CI may claim this.
  • M2 live performance: per-block valid drag ordering, chorus/mod/delay/reverb, tuner (real pitch), A/B smooth switching, full preset browser/save/restore, resource-aware multiple channels and reliable failure UX.
  • M3 pro quality: review licensing/capture file rights for NAM and IR, quality profiling vs guitar references, MIDI footswitch, advanced dual/parallel paths only when bounded, supported model compatibility and resource caps.

Performance/quality gates

No heap allocation, lock, logging, disk, resample-table or model construction in PCM callback. IR/model metadata and actual buffers are constructed off-thread, published atomically. Missing/invalid model or IR fail closed and preserve previously accepted instance state; no fake tone/PDC or GUI 'audible' status. Nonlinear oversampling and NAM models are measured with CPU/xrun/latency budget. UI decorative images never encode the accepted parameter values, hit areas, labels or meters.

Assets and UX

F0 source of truth: foundation contract, prototype and PNG folder, PR #607. Art is initial procedural mock hardware, not yet approved photorealistic asset quality. No commercial amp logos, vendor screenshots, paid IRs or unlicensed captures.

Use small coordinated PRs only at meaningful product milestones, with smart CI and exact relevant tests; do not create repeated architecture-spike gates or redundant Windows builds. The owner should be able to test a working guitar-amp build at M1, not merely see another static mockup.

Native first-sound checkpoint — 2026-11-13

  • Register one ordinary native guitar FX descriptor on the existing ChannelId/FxInstance host.
  • Add actual gate/drive/nonlinear amp/original cabinet FIR DSP with portable golden-PCM tests.
  • Add versioned built-in state schema, restore and native registry negative fixtures.
  • Complete exact-SHA Windows JUCE CTest; see PR fix(guitar-fx): ship real built-in Guitar FX through approved FX Picker and native PCM #607.
  • Complete accepted editor/controls and realistic PNG visual review.
  • Physical Hi-Z/ASIO guitar FAT, measured latency and licensed NAM/cabinet captures; no claims yet.

Native live editor milestone — 2026-11-13

  • Control-prepared native 4-stage program SPSC, ACK, crossfade, sample-rate restart guard.
  • Native JUCE focus editor with embedded original hardware PNGs, 4 preset selector, live PCM-observed meters, honest offline status.
  • Existing FX slot/editor lease without another callback or generated /preview/.
  • Reconcile PR fix(guitar-fx): ship real built-in Guitar FX through approved FX Picker and native PCM #607 with latest approved main; fast CI, GUI and asset contracts green.
  • Exact-SHA native Windows full build/CTest (one targeted run #43336513346).
  • Real guitar/Hi-Z input + ASIO output FAT and professional visual/tone approval.

CI red-to-green recovery — 2026-11-13

  • Read full failing MSVC log: build blocked by JUCE BinaryData symbols derived incorrectly from hyphenated original PNG files.
  • Correct every GFX native editor BinaryData member, add fast regression, show separate Gate/Overdrive skins, protect crossfade transitions.
  • Reconcile GFX branch with current main, preserving approved /preview/ changes.
  • Fast tests for the reconciled SHA 67b526ad8847a07840cc227b66c04f840ea9fcd1 green.
  • Confirm exact-SHA Windows native run #43342084263 finishes green (actively dispatched; no duplicate run).
  • Physical guitar/Hi-Z/ASIO audition and verified installer FAT.

GFX first active-audio bugfix — November 13, 2026

  • Fix active-route guitar preset/knob commands (consume in PCM, not only rack bypass).
  • Fence Show/.smix snapshots across in-flight pop→ACK using pending-intent counter.
  • Restore latest accepted state on editor close/reopen.
  • Fast checks green, branch reconciled with main@de7ad861.
  • One exact-SHA FAT run #43351278555: MSVC/CTest + verified Windows ZIP (record final conclusion).
  • Real guitar / Hi-Z / ASIO FAT under field acceptance.

M1.5 professional guitar rig milestone — 2026-11-13

  • Central factory tone catalog (DSP + editor; correct Custom identification).
  • Durable native A/B banks in .smix GRX1 v2 with exact v1 single-tone compatibility.
  • Snapshot abort semantics: invalid bank/B payload cannot change accepted DSP; callback-ACK binding.
  • Tone edits while FX rack fully bypassed; final in-flight editor commands survive window close while processor remains prepared.
  • 65-tap synthetic FIR symmetric pair optimization (33 multiplications/sample/channel) and per-rate/partition tests.
  • Reconciled latest native UI / WIRE main without file overlap; all fast CI passed exact SHA 2f7c5ea5.
  • Older c40c661f Windows FAT build success #43351278555 with ZIP and installer artifacts (does not contain new A/B).
  • Verify new exact-SHA FAT #43355170393 (one job, avoid duplicate native build).
  • Physically test guitar Hi-Z/ASIO quality, capture latency, and obtain approval of original artwork.
  • M2 optional NAM model/IR backends only after per-model licensing and real CPU/spectral qualification.
    Architecture: GFX pro workflow.

M1.6 realtime/bypass and FAT recovery — November 13, 2026

  • Analyze failed FAT #43355170393 (91/92 pass): v1 fixture MemoryOutputStream spare capacity, missing flush before exact byte assert.
  • Fix stream fixture, warm-history transfer for amp/cab knob updates, cancel stranded wet crossfade on fully bypassed host.
  • Reset old FIR/gate tails at fully bypass to prevent old note replay after wet restore.
  • Cache five hardware PNG skins across native editor sessions; add DSP/registry/source tests.
  • Reconcile M1.6 branch with nonoverlapping approved main 2740dcf7.
  • Green exact-SHA 5 fast checks, and one Windows MSVC+CTest+validated ZIP/installer FAT for 56b9dadf.
  • Real ASIO Hi-Z listening field tests and measured CPU/round-trip latency; no early public release.

M2 studio gate and antialias quality milestone — Nov 13 2026

  • Native stereo-linked Gate with Threshold / Hold / Release controls and real PCM differences; preserve GRX1 preset restore.

  • 2× CONTROL-prepared FIR polyphase oversampling solely around Drive/Amp. Original native CAB / Gate retained.

  • Exact 48-frame JUCE PDC (16 preamp + 32 cabinet) through Drive/Amp/CAB bypass, warm dry path and A/B crossfade.

  • Aliasing 9k→21k at 48kHz improved −16.67 → −57.20 dBc; hard spectral regression threshold below −35 dBc.

  • Non-gating runner CPU probe of 1/4/8 inserts ~0.75/2.93/5.77% equivalent runtime, not physical ASIO evidence.

  • Last M1.6 FAT #43358470139 green with Windows ZIP+installer; old artifacts do not include M2 DSP.

  • One exact-SHA M2 Windows FAT, verified installer/ZIP, no duplicate native builds.

  • Field Hi-Z/ASIO signal, loopback latency, CPU/xrun, stereo gate/pedal sound tests at 44.1/48/96 kHz; real professional tone/asset approval.

  • M2 exact-SHA Windows FAT: #43363114517 on a773a6e5a76f0ace4d8e89f64fdeb413d929773b (in progress at authoring; do not merge until final verified).

P0 owner-visible Guitar FX picker failure — 13 Nov 2026

  • Identify owner build blocker: draft PR fix(guitar-fx): ship real built-in Guitar FX through approved FX Picker and native PCM #607 never merged to main; main installers exclude native GuitarRigProcessor.
  • Add exact native Guitar FX entry to initial WebView FX Picker catalog; retained authoritative arMixCatalog/LOAD_INSERT ACK pipeline.
  • Add C++/bridge identity source contract and actual Chromium first-open/search/selection regression.
  • Confirm real Chromium UI retest #43376716371 green after isolating pending logical edit at end of test.
  • Reconcile latest main, one exact-SHA Windows FAT yielding verified test installer/ZIP, and merge approved qualified feature.
  • Owner Hi-Z/ASIO sound FAT still needed before declaring stable release; no fictitious plugin download.

Exact FX Picker delivery verification

  • Native registry showInPicker=true + initial built-in browser catalog armix.builtin.guitar-rig.v1.
  • Actual Chromium first-open, search and logical native intent; no fake audio/ACK.
  • Branch reconciliation with main a6b8a3f4 and 5/5 source checks green.
  • Verify SHA 03ba6ecc Windows FAT #43377503898, publish ZIP+installer, then integrate validated feature code to main only when permitted.
  • Physical ASIO guitar audio FAT before stable release.

Activity

  1. masarray commented on Nov 13, 2026

    @masarray
    OwnerAuthor

    P0 code integration complete — 13 Nov 2026

    Merged PR #607 into main via squash SHA 977b6227d436b73cbf6c63d8f0fb6fd6d5b8a2e5 (commit). This removes the reported end-user root cause: Guitar FX Rig existed only on an unmerged branch and could not appear in main-based installed builds.

    Product verified in main: native registry id armix.builtin.guitar-rig.v1 (showInPicker true), matching approved WebView FX Picker entry, embedded guitar editor PNG assets in CMake; one existing JUCE PCM graph, real Gate/Drive/Amp/CAB, 2× preamp oversampling, 48-sample PDC, true A/B .smix/ACK. Prior #605 post-insert editor behavior remains. Mixer V66/V67 WIRE and #646 foreground startup are retained.

    Build evidence: guitar source parent 03ba6ecc exact-SHA Windows FAT #43377503898 finished SUCCESS: 92/92 native CTests, verified Windows ZIP and installer artifacts. After reconciling latest main commits into PR branch, head c904034 passed 5/5 targeted GitHub PR workflows, including Chromium and native CTest. These are software gates only. The earlier field-preview ZIP predates the subsequently merged #646 startup and V67 WIRE changes; do not present it as a byte-for-byte package from new main.

    Outstanding P0 HARDWARE qualification, not claimed completed: physical guitar with real instrument/Hi-Z ASIO interface, signal path to MAIN, audible Clean/Blues/Crunch/Lead and CAB/bypass changes, active realtime gain/knob edits, true meters and independent A/B, save/reopen .smix, sample-rate/device switching, CPU/xrun and loopback latency. Follow GFX_FIELD_ACCEPTANCE.md. Do not mark the stable/public-release audio qualification complete from CI alone.

    Release distinction: source integration to main is complete, but no new public stable release/tag or physical ASIO FAT is asserted here. Other M2/M3 playable modules (tuner/mod/delay/reverb/NAM/IR) remain future work, not hidden faux buttons.

  2. masarray commented on Nov 13, 2026

    @masarray
    OwnerAuthor

    P0 correction — owner FX Picker field failure is a real packaged-version gap (13 Nov 2026)

    The prior "ready to test" assessment was incorrect for the installed public release. Alpha.19, published 13 Nov 2026, is pinned to source 746877e28fddbf9dc19816be024afbbad43d3e69, and this exact source has neither GuitarRigProcessor native registration nor armix.builtin.guitar-rig.v1 in approved FX Picker bridge. Guitar FX only entered main with merged PR #607 at 977b6227d436b73cbf6c63d8f0fb6fd6d5b8a2e5. An installed Alpha.19 cannot expose Guitar FX even though #607 was merged later.

    Actual delivery action taken: Created releases/alpha/v0.5.0-alpha.20 with immutable candidate SHA 6cb595646d3cf892078fb3eb6d06858b2e0e80a2, descended from main@9c17e926, containing native Guitar FX, current picker and latest approved startup/WIRE fixes. Added explicit owner FAT/release notes docs/releases/v0.5.0-alpha.20.md. Submitted owner-only release command on #450; official Alpha.20 Windows builder #43389944203 DISPATCHED. Do not assert the Alpha.20 installer is available until this workflow has actually succeeded and release assets exist.

    Acceptance must start with a freshly installed verified Alpha.20 (not Alpha.19): FX Rack → Add FX → FX Picker must show Guitar FX Rig under Guitar and return it from search, without VST3 scanning. Only after this visible first-click check should physical Hi-Z/ASIO audio tests proceed. No public stable release or hardware FAT pass claim is made.

    For immediate experimental testing independent of the public Alpha.19, earlier exact-SHA PR #607 FAT #43377503898 contains the native Guitar FX source and a verified Windows installer/ZIP; it predates some later main startup/WIRE fixes and is not equivalent to a current official Alpha installer.

    P0 distribution lesson: PR/CI success is NOT installed-binary visibility, and existing immutable release tags must never be misrepresented as including post-tag features.

  3. masarray commented on Nov 13, 2026

    @masarray
    OwnerAuthor

    P0 correction: actual g03ba6ecc installed-app screenshot (13 Nov 2026)

    Owner reproduced missing Guitar FX even in exact-SHA FAT g03ba6ecc. Root confirmed: scripts/compose_native_peq.py replaced the compiled renderFastPicker with a manually constructed four-item BUILT-IN FX block (EQ, Compressor, Harmonice, Vocal Throw), then incorrectly put all catalog-driven native FX, including valid armix.builtin.guitar-rig.v1, beneath VST3 PLUGINS. Previous tests searched for a DOM item anywhere and failed to check the operator-visible group.

    Fixed/merged PR #657 in main SHA 54702c2796b6713dc6a936276b9c5c11b0f97135. Registered additional real native FX now appear first in BUILT-IN FX, not VST3; four legacy special editor buttons retained, no duplicated native catalog rows. Cold-start and offline logical native Chromium picker tests passed. Full UI umbrella #43392389783 later failed an unrelated unchanged public preview MUTE/SOLO/PFL assertion; documented honestly, not called green.

    New verified installer production requested: Alpha.21 candidate source 1eb8e622d4bd18937b1908d33fc229d578423b10 via Windows release workflow #43393624582. Old FAT/Alpha.19/Alpha.20 MUST NOT be recommended as fixed. Publish and user-test Alpha.21 only after exact-SHA build/PE/embedded GUI/Inno/checksums/release assets pass. Physical Hi-Z/ASIO audio still requires real hardware FAT.

  4. masarray commented on Nov 13, 2026

    @masarray
    OwnerAuthor

    Guitar FX Picker P0 delivery — verified Windows Alpha.21 PUBLISHED (13 Nov 2026)

    Official exact-source release: v0.5.0-alpha.21, source/tag 1eb8e622d4bd18937b1908d33fc229d578423b10; verified via Windows release workflow #43393624582 COMPLETED/SUCCESS. Inno installer build, install/upgrade/uninstall, native package checks and asset hashes passed. Verified release asset names and digests: ArSonMix-v0.5.0-alpha.21-Windows-x64-Setup.exe SHA256 ab92c718a0eb94350a86d150e3766410f553d7c510948639d4b27571e7f64c70 and portable ZIP SHA256 4393fb943dd771d113e1bd3e1d799572290a71102599c1150eb8e4b86d57ab83.

    At this exact SHA: compiled GUI composer places catalog-derived real Guitar FX first in BUILT-IN FX, never under VST3; native GuitarRigProcessor registry + bridge identity verified. PR #657 merged at 54702c2796b6713dc6a936276b9c5c11b0f97135. Old g03ba FAT, Alpha.19 and Alpha.20 must not be recommended for this first-screen visibility issue. Hardware/ASIO sound still not field-qualified, and the unrelated public Inter V7 UI smoke failure remains separately documented.

    Owner next validation: quit all old portable/installed ArSonMix instances, install Alpha.21 or unpack its portable ZIP to a new folder, verify top of BUILT-IN FX shows Guitar FX Rig immediately; then select it and capture native ACK/editor/real sound. If absent, report the Alpha.21 title build SHA and launch path rather than accepting source-only confirmation.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Metadata

Metadata

Assignees

No one assigned

    Projects

    No projects

      Milestone

      No milestone

      Relationships

      None yet

      Development

      No branches or pull requests

      Issue actions