Skip to content
Merged
Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
92 commits
Select commit Hold shift + click to select a range
62f7b51
feat(guitar-fx): add deterministic original hardware PNG asset renderer
masarray Nov 12, 2026
61ab718
feat(guitar-fx): add eight original layered realistic PNG hardware as…
masarray Nov 12, 2026
51a677b
docs(guitar-fx): lock professional UX workflow, realtime ownership an…
masarray Nov 12, 2026
ccaa7fd
feat(guitar-fx): add local asset-backed single-focus UX prototype and…
masarray Nov 12, 2026
4e0e916
test(guitar-fx): assert complete PNG structure, render determinism an…
masarray Nov 12, 2026
739430e
feat(guitar-fx): complete first-party pedal skins for all eight chain…
masarray Nov 12, 2026
0747e2c
feat(guitar-fx): complete pedal art set, asset tests and local UX study
masarray Nov 12, 2026
bb6c3ee
ci(guitar-fx): scope lightweight deterministic PNG verification to gu…
masarray Nov 12, 2026
e0c8398
feat(guitar-fx): establish bounded native program model without chang…
masarray Nov 12, 2026
906ea36
test(guitar-fx): verify stable IDs, bounded parameters and fail-close…
masarray Nov 12, 2026
659e95d
ci(guitar-fx): qualify bounded C++ program model with cheap path-scop…
masarray Nov 12, 2026
e21ce73
fix(guitar-fx): keep scoped asset and program-model paths unique in CI
masarray Nov 12, 2026
d160885
test(guitar-fx): assert dynamic cabinet asset identity rather than li…
masarray Nov 12, 2026
8885635
feat(guitar-fx): add bounded native gate/drive/amp and original cabin…
masarray Nov 12, 2026
17e9edd
test(guitar-fx): verify wet PCM, cabinet latency/bypass and failed-pr…
masarray Nov 12, 2026
ca4fd8e
ci(guitar-fx): run real wet PCM and cabinet FIR tests on cheap Linux …
masarray Nov 12, 2026
1d30d55
feat(guitar-fx): prepare serializable native GuitarRigProcessor for e…
masarray Nov 12, 2026
cb5e227
feat(guitar-fx): register one native guitar insert in generic existin…
masarray Nov 12, 2026
84f7f49
test(guitar-fx): native registry insertion, true wet PCM, state round…
masarray Nov 12, 2026
c548d6e
fix(guitar-fx): use explicit algorithm header for native processor pe…
masarray Nov 12, 2026
06a3f7c
feat(guitar-fx): prepared SPSC program switching with 128-frame cross…
masarray Nov 13, 2026
e1878b3
feat(guitar-fx): use existing editor host and preserve native program…
masarray Nov 13, 2026
f6755a3
feat(guitar-fx): native focus editor with original PNG hardware skins…
masarray Nov 13, 2026
fcbfa92
feat(guitar-fx): enable existing FX editor host to create native hard…
masarray Nov 13, 2026
d3d5323
build(guitar-fx): embed original hardware PNG resources in existing J…
masarray Nov 13, 2026
380d067
test(guitar-fx): verify callback ACK, accepted save, live switch cros…
masarray Nov 13, 2026
a7a40e2
fix(guitar-fx): reject programs not represented by the first-sound fo…
masarray Nov 13, 2026
a2516ff
fix(guitar-fx): align queued and restored DSP programs with supported…
masarray Nov 13, 2026
065a45a
feat(guitar-fx): add focused factory tone browser and true live input…
masarray Nov 13, 2026
143c427
fix(guitar-fx): show truthful Custom preset on restored or edited DSP…
masarray Nov 13, 2026
816d399
fix(guitar-fx): align first sound with actual Clean Studio preset sel…
masarray Nov 13, 2026
df56da6
merge: reconcile Guitar FX native editor and PCM work with latest app…
masarray Nov 13, 2026
d9e5fbf
fix(guitar-fx): match JUCE BinaryData generated symbols for hyphenate…
masarray Nov 13, 2026
ef553d9
test(guitar-fx): pin JUCE binary asset symbol naming and prevent anot…
masarray Nov 13, 2026
172a18a
fix(guitar-fx): serialize crossfades to prevent overlapping mid-trans…
masarray Nov 13, 2026
e5dc736
feat(guitar-fx): show distinct original gate and overdrive pedal hard…
masarray Nov 13, 2026
4a03f42
test(guitar-fx): verify direct JUCE binary symbols for both gate and …
masarray Nov 13, 2026
67b526a
merge: preserve latest approved mixer and reconcile GFX compile/resou…
masarray Nov 13, 2026
f4790ae
fix(guitar-fx): apply live edits inside PCM callback and fence outsta…
masarray Nov 13, 2026
a2969ee
feat(guitar-fx): preserve accepted tone on editor reopen and define r…
masarray Nov 13, 2026
c40c661
merge(guitar-fx): reconcile latest approved mixer without overlapping…
masarray Nov 13, 2026
d3024ef
feat(guitar-fx): establish single native factory tone catalog and exa…
masarray Nov 13, 2026
4b3b277
refactor(guitar-fx): centralize factory tones in native DSP and editor
masarray Nov 13, 2026
5ce2778
feat(guitar-fx): add durable A/B tone banks with versioned v2 state a…
masarray Nov 13, 2026
788e0ad
feat(guitar-fx): add native A/B performance compare and single-source…
masarray Nov 13, 2026
b7d462d
test(guitar-fx): qualify A/B persistence, native v1 migration, invali…
masarray Nov 13, 2026
beda144
test(guitar-fx): await serialized first crossfade before confirming A…
masarray Nov 13, 2026
11802e5
test(guitar-fx): require exact factory-tone identity and custom state…
masarray Nov 13, 2026
978777b
test(guitar-fx): reflect durable A/B native reopen contract instead o…
masarray Nov 13, 2026
17a6ce1
fix(guitar-fx): commit final in-flight tone controls on editor close …
masarray Nov 13, 2026
df272df
fix(guitar-fx): preserve target A/B identity when device restart canc…
masarray Nov 13, 2026
87eba6b
fix(guitar-fx): permit tone editing while rack bypass is active witho…
masarray Nov 13, 2026
ad4d41a
test(guitar-fx): verify tone edits under full bypass and durable nati…
masarray Nov 13, 2026
3c4b6bf
docs(guitar-fx): ground reusable UI, A/B session and future NAM/IR ar…
masarray Nov 13, 2026
34de0c7
perf(guitar-fx): halve cabinet FIR multiplies using symmetric 65-tap …
masarray Nov 13, 2026
4e1303f
fix(guitar-fx): make symmetric FIR coefficient pairs bit-identical be…
masarray Nov 13, 2026
b3117c2
test(guitar-fx): prove symmetric FIR, all-rate latency and block-part…
masarray Nov 13, 2026
75f2a27
docs(guitar-fx): add A/B session migration and real-world FIR/ASIO ac…
masarray Nov 13, 2026
2f7c5ea
merge(guitar-fx): preserve latest approved mixer while reconciling A/…
masarray Nov 13, 2026
2136aa9
fix(guitar-fx): inherit compatible amplifier and cabinet history acro…
masarray Nov 13, 2026
15cd916
fix(guitar-fx): drain A/B while fully bypassed and crossfade from war…
masarray Nov 13, 2026
55493e2
test(guitar-fx): verify warm-history retention across amp tweaks and …
masarray Nov 13, 2026
35235ae
test(guitar-fx): prove bypass amid crossfade cannot strand next A/B t…
masarray Nov 13, 2026
eef27de
fix(guitar-fx): discard stale guitar FIR tails on fully bypassed to w…
masarray Nov 13, 2026
76a1342
test(guitar-fx): assert old cabinet delay cannot replay after full ra…
masarray Nov 13, 2026
198a694
fix(guitar-fx): flush JUCE legacy v1 state fixture before validating …
masarray Nov 13, 2026
9326b38
perf(guitar-fx): decode hardware PNG skins once per app instead of ev…
masarray Nov 13, 2026
12c0035
test(guitar-fx): require single native PNG decode cache across floati…
masarray Nov 13, 2026
bd6a356
docs(guitar-fx): capture M1.5 red FAT RCA and M1.6 realtime continuit…
masarray Nov 13, 2026
56b9dad
merge(guitar-fx): carry M1.6 realtime fixes atop latest approved /pre…
masarray Nov 13, 2026
9a5983a
feat(guitar-fx): stereo-linked guitar noise gate with real hold and r…
masarray Nov 13, 2026
a96f730
feat(guitar-fx): expose meaningful gate Threshold dB, Hold ms and Rel…
masarray Nov 13, 2026
c9f0d8d
test(guitar-fx): validate stereo-linked gain and audible gate hold/re…
masarray Nov 13, 2026
42323ea
test(guitar-fx): add high-gain aliasing baseline, linked-gate GUI con…
masarray Nov 13, 2026
0be0681
chore(guitar-fx): make stereo-linked gate portable and log alias base…
masarray Nov 13, 2026
bab73da
merge(guitar-fx): sync stereo-linked gate and aliasing benchmark with…
masarray Nov 13, 2026
a89de68
feat(guitar-fx): add prepared low-latency polyphase 2x nonlinear anti…
masarray Nov 13, 2026
8788ebb
feat(guitar-fx): route Drive/Amp through fixed-PDC 2x polyphase antia…
masarray Nov 13, 2026
8e6f094
test(guitar-fx): account for exact 16+32 sample 2x anti-aliasing and …
masarray Nov 13, 2026
d1ae693
test(guitar-fx): gate 2x alias reduction and report non-gating CPU fo…
masarray Nov 13, 2026
0a70708
fix(guitar-fx): keep latency-matched clean path warm across amp and d…
masarray Nov 13, 2026
a773a6e
docs/test(guitar-fx): qualify 40 dB alias reduction, fixed 48-frame P…
masarray Nov 13, 2026
7474182
fix(guitar-fx): expose installed Guitar FX Rig in approved native qui…
masarray Nov 13, 2026
0bea84e
test(guitar-fx): assert Guitar FX visible, searchable and selectable …
masarray Nov 13, 2026
0350a79
test(guitar-fx): verify initial picker before catalog and preserve pe…
masarray Nov 13, 2026
2c2bc7d
test(guitar-fx): bind exact Guitar Rig native descriptor to approved …
masarray Nov 13, 2026
2a3d6ca
fix(test): use exact catalog/intent assertions for GFX user-visible p…
masarray Nov 13, 2026
5b68eea
merge(guitar-fx): reconcile real Guitar FX picker and native DSP with…
masarray Nov 13, 2026
2fab34a
test(guitar-fx): isolate pending picker insertion at end of offline m…
masarray Nov 13, 2026
03ba6ec
merge(guitar-fx): bring native FX Picker, live DSP and Chromium regre…
masarray Nov 13, 2026
898d903
merge(guitar-fx): preserve main V66 WIRE motion while qualifying Guit…
masarray Nov 13, 2026
c904034
merge(guitar-fx): preserve approved startup foreground P0 in field-pr…
masarray Nov 13, 2026
File filter

Filter by extension

Filter by extension


Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
47 changes: 47 additions & 0 deletions .github/workflows/guitar-fx-assets.yml
Original file line number Diff line number Diff line change
@@ -0,0 +1,47 @@
name: Guitar FX assets — fast, path-scoped
# No Chromium, MSVC, audio device, installer, npm packages or external downloads.
# Only this feature's own asset and UX-study paths trigger the contract.
on:
pull_request:
paths:
- 'design-references/guitar-fx/**'
- 'docs/guitar-fx/**'
- 'scripts/build_guitar_fx_assets.mjs'
- 'engine/builtin_fx/guitar/**'
- 'tests/guitar_fx_program_model_test.cpp'
- 'tests/guitar_fx_core_pcm_test.cpp'
- 'tests/guitar_fx_assets_contract.test.mjs'
- '.github/workflows/guitar-fx-assets.yml'
push:
branches: [main]
paths:
- 'design-references/guitar-fx/**'
- 'docs/guitar-fx/**'
- 'scripts/build_guitar_fx_assets.mjs'
- 'engine/builtin_fx/guitar/**'
- 'tests/guitar_fx_program_model_test.cpp'
- 'tests/guitar_fx_core_pcm_test.cpp'
- 'tests/guitar_fx_assets_contract.test.mjs'
- '.github/workflows/guitar-fx-assets.yml'
permissions:
contents: read
concurrency:
group: guitar-fx-assets-${{ github.event.pull_request.number || github.ref }}
cancel-in-progress: true
jobs:
original-hardware-assets:
name: Validate reproducible PNGs and truthful editor study
runs-on: ubuntu-latest
timeout-minutes: 3
steps:
- uses: actions/checkout@v4
- name: Verify original PNG structure, bounds and deterministic output
run: node --test tests/guitar_fx_assets_contract.test.mjs
- name: Verify bounded C++ program model without JUCE or Windows
run: |
c++ -std=c++20 -O2 -Wall -Wextra -Werror -pedantic tests/guitar_fx_program_model_test.cpp -o /tmp/guitar-fx-program-model-test
/tmp/guitar-fx-program-model-test
- name: Verify wet PCM, 2x antialias and fixed 48-sample PDC without JUCE
run: |
c++ -std=c++20 -O2 -Wall -Wextra -Werror -pedantic tests/guitar_fx_core_pcm_test.cpp -o /tmp/guitar-fx-core-pcm-test
/tmp/guitar-fx-core-pcm-test
9 changes: 8 additions & 1 deletion CMakeLists.txt
Original file line number Diff line number Diff line change
Expand Up @@ -77,8 +77,14 @@ message(STATUS "${ARMIX_GUI_BUNDLE_LOG}")
file(GLOB_RECURSE ARMIX_APPROVED_GUI_BINARIES CONFIGURE_DEPENDS
"${ARMIX_APPROVED_GUI_DIR}/assets/*")
list(SORT ARMIX_APPROVED_GUI_BINARIES)
# Original Guitar FX artwork is embedded ONLY for the installed JUCE
# plugin editor; it never becomes a second /preview/ or runtime file path.
file(GLOB ARMIX_GUITAR_SKIN_PNGS CONFIGURE_DEPENDS
"${CMAKE_CURRENT_SOURCE_DIR}/design-references/guitar-fx/assets/*.png")
list(SORT ARMIX_GUITAR_SKIN_PNGS)
juce_add_binary_data(ARMixAssets SOURCES
"${ARMIX_APPROVED_GUI_DIR}/index.html" ${ARMIX_APPROVED_GUI_BINARIES}
${ARMIX_GUITAR_SKIN_PNGS}
"${ARMIX_BRAND_DIR}/arsonmix-256.png")
target_include_directories(ARMixConsole PRIVATE "${ARMIX_APPROVED_GUI_DIR}")

Expand Down Expand Up @@ -133,7 +139,8 @@ target_compile_definitions(ARMixConsole PRIVATE
JUCE_PLUGINHOST_VST3=1
JUCE_APPLICATION_NAME_STRING="AR MIX Studio"
JUCE_APPLICATION_VERSION_STRING="${ARMIX_APP_VERSION}"
ARMIX_BUILD_SOURCE_SHA="${ARMIX_BUILD_SOURCE_SHA}")
ARMIX_BUILD_SOURCE_SHA="${ARMIX_BUILD_SOURCE_SHA}"
ARMIX_GFX_EMBED_PNG_SKINS=1)
if(WIN32)
# Windows retains its proven ASIO-first / WASAPI / static WebView2 distribution.
# Never link Windows loader or sound APIs into macOS/Linux builds.
Expand Down
31 changes: 31 additions & 0 deletions design-references/guitar-fx/README.md
Original file line number Diff line number Diff line change
@@ -0,0 +1,31 @@
# Guitar FX editor design study and original hardware assets

**Not the ArSonMix published mixer. Not an audio processor. No native hardware or PCM claims.**

This folder is an internal visual/interaction study for a future **single native Guitar FX insert** hosted by the already-approved ArSonMix /preview/ mixer. Its hardware-looking PNGs are original procedural drawings, not photos, and must undergo visual review before product promotion. Core contract: [Guitar FX Foundation](../../docs/guitar-fx/GUITAR_FX_FOUNDATION_20261113.md).

## Try the workflow locally

1. Clone this branch, then open `design-references/guitar-fx/editor-prototype.html` in Chrome/Edge.
2. Select Clean/Blues/Crunch/Rock/Metal/Ambient in the preset library; browser can collapse.
3. Choose a chain block to focus its *only* hardware editor; use its power dot to bypass independently; drag movable pedals to reorder while AMP/CAB remain paired.
4. Move knobs vertically or use the accessible range controls; switch A/B; download *design-state* JSON; open Tuner to see the explicit no-audio placeholder.
5. No controls send native commands or generate audio. The CAB mic position is a placeholder only; no fake acoustic claim or live metering.

## Rebuild PNGs and verify

```sh
node scripts/build_guitar_fx_assets.mjs
node --test tests/guitar_fx_assets_contract.test.mjs
```

Requires Node 18+; uses only built-in JavaScript, no image download, UI screenshot, paid fonts, external brands or pipeline dependencies. The renderer generates all PNG bitmaps byte-identically. The original indexed transparent assets are deliberately compact; CSS/HTML owns legends, values, focus, hit targets and state, not pixels. This preserves accessibility and translation potential.

## Design integration constraints

- Exactly one authoritative /preview/ console and one JUCE native graph; this file is not deployed as a competing mixer GUI.
- Integration must use the existing FX editor owner, NativeBuiltInFx registry and accepted snapshot path; coordinate with active #605 FX editor and #604 toolbar PR.
- PNG artwork is decorative and never grounds live meters, model tone, impulse responses or physical signal routes.
- Do not ship NAM models, amplifier capture files or third-party IRs without separately confirmed terms and exact approved binaries.

See original image files under [assets](assets/) and source generator at [scripts/build_guitar_fx_assets.mjs](../../scripts/build_guitar_fx_assets.mjs).
Loading
Sorry, something went wrong. Reload?
Sorry, we cannot display this file.
Sorry, this file is invalid so it cannot be displayed.
Loading
Sorry, something went wrong. Reload?
Sorry, we cannot display this file.
Sorry, this file is invalid so it cannot be displayed.
Loading
Sorry, something went wrong. Reload?
Sorry, we cannot display this file.
Sorry, this file is invalid so it cannot be displayed.
Binary file added design-references/guitar-fx/assets/led-active.png
Loading
Sorry, something went wrong. Reload?
Sorry, we cannot display this file.
Sorry, this file is invalid so it cannot be displayed.
Loading
Sorry, something went wrong. Reload?
Sorry, we cannot display this file.
Sorry, this file is invalid so it cannot be displayed.
Loading
Sorry, something went wrong. Reload?
Sorry, we cannot display this file.
Sorry, this file is invalid so it cannot be displayed.
Loading
Sorry, something went wrong. Reload?
Sorry, we cannot display this file.
Sorry, this file is invalid so it cannot be displayed.
Loading
Sorry, something went wrong. Reload?
Sorry, we cannot display this file.
Sorry, this file is invalid so it cannot be displayed.
Binary file added design-references/guitar-fx/assets/pedal-gate.png
Loading
Sorry, something went wrong. Reload?
Sorry, we cannot display this file.
Sorry, this file is invalid so it cannot be displayed.
Loading
Sorry, something went wrong. Reload?
Sorry, we cannot display this file.
Sorry, this file is invalid so it cannot be displayed.
Loading
Sorry, something went wrong. Reload?
Sorry, we cannot display this file.
Sorry, this file is invalid so it cannot be displayed.
Loading
Sorry, something went wrong. Reload?
Sorry, we cannot display this file.
Sorry, this file is invalid so it cannot be displayed.
Loading
Loading