Skip to content

fix(gui): restore approved v9 MUTE/SOLO/PFL in Main Mix and SOF - #612

Merged
masarray merged 7 commits into
mainfrom
fix/main-mix-v9-mute-solo-pfl-20261113
Nov 12, 2026
Merged

masarray merged 7 commits into
mainfrom
fix/main-mix-v9-mute-solo-pfl-20261113

Conversation

@masarray

Copy link
Copy Markdown
Owner

P0 user-visible regression

PR #610 landed the approved PFL FontMatched sprite, but conditioned the third key on sofEnabled && audio. Opening ordinary /preview/ therefore still showed MUTE / SOLO / PRE-POST. This is exactly the user's reported failure.

Fix

  • Display MUTE / SOLO / PFL by default in Main Mix and in SOF, for every non-MASTER strip; MASTER retains two centered keys.
  • Reuse exactly the existing approved v9 MUTE/SOLO atlas + PFL OFF/ON sprite, unchanged. No new SVG/CSS illustration, size, bezel, or font.
  • Keep per-EdgeId PRE/POST in existing WIRE Route Inspector; remove the misleading channel-global send tap key and its bulk-send click handler. A contextual PRE/POST control is already implemented on separate SOF draft feat(gui): contextual GAIN/FX RACK and safe Sends-on-Faders console workflow #604 and inherited by advanced 8D-SonKu: native binaural DSP, studio orbit GUI, smooth motion and headphone FAT #606, which must forward-port this UI decision before integration.
  • Preserve browser-only cue selection when switching MAIN <-> SOF; do not feed this into MAIN. Native PFL remains disabled/fail-closed until a true acknowledged independent MONITOR L/R graph exists.
  • Update contract and source/Chromium tests to catch the initial default-Main-Mix regression, sprite frame/shadow/parity and no accidental WIRE tap mutation.

Verification

No claims of native PFL audio or hardware FAT. Source assertions and Chromium smoke are included and need exact-SHA qualification. Only minimal GUI CI is appropriate; avoid costly Windows audio builds for this asset/layout change.

Concurrency

@chatgpt-codex-connector

chatgpt-codex-connector Bot commented Nov 12, 2026 •

Copy link
Copy Markdown
Codex Review Summary: ✅ Completed

This comment shows the latest Codex review activity on this pull request.

Review Status Commit Review trigger
📝 Code Review ✅ Completed 2026-11-12T23:38:46.180440Z 567fdd2 PR opened
ℹ️ About Codex in GitHub

Your team has set up Codex to review pull requests in this repo. Reviews are triggered when you

  • Open a pull request for review
  • Mark a draft as ready
  • Comment "@codex review" or "@codex security review".

Codex reacts with 👀 while any review is running, comments if it has suggestions, and reacts with 👍 once all reviews finish with no findings.

@cloudflare-workers-and-pages

Copy link
Copy Markdown

Deploying arsonmix with  Cloudflare Pages  Cloudflare Pages

Latest commit: 872940e
Status: ✅  Deploy successful!
Preview URL: https://44309b8a.arsonmix.pages.dev
Branch Preview URL: https://fix-main-mix-v9-mute-solo-pf.arsonmix.pages.dev

View logs

@masarray
masarray merged commit cf49c56 into main Nov 12, 2026
6 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant