Skip to content

V60 GUI: tactile 0 dB fader, taller travel, elastic WIRE and bright full-length selection - #613

Merged
masarray merged 9 commits into
mainfrom
fix/gui-fader-unity-wire-tactile-20261113
Nov 13, 2026
Merged

masarray merged 9 commits into
mainfrom
fix/gui-fader-unity-wire-tactile-20261113

Conversation

@masarray

Copy link
Copy Markdown
Owner

Operator request (13 Nov 2026)

From the actual approved /preview/ screenshot: fader too short; no 0 dB tactile snap; WIRE ripple looks 1.6 s slow-motion and attenuates before reaching IN; clicking cable draws a faint partial outer glow instead of illuminating the actual jacket end-to-end.

Exact source correction

  • Physical unity detent on the existing pointer-mapped fader: capture within 7 CSS px, release outside 12 px, one exact 0 dB value, Alt bypass, keyboard 0.1 dB precision unchanged. Final pointer release emits an explicit change to the current GUI→native ACK/readback contract.
  • Taller faders via one --fader-fixed-h responsive token for input, bus, FX, pinned MASTER and section rail (bounded on short screens); retain approved hardware cap/bitmap, calibrations, mixer width and FX rack elastic workspace.
  • Fast, complete cable ripple on the existing source-colored SVG path: 460 ms OUT→IN packet + 190 ms elastic settle, no distance-fading halfway and no idle RAF or graph mutation. Fixed physical endpoints, 56 sample bounded path, reduced-motion fail-safe.
  • Correct selected cable: transparent hit curve stays transparent; the real line becomes 5.6px thick and brightened by mixing its own original color with white, continuous all the way to the plugs. No outer halo, partial dash or SVG clone.
  • Existing WIRE graph, EdgeId, cue, FX, DSP, and native callback untouched.

Proof

New tests/pages_v60_fader_wire_tactile_smoke.py source and Playwright gate covering 640×1005, 1366×768, 1680×900, source/Master/rail alignment, 0 dB hysteresis and bypass, WIRE impulse geometry, colored full-length selected stroke and no browser JS exceptions. PR runs cheap no-browser contract plus one scoped Chromium gate; full existing Chromium after main merge. Screenshots uploaded to the existing short-lived artifact.

Concurrent integration

Do not overwrite unmerged #604/#606 SOF/SonKu sources. Their forward-port must retain this published fader and WIRE behavior together with approved v9 MUTE–SOLO–PFL. No Windows ASIO/audio FAT claim from GUI smoke.

@chatgpt-codex-connector

chatgpt-codex-connector Bot commented Nov 13, 2026 •

Copy link
Copy Markdown
Codex Review Summary: ✅ Completed

This comment shows the latest Codex review activity on this pull request.

Review Status Commit Review trigger
📝 Code Review ✅ Completed 2026-11-13T00:30:50.267836Z 10662af PR opened
ℹ️ About Codex in GitHub

Your team has set up Codex to review pull requests in this repo. Reviews are triggered when you

  • Open a pull request for review
  • Mark a draft as ready
  • Comment "@codex review" or "@codex security review".

Codex reacts with 👀 while any review is running, comments if it has suggestions, and reacts with 👍 once all reviews finish with no findings.

@cloudflare-workers-and-pages

cloudflare-workers-and-pages Bot commented Nov 13, 2026 •

Copy link
Copy Markdown

Deploying arsonmix with  Cloudflare Pages  Cloudflare Pages

Latest commit: ea01301
Status: ✅  Deploy successful!
Preview URL: https://5e60b064.arsonmix.pages.dev
Branch Preview URL: https://fix-gui-fader-unity-wire-tac.arsonmix.pages.dev

View logs

@chatgpt-codex-connector chatgpt-codex-connector Bot left a comment

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

💡 Codex Review

Here are some automated review suggestions for this pull request.

Reviewed commit: 10662afcea

ℹ️ About Codex in GitHub

Your team has set up Codex to review pull requests in this repo. Reviews are triggered when you

  • Open a pull request for review
  • Mark a draft as ready
  • Comment "@codex review".

If Codex has suggestions, it will comment; otherwise it will react with 👍.

Codex can also answer questions or update the PR. Try commenting "@codex address that feedback".

const max=Number(input.max)||10,min=Number(input.min)||-60;
const frac=Math.max(0,Math.min(1,(ev.clientY-travel.top)/travel.height));
const gain=Math.round((max-(max-min)*frac)*10)/10;
let gain=Math.round((max-(max-min)*frac)*10)/10;

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

P1 Badge Update the native fader hooks alongside the pointer handler

Every native GUI bundle build now fails because scripts/build_approved_native_gui.py still matches the exact const gain=... statement in NATIVE_EVENT_HOOKS; changing it to let makes native_html() raise ValueError: Native-only M2 control hook anchor drift. The new release handling also breaks its separate anchor requiring releasePointerCapture immediately after clearing faderGesture. Confirmed by running tests/approved_native_gui_bundle_test.py, which reports two errors. Update both native hooks together with this handler, preserving the native taper and a single committed change notification, so the shared approved GUI remains packageable.

AGENTS.md reference: AGENTS.md:L149-L149

Useful? React with 👍 / 👎.

Comment on lines +416 to +418
.console-body{--fader-fixed-h:clamp(270px,35vh,390px)}
@media(max-height:850px){
.console-body{--fader-fixed-h:clamp(225px,37vh,310px)}

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

P2 Badge Apply the taller travel through the active layout authority

In the assembled /preview/, these new height declarations never take effect: mixer-chrome-material.css:795–797 already sets --fader-fixed-h:var(--v13-fader-h)!important, which overrides all three new non-important declarations. Additionally, scripts/compose_operator_ux.py installs a layout bootstrap that computes --v13-fader-h from the existing half-console budget and writes it as an inline important property. Consequently, this change leaves the actual source/Master/rail travel unchanged despite the new source contract passing. Update the active shared height calculation and its FX-space budget rather than adding an overridden token.

AGENTS.md reference: AGENTS.md:L140-L140

Useful? React with 👍 / 👎.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant