Repository navigation
V60 GUI: tactile 0 dB fader, taller travel, elastic WIRE and bright full-length selection - #613
Conversation
…ith selected jacket hue
…k selected jacket
…ive strip and rail height
…coil and bright selected jacket
…l main qualification
Codex Review Summary: ✅ CompletedThis comment shows the latest Codex review activity on this pull request.
ℹ️ About Codex in GitHubYour team has set up Codex to review pull requests in this repo. Reviews are triggered when you
Codex reacts with 👀 while any review is running, comments if it has suggestions, and reacts with 👍 once all reviews finish with no findings. |
Deploying arsonmix with
|
| Latest commit: |
ea01301
|
| Status: | ✅ Deploy successful! |
| Preview URL: | https://5e60b064.arsonmix.pages.dev |
| Branch Preview URL: | https://fix-gui-fader-unity-wire-tac.arsonmix.pages.dev |
There was a problem hiding this comment.
💡 Codex Review
Here are some automated review suggestions for this pull request.
Reviewed commit: 10662afcea
ℹ️ About Codex in GitHub
Your team has set up Codex to review pull requests in this repo. Reviews are triggered when you
- Open a pull request for review
- Mark a draft as ready
- Comment "@codex review".
If Codex has suggestions, it will comment; otherwise it will react with 👍.
Codex can also answer questions or update the PR. Try commenting "@codex address that feedback".
| const max=Number(input.max)||10,min=Number(input.min)||-60; | ||
| const frac=Math.max(0,Math.min(1,(ev.clientY-travel.top)/travel.height)); | ||
| const gain=Math.round((max-(max-min)*frac)*10)/10; | ||
| let gain=Math.round((max-(max-min)*frac)*10)/10; |
There was a problem hiding this comment.
Update the native fader hooks alongside the pointer handler
Every native GUI bundle build now fails because scripts/build_approved_native_gui.py still matches the exact const gain=... statement in NATIVE_EVENT_HOOKS; changing it to let makes native_html() raise ValueError: Native-only M2 control hook anchor drift. The new release handling also breaks its separate anchor requiring releasePointerCapture immediately after clearing faderGesture. Confirmed by running tests/approved_native_gui_bundle_test.py, which reports two errors. Update both native hooks together with this handler, preserving the native taper and a single committed change notification, so the shared approved GUI remains packageable.
AGENTS.md reference: AGENTS.md:L149-L149
Useful? React with 👍 / 👎.
| .console-body{--fader-fixed-h:clamp(270px,35vh,390px)} | ||
| @media(max-height:850px){ | ||
| .console-body{--fader-fixed-h:clamp(225px,37vh,310px)} |
There was a problem hiding this comment.
Apply the taller travel through the active layout authority
In the assembled /preview/, these new height declarations never take effect: mixer-chrome-material.css:795–797 already sets --fader-fixed-h:var(--v13-fader-h)!important, which overrides all three new non-important declarations. Additionally, scripts/compose_operator_ux.py installs a layout bootstrap that computes --v13-fader-h from the existing half-console budget and writes it as an inline important property. Consequently, this change leaves the actual source/Master/rail travel unchanged despite the new source contract passing. Update the active shared height calculation and its FX-space budget rather than adding an overridden token.
AGENTS.md reference: AGENTS.md:L140-L140
Useful? React with 👍 / 👎.
Operator request (13 Nov 2026)
From the actual approved /preview/ screenshot: fader too short; no 0 dB tactile snap; WIRE ripple looks 1.6 s slow-motion and attenuates before reaching IN; clicking cable draws a faint partial outer glow instead of illuminating the actual jacket end-to-end.
Exact source correction
changeto the current GUI→native ACK/readback contract.--fader-fixed-hresponsive token for input, bus, FX, pinned MASTER and section rail (bounded on short screens); retain approved hardware cap/bitmap, calibrations, mixer width and FX rack elastic workspace.Proof
New
tests/pages_v60_fader_wire_tactile_smoke.pysource and Playwright gate covering 640×1005, 1366×768, 1680×900, source/Master/rail alignment, 0 dB hysteresis and bypass, WIRE impulse geometry, colored full-length selected stroke and no browser JS exceptions. PR runs cheap no-browser contract plus one scoped Chromium gate; full existing Chromium after main merge. Screenshots uploaded to the existing short-lived artifact.Concurrent integration
Do not overwrite unmerged #604/#606 SOF/SonKu sources. Their forward-port must retain this published fader and WIRE behavior together with approved v9 MUTE–SOLO–PFL. No Windows ASIO/audio FAT claim from GUI smoke.