Repository navigation
V60: repair native WebView2 fader seam, preserve tapered unity snap and exactly one ACK - #618
Merged
Merged
Conversation
Codex Review Summary: ✅ CompletedThis comment shows the latest Codex review activity on this pull request.
ℹ️ About Codex in GitHubYour team has set up Codex to review pull requests in this repo. Reviews are triggered when you
Codex reacts with 👀 while any review is running, comments if it has suggestions, and reacts with 👍 once all reviews finish with no findings. |
… stale synthetic event
This was referenced Nov 13, 2026
Merged
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Follow-up to #613 and #616 after main Chromium Stage B caught a real native assembly failure:
Native-only M2 control hook anchor drift. The GUI now useslet gainfor tactile 0dB detent, whereas native HTML assembler still matched the oldconst gainfragment. The native pointerup bridge also still expected an older release handler, but approved v60 source now commits viahandleField(type:'change')already.let gainand preserve the calibrated non-linear fader law.faderPercent(0)(77% on channel strip), not the public reference's linear 0 position. SOF uses its own range.handleFieldinterception to ACK/readback.native_v60_fader_assembly_contract.pyin PR quick lane to verify public↔native exact HTML reversal, tapered unity, one release, no duplicated events.No DSP routing, JUCE audio engine, plugin instances or hardware safety changed. This must pass first before UI main gate and Pages publishing can complete. Exact user-approved physical GUI preserved.