Skip to content

V60: repair native WebView2 fader seam, preserve tapered unity snap and exactly one ACK - #618

Merged
masarray merged 5 commits into
mainfrom
fix/v60-native-fader-assembler-20261113
Nov 13, 2026
Merged

masarray merged 5 commits into
mainfrom
fix/v60-native-fader-assembler-20261113

Conversation

@masarray

Copy link
Copy Markdown
Owner

Follow-up to #613 and #616 after main Chromium Stage B caught a real native assembly failure: Native-only M2 control hook anchor drift. The GUI now uses let gain for tactile 0dB detent, whereas native HTML assembler still matched the old const gain fragment. The native pointerup bridge also still expected an older release handler, but approved v60 source now commits via handleField(type:'change') already.

  • Update the exact native adapter hook to replace let gain and preserve the calibrated non-linear fader law.
  • Map unity detent to native faderPercent(0) (77% on channel strip), not the public reference's linear 0 position. SOF uses its own range.
  • Remove the duplicate native-only pointerup synthetic change injection: the source release now dispatches exactly once through the authoritative native-only handleField interception to ACK/readback.
  • Add cheap native_v60_fader_assembly_contract.py in PR quick lane to verify public↔native exact HTML reversal, tapered unity, one release, no duplicated events.

No DSP routing, JUCE audio engine, plugin instances or hardware safety changed. This must pass first before UI main gate and Pages publishing can complete. Exact user-approved physical GUI preserved.

@chatgpt-codex-connector

chatgpt-codex-connector Bot commented Nov 13, 2026 •

Copy link
Copy Markdown
Codex Review Summary: ✅ Completed

This comment shows the latest Codex review activity on this pull request.

Review Status Commit Review trigger
📝 Code Review ✅ Completed 2026-11-13T00:48:32.144537Z d482564 PR opened
ℹ️ About Codex in GitHub

Your team has set up Codex to review pull requests in this repo. Reviews are triggered when you

  • Open a pull request for review
  • Mark a draft as ready
  • Comment "@codex review" or "@codex security review".

Codex reacts with 👀 while any review is running, comments if it has suggestions, and reacts with 👍 once all reviews finish with no findings.

@cloudflare-workers-and-pages

cloudflare-workers-and-pages Bot commented Nov 13, 2026 •

Copy link
Copy Markdown

Deploying arsonmix with  Cloudflare Pages  Cloudflare Pages

Latest commit: 8d30462
Status:⚡️  Build in progress...

View logs

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant