Repository navigation
V60 final geometry: grow real fader by spending spare FX height in single layout allocator - #619
Merged
Merged
Conversation
…single V29/V60 JS authority
…owns actual height
… controls and no overflow
Codex Review Summary: ❌ FailedThis comment shows the latest Codex review activity on this pull request.
ℹ️ About Codex in GitHubYour team has set up Codex to review pull requests in this repo. Reviews are triggered when you
Codex reacts with 👀 while any review is running, comments if it has suggestions, and reacts with 👍 once all reviews finish with no findings. |
|
You have reached your Codex usage limits for code reviews. You can see your limits in the Codex usage dashboard. |
Deploying arsonmix with
|
| Latest commit: |
1c5bb67
|
| Status: | ✅ Deploy successful! |
| Preview URL: | https://c4420183.arsonmix.pages.dev |
| Branch Preview URL: | https://fix-gui-fader-unity-wire-spl.arsonmix.pages.dev |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The previous #613/#616 V60 CSS attempted to grow the fader while the deployed V29 operator composition authoritatively overwrote
--v13-fader-hwith 50:50 at runtime. Browser measured 339/286/220 px, proving no actual visual height increase. Correct source, not another CSS override:scripts/compose_operator_ux.pySPLIT_BOOTSTRAP owns the measured console layout. Borrow up to 48px only from FX space above its 125px usable floor, leaving source/MASTER/rail identical and ensuring folded sections don't clip.PR runs fast and scoped Chrome physical test; main full Chromium (including 8 fold states and native adapter) must pass before Pages publication. Do not claim Windows audio hardware FAT.