Repository navigation
V60 corrective: move fader height to sole chrome owner and truly extend physical travel - #616
Conversation
There was a problem hiding this comment.
💡 Codex Review
Here are some automated review suggestions for this pull request.
Reviewed commit: dd7f04ce59
ℹ️ About Codex in GitHub
Your team has set up Codex to review pull requests in this repo. Reviews are triggered when you
- Open a pull request for review
- Mark a draft as ready
- Comment "@codex review".
If Codex has suggestions, it will comment; otherwise it will react with 👍.
Codex can also answer questions or update the PR. Try commenting "@codex address that feedback".
| Source, BUS/FX, pinned MASTER and section rail all share --v13-fader-h; | ||
| this grows physical travel while the FX rack gives up only elastic space. | ||
| No cap bitmap, dB scale, bridge or WIRE geometry is changed here. */ | ||
| .console-body{--v13-fader-h:clamp(198px,calc(100dvh - 538px),550px)} |
There was a problem hiding this comment.
Update the assembled console's actual fader-height authority
In the approved assembled /preview/, these declarations cannot increase physical fader travel. scripts/build_pages.py calls apply_operator_ux(), which appends an !important declaration for the same token and injects installConsoleSplit(). That bootstrap then sets --v13-fader-h as an inline !important value computed from the existing half-console layout, overriding all three new rules at startup and on resize. Consequently, the shipped GUI retains its previous fader height despite this corrective change. Update the composition/bootstrap height calculation rather than only the internal source stylesheet.
AGENTS.md reference: AGENTS.md:L139-L140
Useful? React with 👍 / 👎.
Codex Review Summary: ✅ CompletedThis comment shows the latest Codex review activity on this pull request.
ℹ️ About Codex in GitHubYour team has set up Codex to review pull requests in this repo. Reviews are triggered when you
Codex reacts with 👀 while any review is running, comments if it has suggestions, and reacts with 👍 once all reviews finish with no findings. |
Follow-up to merged #613. Main Chromium gate exposed forbidden cross-owner CSS stacking:
--fader-fixed-hhad been placed in mixer-fader-assembly.css although mixer-chrome-material.css already owns the mechanical fader height with !important. This meant the previous source-only height declaration was ineffective, despite the new tactile interaction/rewired WIRE passing scoped Chromium.--v13-fader-hin chrome owner, increasing the physical source/MASTER/rail fader by about 46 px at normal screen heights, bounded on short screens; preserve all historical V28 migration text and FX rack flexibility.This corrective PR must merge before Pages can publish #613. Scoped PR quick contract then full main Chromium and Pages verification.