Skip to content

V60 corrective: move fader height to sole chrome owner and truly extend physical travel - #616

Merged
masarray merged 3 commits into
mainfrom
fix/v60-fader-height-css-owner-20261113
Nov 13, 2026
Merged

masarray merged 3 commits into
mainfrom
fix/v60-fader-height-css-owner-20261113

Conversation

@masarray

Copy link
Copy Markdown
Owner

Follow-up to merged #613. Main Chromium gate exposed forbidden cross-owner CSS stacking: --fader-fixed-h had been placed in mixer-fader-assembly.css although mixer-chrome-material.css already owns the mechanical fader height with !important. This meant the previous source-only height declaration was ineffective, despite the new tactile interaction/rewired WIRE passing scoped Chromium.

This corrective PR must merge before Pages can publish #613. Scoped PR quick contract then full main Chromium and Pages verification.

@masarray
masarray merged commit 7c32b09 into main Nov 13, 2026
6 checks passed

@chatgpt-codex-connector chatgpt-codex-connector Bot left a comment

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

💡 Codex Review

Here are some automated review suggestions for this pull request.

Reviewed commit: dd7f04ce59

ℹ️ About Codex in GitHub

Your team has set up Codex to review pull requests in this repo. Reviews are triggered when you

  • Open a pull request for review
  • Mark a draft as ready
  • Comment "@codex review".

If Codex has suggestions, it will comment; otherwise it will react with 👍.

Codex can also answer questions or update the PR. Try commenting "@codex address that feedback".

Source, BUS/FX, pinned MASTER and section rail all share --v13-fader-h;
this grows physical travel while the FX rack gives up only elastic space.
No cap bitmap, dB scale, bridge or WIRE geometry is changed here. */
.console-body{--v13-fader-h:clamp(198px,calc(100dvh - 538px),550px)}

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

P2 Badge Update the assembled console's actual fader-height authority

In the approved assembled /preview/, these declarations cannot increase physical fader travel. scripts/build_pages.py calls apply_operator_ux(), which appends an !important declaration for the same token and injects installConsoleSplit(). That bootstrap then sets --v13-fader-h as an inline !important value computed from the existing half-console layout, overriding all three new rules at startup and on resize. Consequently, the shipped GUI retains its previous fader height despite this corrective change. Update the composition/bootstrap height calculation rather than only the internal source stylesheet.

AGENTS.md reference: AGENTS.md:L139-L140

Useful? React with 👍 / 👎.

@chatgpt-codex-connector

Copy link
Copy Markdown
Codex Review Summary: ✅ Completed

This comment shows the latest Codex review activity on this pull request.

Review Status Commit Review trigger
📝 Code Review ✅ Completed 2026-11-13T00:43:58.497925Z dd7f04c PR opened
ℹ️ About Codex in GitHub

Your team has set up Codex to review pull requests in this repo. Reviews are triggered when you

  • Open a pull request for review
  • Mark a draft as ready
  • Comment "@codex review" or "@codex security review".

Codex reacts with 👀 while any review is running, comments if it has suggestions, and reacts with 👍 once all reviews finish with no findings.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant