Skip to content

Mixer keys v9: approved MUTE/SOLO/PFL in Sends on Faders - #610

Merged
masarray merged 9 commits into
mainfrom
feat/harmonice-v9-pfl-sof-hardware-20261113
Nov 12, 2026
Merged

masarray merged 9 commits into
mainfrom
feat/harmonice-v9-pfl-sof-hardware-20261113

Conversation

@masarray

Copy link
Copy Markdown
Owner

User-approved PNG integration

Integrate the exact PFL FontMatched OFF/ON assets from the local approved v9 collection, without redrawing any hardware button. User selected PFL for the SOF workspace under development in draft PR #604.

  • Existing v9 MUTE/SOLO and PRE/POST atlas is left byte-for-byte unchanged. New PFL-only 114×30 RGBA sprite (OFF/ON 57×30 each) SHA256 1ede18534fa678461ebcb1a100a61170700d75048b11607600cf09d9de8872fd.
  • One renderer / one CSS owner. Main Mix: MUTE–SOLO–PRE/POST; SOF audio strips: MUTE–SOLO–PFL; MASTER and non-audio strips in SOF: MUTE–SOLO.
  • PFL ON uses the original blue PNG and matching v9 typography; PFL OFF uses original v9 lower transparent shadow, with unchanged cap/font/size.
  • Browser PFL toggles existing cue reference selection only, never actual audio; leaving SOF clears hidden cue requests. Native bridge already fails closed on cue without independent MONITOR L/R; native PFL is disabled/off and native SOF remains gated.
  • Add the asset to the same Pages/native GUI assembler. No alternate UI, no plugin/engine changes, no release/installer. Frozen /preview-prod/ untouched.
  • Tests: fast pixel-hash and source contract; Chromium Stage D via real toolbar clicks for normal→SOF→PFL ON→off/normal, exact sprite image/position/alpha shadow and MASTER constraints. Extend exact Pages asset inventory to include the PFL extension.
  • Concurrent SOF branch feat(gui): contextual GAIN/FX RACK and safe Sends-on-Faders console workflow #604 is not modified. The PR author must forward-port sofPfl/PFL state to its contextual renderer and keep per-EdgeId PRE/POST in the SOF panel. Details: docs/HARMONICE_PHYSICAL_KEYS_SOF_CONTRACT.md.

Only the already existing fast UI gate and standard Pages/Chromium qualification. No expensive new Windows build.

@chatgpt-codex-connector

chatgpt-codex-connector Bot commented Nov 12, 2026 •

Copy link
Copy Markdown
Codex Review Summary: ✅ Completed

This comment shows the latest Codex review activity on this pull request.

Review Status Commit Review trigger
📝 Code Review ✅ Completed 2026-11-12T23:15:47.784757Z 3ff8a6e PR opened
ℹ️ About Codex in GitHub

Your team has set up Codex to review pull requests in this repo. Reviews are triggered when you

  • Open a pull request for review
  • Mark a draft as ready
  • Comment "@codex review" or "@codex security review".

Codex reacts with 👀 while any review is running, comments if it has suggestions, and reacts with 👍 once all reviews finish with no findings.

@masarray
masarray merged commit 4775784 into main Nov 12, 2026
6 of 7 checks passed
@masarray masarray changed the title Harmonice v9: approved MUTE/SOLO/PFL physical keys in Sends on Faders Mixer keys v9: approved MUTE/SOLO/PFL in Sends on Faders Nov 13, 2026
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant