Repository navigation
Fix cold WIRE admission and native VST3 picker/editor with prepared graph PDC - #418
Conversation
Codex Review Summary: ✅ CompletedThis comment shows the latest Codex review activity on this pull request.
ℹ️ About Codex in GitHubYour team has set up Codex to review pull requests in this repo. Reviews are triggered when you
Codex reacts with 👀 while any review is running, comments if it has suggestions, and reacts with 👍 once all reviews finish with no findings. |
There was a problem hiding this comment.
💡 Codex Review
Here are some automated review suggestions for this pull request.
Reviewed commit: f0eb2d7123
ℹ️ About Codex in GitHub
Your team has set up Codex to review pull requests in this repo. Reviews are triggered when you
- Open a pull request for review
- Mark a draft as ready
- Comment "@codex review".
If Codex has suggestions, it will comment; otherwise it will react with 👍.
Codex can also answer questions or update the PR. Try commenting "@codex address that feedback".
| if(typeof window.__arMixOpenAudioIO==="function") | ||
| window.__arMixOpenAudioIO("device"); | ||
| else status("AUDIO I/O is unavailable; use the main Audio I/O control."); |
There was a problem hiding this comment.
Restore a reachable device setup in the approved native GUI
In the Windows native build, clicking More → Audio Setup now always takes the unavailable fallback instead of opening device settings. Repository-wide search finds the __arMixOpenAudioIO implementation in web/mixer-io.js, but CMakeLists.txt and scripts/build_approved_native_gui.py bundle the approved Pages GUI plus its native bridge/contract, not that legacy controller. Consequently, this removes the working audioSetup native action without installing its replacement, preventing users from selecting or changing their ASIO/WASAPI device through this control. Keep the native action reachable until a device pane is actually wired into the approved bundle; AGENTS.md explicitly requires preserving device selection.
AGENTS.md reference: AGENTS.md:L16-L18
Useful? React with 👍 / 👎.
…est GUI-optimized main
c900930 to
886ea57
Compare
…d supported rate/buffer inside custom native setup
…hysical pin in native snapshot
… instead of overwriting with stale active status
…y safety and lost-ACK recovery Keep one /preview/ UI and existing per-channel hardware IN route. Show actual virtual playback endpoint, hide legacy Patch/Arm behind unified UX, retain explicit advanced JUCE recovery. Correlate output mute request IDs and recover missing input ACK without touching RT DSP. Add contract gate.
|
Product-integration audit for #412 (2026-11-05): #420 was closed as redundant; #418 is now the single source of truth. Two important native regression cases to verify before merge (not assumptions of PASS):
Please also keep commit-level Windows JUCE/CTest + real |
…review/ DAW First Sound PR Reuse the existing native build, packaging and verification. Upload one clearly marked nonrelease candidate without opening another workflow or changing RT DSP.
…on-admitted auto-monitor Keep the approved /preview/ one-click source routing, but do not unmute unless real ChannelId PCM control authority is admitted. Native liveOutputArmFault rejects an identifiable VB-Cable capture/output self-loop, independently of JS. Add regression contracts. No RT callback changes.
…ved mixer Expose verified 10-strip native M4 control/PCM readback when ChannelId graph not admitted; accept bounded epoch/revision-gated fader/mute/pan/solo and master actions with correlated ACK. Add true MAIN/NONE output routing to existing M4 compile owner. Support IN=None as verified native source-clear, avoiding misleading demo-only choices. All work stays off RT callback.
…eadback Bind stable hardware ordinals through UI reorder, render M4 controls only when changed, cache real PCM meter fills, ACK fader/mute/pan/solo and MAIN, route OUT to installed M4 native graph rather than public demo, keep explicit MONITOR button and selective first-route listen. Limit options to supported route and driver outputs. No DSP callbacks or JS audio.
…thout mutating accepted stereo width
… ChannelId and back Never regenerate view IDs on native admission if the established physical input strips are already present; preserve accepted OUT readback and fail closed on duplicate/missing hardware channel IDs.
…nly when sends disconnected Preserve fail-closed native audio routing. The prior fixture wrongly expected decode to accept a disconnected CH1 while it still sends PRE/POST PCM into two BUS channels.
P0 First Sound integration checkpoint — exact HEAD
|
…VST3 insertion Expose verified PCM faders on original ten channels while ChannelId owns the same JUCE callback; reject dynamic BUS structural conflicts. Add catalog-keyed native insert transaction to existing M4 prepared graph with safe mute, rollback and true fxInstances readback. No DSP processor in JS, no alternate audio engine or callback.
…rve focus and picker Expose the approved /preview/ FX picker, direct fader visuals and native catalog through its existing lexical model. Stop whole-mixer redraw on native 12 Hz scalar readback, preserve active hardware selectors and pointer capture, throttle native realtime fader control events. Structural graph updates still replace the accepted projection only when identities/FX topology actually change.
…l native FX picker/catalog Every original-10/master physical control streams to one JUCE native parameter path while dragging, but final change flushes exact value. Queue independent channel source choices instead of rejecting every selector during a pending ACK. Close AUDIO I/O only after verified active device ACK and show compact toast. Wire approved Plugin Manager/F8/FX picker to real JUCE catalog, native scan/chooser and independently acknowledged routed FX insertion.
…ively open hardware select
|
/arsonmix-ci ui aa3709a |
|
/arsonmix-ci fat 9efa9a2 |
|
/arsonmix-ci fat 93b85fc |
Reconciled milestone — 7 Nov 2026 (post-merge, authoritative)This supersedes earlier Draft/checkpoint notes in this PR description. Verified against the live repository, Actions and public Pages after merge:
This comment is the cross-thread status anchor. No code changes or new engines were introduced by this reconciliation. |
2026-11-07 architecture checkpoint — mixer state must survive Audio I/O and restart
Source audit:
beginManualAudioSetup()disables the native RoutingLab,finishManualAudioSetup()recreates an unpatched 10CH/4AUX graph; opening the native JUCE Audio Setup path also triggers that reset. This is why the mixer contents disappear, independent of UI. Existing P4 NativeShowV2 does not serialize the full modern ChannelId+GROUP/FX_RETURN+WIRE document, so wiring a naive autosave to it would silently lose work.Accepted design (not yet implemented): Device-independent Mixer Session & crash-safe resume ADR: separate durable stable-ID mixer document from ephemeral JUCE device binding, keep existing FX/WIRE state over device change, verified port remap with explicit output disarm, atomic native graph rebind, autosave of accepted revisions with last-known-good transaction journal, named snapshots and safe startup recovery, plugin-state capture thread gates and complete dynamical graph schema. No automatic output arming. Milestones P1–P4 still pending.
Release blocker P0: Windows FAT 42318730495 compiled successfully and 58/58 CTest passed, but ZIP packaging failed on a byte mismatch for
assets/favicon.icobecause the packager/independent final verifier called PATH Python rather than CMake's selected Python (available inapproved-gui-python.txt). Commitd171b245uses one verified resolver in both scripts, leaving SHA and fail-closed gates intact; fast UI/native PASS. Exact-SHA FAT requalification requested. The latest approved icon source is wired into CMake/JUCE/WebView, but actual distributable EXE/ZIP icon is not certified until FAT + independent PE/icon check.2026-11-07 reconciled ASIO4ALL field fix — latest qualification
Field evidence: WASAPI works physically. After ASIO4ALL WDM configuration switched to VB-Cable capture + Realtek playback, ArSonMix showed
Current device is not open; refresh. This is a real closed-device APPLY lifecycle defect, not evidence that ASIO4ALL can synchronize independent hardware clocks.4f7f3cb4restores explicit same-ASIO-device APPLY recovery, forces ASIO4ALL device re-instantiation on operator APPLY, rejects changed physical pin names until independently reselected, and leaves MAIN MUTED. The ordinary working WASAPI device-apply path is not forced to reopen.d4db6e7cmerges the latestmainicon/Pages/CSS V28 work without discarding native WIRE, VST3, EQ and FX changes. ASIO and packaging changes remain on the same integrated branch.28871d96(deferred SVG graph paint) and9de9756c(strict new favicon byte parity) update obsolete test timing and asset inventory assumptions, not the application audio or GUI.c73ffb6ebinds native /preview/ GUI verification to CMake's exact selected Windows Python interpreter; byte-for-byte gate remains enforced and now reports differing file hashes.9de9756c8303a081918bc9fd23195186e1e68128. Full Chromium and exact-application Windows FAT validation are being qualified separately; no claim of physical ASIO4ALL acceptance.Hardware revalidation: ASIO4ALL WDM VB-Cable capture + Realtek playback; verify actual ASIO input/output channel names and masks after Apply; manually remap and arm safe output; report device rate/buffer and Copy Audio Report. No automatic unmute/unknown output failover. Independent device clock drift and hardware crackle (#15) remain unqualified.
Original P2 handoff (historical candidate, superseded below)
The approved Windows mixer now routes its first WIRE and original-channel VST3 picker through the actual PCM owner. This candidate continues the existing channel-to-channel/source-only/live-send-gain work; it preserves the approved
/preview/skin and one JUCE callback. Draft hardware-test candidate, not a stable release.User failures and repairs
The screenshots positively identify stale publication and blanket-latency rejection. They do not contain the first-WIRE toast; cold readiness and revision-race scenarios are therefore explicit regressions, not a claim that every possible user-rig error was observed here.
Candidate and validation
2b1ef483ae53626babe9a29b574ad4f41edf371b.ac85039a6e1dc2dce13394b9b290531e1e46b647; main/stable not promoted.Download exact-HEAD Windows FAT ZIP. Candidate source:
2b1ef483ae53626babe9a29b574ad4f41edf371b. The earlier16fe8c42ZIP does not contain these fixes.Downloaded independently and verified: ZIP CRC PASS, actual AMD64 PE executable, embedded source commit and executable hash all match.
5012176bytes; SHA-256707b49372cd6865ca6422d1b68e71ef0193956a2eecaf7649914071d86d07483.10973184bytes; SHA-2563495b45c4541a2197df8f12cf744c32fc78e79715cd13b933e608a05b14d71a6.Limits and ownership
Delay is bounded by the graph scratch budget and 131072 samples per path. Plugin delay changing after preparation falls back to latency-aligned dry, exposes
latencyChanged, and requires reload; automatic live latency reconfiguration is not claimed. Legacy external CH1 retains its existing restrictions. This does not merge the separately blocked #423 EQ prototype, introduce another DSP renderer, bypass ownership checks or equate software tests with physical FAT.Detailed audit and regression map · live send gain · channel/source-only PCM recovery.
Focused physical FAT
On failure, capture More -> Copy Audio Report with exact ZIP/source SHA and the exact toast. Keep the PR draft/open and main/stable untouched until physical FAT acceptance.