Skip to content

P0 — ONE physical GUI source site/preview + same Pages/JUCE assets, no v2 forks - #393

Closed
masarray wants to merge 19 commits into
mainfrom
gui/one-canonical-source-approved-preview-20261104
Closed

masarray wants to merge 19 commits into
mainfrom
gui/one-canonical-source-approved-preview-20261104

Conversation

@masarray

@masarray masarray commented Nov 4, 2026 •

Copy link
Copy Markdown
Owner

User-approved https://masarray.github.io/arsonmix/preview/ is the sole UI. This migrates the exact approved DOM from site/preview-v2/index.html and the PNG MUTE/SOLO/PFL CSS+JS+sprite from site/preview-buttons/assets/ into one site/preview/ source, using Git blob SHA reuse (no visual redesign). Deletes checked-in retired preview-v2/buttons/v33/v34 pages, duplicate wrapper/old mixer.html/candidate snapshots. scripts/build_pages.py assembles only source site/preview/ with hashed key URLs; native M1 build_approved_native_gui.py uses the same Pages output. Moves tests/CMake source references, retires old rejected CSS-only V6 MUTE tests, keeps legacy public routes as redirect-only and removes historical GUI re-mounts from existing CI (no new workflow). Quality gates: exact rendered Pages DOM except two link revs, PNG asset bytes, current Chromium/WIRE/fader/meter suite and Windows JUCE bundle/CTest; do NOT set PCM LIVE true. Remains NOT product LIVE until native accepted ACK/PCM and physical FAT #389.

Coordination #397 — workstream ownership

GUI branch has 106 changed files including integrator-owned CMake and native bridge; preserve approved /preview/ only and extract GUI-owned changes against main. Do not merge raw.


2026-11-08 reconciliation: ARCHIVED, NOT MERGED

One assembled approved public /preview/ and native embed parity are already enforced in current main. This 106-file attempted physical-source migration targets old GUI/CSS/CI assets and cannot be merged safely. Remaining single-source maintainability/native parity concerns belong in #389; do not revive a second renderer.

Current authority: main, #418. Historical branch retained; hardware FAT not inferred.

@chatgpt-codex-connector

chatgpt-codex-connector Bot commented Nov 4, 2026 •

Copy link
Copy Markdown

Codex Review Summary

This comment shows the latest Codex review activity on this pull request.

Review Status Commit Review trigger
📝 Code Review ✅ Completed 2026-11-04T12:33:39.140545Z e2a0871 PR opened
ℹ️ About Codex in GitHub

Your team has set up Codex to review pull requests in this repo. Reviews are triggered when you

  • Open a pull request for review
  • Mark a draft as ready
  • Comment "@codex review" or "@codex security review".

Codex reacts with 👀 while any review is running, comments if it has suggestions, and reacts with 👍 once all reviews finish with no findings.

@chatgpt-codex-connector chatgpt-codex-connector Bot left a comment

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

💡 Codex Review

if(typeof module!=='undefined'&&module.exports)module.exports=api;

P1 Badge Migrate the graph test import alongside the moved module

Moving this module leaves tests/wire_graph_canonical_model.test.cjs:4 requiring ../site/preview-v2/assets/wire-graph-model.js; running that test now fails immediately with MODULE_NOT_FOUND. The unconditional “WIRE A canonical graph and v8 GUI-to-native handoff contract” step in .github/workflows/ui-smoke.yml runs this test on ordinary GUI PRs and main pushes, so the move breaks UI CI and prevents automatic Pages publication, whose workflow requires a successful UI smoke run. Update the test import to the consolidated source rather than restoring a duplicate module.

AGENTS.md reference: AGENTS.md:L7-L7

ℹ️ About Codex in GitHub

Your team has set up Codex to review pull requests in this repo. Reviews are triggered when you

  • Open a pull request for review
  • Mark a draft as ready
  • Comment "@codex review".

If Codex has suggestions, it will comment; otherwise it will react with 👍.

Codex can also answer questions or update the PR. Try commenting "@codex address that feedback".

"authoritativePagesRoute": "/preview/",
"authoritativePagesOutput": "preview/index.html",
"canonicalSource": "site/preview-v2/index.html",
"canonicalSource": "site/preview/index.html",

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

P1 Badge Update CANONICAL before hashing the relocated GUI source

The manifest label now points to site/preview/index.html, but CANONICAL still resolves to site/preview-v2, which this commit deletes. Consequently, stage() raises FileNotFoundError when calculating canonicalSourceSha256; both staging tests in tests/approved_native_gui_bundle_test.py reproduce this failure. Because CMakeLists.txt invokes this script during configuration and treats a nonzero result as fatal, native builds cannot configure. Update the actual CANONICAL path, not just the manifest label, to the sole approved source.

AGENTS.md reference: AGENTS.md:L7-L7

Useful? React with 👍 / 👎.

masarray commented Nov 4, 2026

Copy link
Copy Markdown
Owner Author

INTEGRATION GUARD (after M2 #394 merged on main@c1a11afd): This GUI-source consolidation PR #393 was prepared before the native V8 WebView bridge landed. Do NOT merge its historical scripts/build_approved_native_gui.py wholesale: it would remove the native-only approved-native-contract.js and approved-native-bridge.js injection/manifest now guarded by Windows CI. Port only the single-source site/preview/ path consolidation onto the latest main, preserve M2's public_from_native and native-hook marker paths, and keep the new actual-CMake-bundle release gate scripts/check_approved_native_gui_release.mjs. Preserve approved PNG buttons byte-for-byte. Then require exact-head Windows + Chromium PASS before merge. Public GUI remains ONLY /preview/, no alternate renderer.

masarray commented Nov 4, 2026

Copy link
Copy Markdown
Owner Author

Coordination #397 — parked GUI branch. This PR is temporarily DRAFT/PARKED because it touches >100 files including native CMake/bridge beyond GUI ownership and the approved /preview/ may have advanced on main. No source has been deleted. GUI owner should compare to current main, extract ONLY still-missing approved site/**/browser visual and interaction changes into one fresh GUI-scoped PR, then verify Chromium/Pages. Any CMake/native bridge need is a handoff to INTEGRATOR, not a direct GUI implementation. Remove parked marker only after reconciliation; do not merge this historic branch raw.

masarray commented Nov 4, 2026

Copy link
Copy Markdown
Owner Author

GUI ownership handoff: main now 0d23ff90, and #396 already merged native-only approved /preview/ lexical scope/fader hooks. Your #393 ~106-file source relocation is draft from old base and touches CMakeLists.txt, scripts/build_approved_native_gui.py, and tests that now own M2.5 source parity. Do not raw merge. Extract only GUI-owned site/**/Pages visual-source cleanup on latest main; INTEGRATOR owns native asset assembler/CMake changes with reversible same-HTML/Png byte parity. Refer to #397 owner map and #389 gate. Do not change approved visuals, do not create another GUI. Route any native asset changes as a precise file handoff.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant