Repository navigation
Conversation
…physical preview source
…o single-source GUI
… retired redirect shells
…e PNG-approved keys
…urce; test sole /preview/
Codex Review SummaryThis comment shows the latest Codex review activity on this pull request.
ℹ️ About Codex in GitHubYour team has set up Codex to review pull requests in this repo. Reviews are triggered when you
Codex reacts with 👀 while any review is running, comments if it has suggestions, and reacts with 👍 once all reviews finish with no findings. |
There was a problem hiding this comment.
💡 Codex Review
Moving this module leaves tests/wire_graph_canonical_model.test.cjs:4 requiring ../site/preview-v2/assets/wire-graph-model.js; running that test now fails immediately with MODULE_NOT_FOUND. The unconditional “WIRE A canonical graph and v8 GUI-to-native handoff contract” step in .github/workflows/ui-smoke.yml runs this test on ordinary GUI PRs and main pushes, so the move breaks UI CI and prevents automatic Pages publication, whose workflow requires a successful UI smoke run. Update the test import to the consolidated source rather than restoring a duplicate module.
AGENTS.md reference: AGENTS.md:L7-L7
ℹ️ About Codex in GitHub
Your team has set up Codex to review pull requests in this repo. Reviews are triggered when you
- Open a pull request for review
- Mark a draft as ready
- Comment "@codex review".
If Codex has suggestions, it will comment; otherwise it will react with 👍.
Codex can also answer questions or update the PR. Try commenting "@codex address that feedback".
| "authoritativePagesRoute": "/preview/", | ||
| "authoritativePagesOutput": "preview/index.html", | ||
| "canonicalSource": "site/preview-v2/index.html", | ||
| "canonicalSource": "site/preview/index.html", |
There was a problem hiding this comment.
Update CANONICAL before hashing the relocated GUI source
The manifest label now points to site/preview/index.html, but CANONICAL still resolves to site/preview-v2, which this commit deletes. Consequently, stage() raises FileNotFoundError when calculating canonicalSourceSha256; both staging tests in tests/approved_native_gui_bundle_test.py reproduce this failure. Because CMakeLists.txt invokes this script during configuration and treats a nonzero result as fatal, native builds cannot configure. Update the actual CANONICAL path, not just the manifest label, to the sole approved source.
AGENTS.md reference: AGENTS.md:L7-L7
Useful? React with 👍 / 👎.
…ttons_dest assembler
…rectories reappear
|
INTEGRATION GUARD (after M2 #394 merged on main@c1a11afd): This GUI-source consolidation PR #393 was prepared before the native V8 WebView bridge landed. Do NOT merge its historical |
|
Coordination #397 — parked GUI branch. This PR is temporarily DRAFT/PARKED because it touches >100 files including native CMake/bridge beyond GUI ownership and the approved |
|
GUI ownership handoff: main now |
User-approved https://masarray.github.io/arsonmix/preview/ is the sole UI. This migrates the exact approved DOM from
site/preview-v2/index.htmland the PNG MUTE/SOLO/PFL CSS+JS+sprite fromsite/preview-buttons/assets/into onesite/preview/source, using Git blob SHA reuse (no visual redesign). Deletes checked-in retired preview-v2/buttons/v33/v34 pages, duplicate wrapper/old mixer.html/candidate snapshots.scripts/build_pages.pyassembles only sourcesite/preview/with hashed key URLs; native M1build_approved_native_gui.pyuses the same Pages output. Moves tests/CMake source references, retires old rejected CSS-only V6 MUTE tests, keeps legacy public routes as redirect-only and removes historical GUI re-mounts from existing CI (no new workflow). Quality gates: exact rendered Pages DOM except two link revs, PNG asset bytes, current Chromium/WIRE/fader/meter suite and Windows JUCE bundle/CTest; do NOT set PCM LIVE true. Remains NOT product LIVE until native accepted ACK/PCM and physical FAT #389.Coordination #397 — workstream ownership
GUI branch has 106 changed files including integrator-owned CMake and native bridge; preserve approved /preview/ only and extract GUI-owned changes against main. Do not merge raw.
2026-11-08 reconciliation: ARCHIVED, NOT MERGED
One assembled approved public /preview/ and native embed parity are already enforced in current main. This 106-file attempted physical-source migration targets old GUI/CSS/CI assets and cannot be merged safely. Remaining single-source maintainability/native parity concerns belong in #389; do not revive a second renderer.
Current authority: main, #418. Historical branch retained; hardware FAT not inferred.