Repository navigation
P0 GUI Stutter A–D: single native CSSOM, cascade pruning, pointer hot-path + profiling - #414
Conversation
Codex Review SummaryThis comment shows the latest Codex review activity on this pull request.
ℹ️ About Codex in GitHubYour team has set up Codex to review pull requests in this repo. Reviews are triggered when you
Codex reacts with 👀 while any review is running, comments if it has suggestions, and reacts with 👍 once all reviews finish with no findings. |
There was a problem hiding this comment.
💡 Codex Review
Here are some automated review suggestions for this pull request.
Reviewed commit: 5b7b2c073c
ℹ️ About Codex in GitHub
Your team has set up Codex to review pull requests in this repo. Reviews are triggered when you
- Open a pull request for review
- Mark a draft as ready
- Comment "@codex review".
If Codex has suggestions, it will comment; otherwise it will react with 👍.
Codex can also answer questions or update the PR. Try commenting "@codex address that feedback".
…itative 12Hz publication
…d meter and peak hold
…hot-safe original Pages
…native status/snapshot
Stage C — production CSS consolidation (2026-11-05, head
|
…ors; allow fully clean future sources
… approved GUI at 3 Windows viewports
…across WebView2 versions
…from locked artwork
…h modern WebView2 safety
…inal compiler result
Stage C exact-head browser qualification — fallback-safe resultsExact PR SHA: The first compiler pass removed 242 CSS declarations; a deliberate compatibility fix now preserves older
CI: https://github.com/masarray/arsonmix/actions/runs/41983865160 |
…ages and native WebView2
…r tooling contract
…yle authoring visually
…yle authoring visually
…duplicate runtime links
…l approved Chromium GUI
…ce proof boundaries
… without hiding style load
…only legacy ARMixConsole
…native build and provenance verification
P0 Stage A — exact approved /preview/ mouse-latency evidence
Closes no performance issue until affected-PC Windows proof exists. References #56. This PR introduces opt-in instrumentation + CSS anti-stacking gates, not a measured pointer speedup.
Product changes
/preview/GUI and its exact JUCE WebView2 native bundle. Disabled in normal use: no continuous probe animation, sampling loop, CSS override, panel, overlay or artificial audio. Start/stop: Ctrl+Alt+Shift+F9 (15 s auto-stop). Browser URL-only optional?armixperf=1and JS export API.scripts/collect_gui_perf_windows.ps1records local CPU/memory timeline for native host and WebView2. No personal system data upload or autorun.Verification and status
scripts/build_pages.pyandscripts/build_approved_native_gui.py, no second GUI renderer or changed visual CSS.Guardrails
One audio callback; no new CSS overlays; original /preview/ appearance+PNG controls; no fake PCM, no default audio output changes, no automatic arming/routing, preserve ACK+later authoritative readback, real VST3 and WIRE interactions.
Stage B — runtime hot path and CSS architecture (2026-11-05)
Stage C — deployed CSS cascade consolidation + visual proof (2026-11-05)
Stage D — exactly ONE loaded approved CSS (2026-11-05)
arsonmix-approved-runtime.css?sha=<digest>for both Pages/preview/and the byte-identical native JUCE WebView2 resources, replacing 18 network/CSSOM stylesheet links with 1 (17 fewer CSS requests). The underlying 18 authored source owners and approved PNG/WIRE assets remain unchanged; no new override module or design/geometry change.Stage D — one loaded CSSOM and final integration
assets/arsonmix-approved-runtime.css) with content-addressed SHA, preserving declared source/cascade order, original PNG MUTE/SOLO/PFL, WIRE and WebView2-compatible fallbacks. Exactly 17 fewer stylesheet requests in the browser; 18 owner modules retained in repo as reviewable source, zero new override sheet.tests/approved_css_stage_d_single_bundle_smoke.pychecks actual Chrome CSS network count/PNG button/MUTE at 1366×768, 1680×900, 1920×1080.tests/single_preview_publication_contract_test.pyverifies runtime bundle SHA, original per-owner compiled hashes, one approved GUI. Stage C screenshot and computed-style parity compare reconstructed original CSS against the sole shipped runtime CSS. Native Resources + Windows CTest remain mandatory.scripts/collect_gui_perf_windows.ps1: process sampler recognizes realAR MIX Studioand packaged EXE names, plus-ExePath; explicit warning if the JUCE process is absent. Review thread answered.