Skip to content
Closed
Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
19 commits
Select commit Hold shift + click to select a range
67ad8bd
refactor(gui): consolidate exact PNG-approved GUI into sole site/prev…
masarray Nov 4, 2026
8748763
build(gui): emit /preview/ from ONE approved physical source with PNG…
masarray Nov 4, 2026
7d94da9
refactor(gui): route Pages, JUCE BinaryData, and contracts to single …
masarray Nov 4, 2026
f3f389a
test(gui): port canonical WIRE/FX/meter tests to sole approved source
masarray Nov 4, 2026
15ebfec
test(gui): bind WIRE positions, responsive fold, and physical fader t…
masarray Nov 4, 2026
a43899b
tests(gui): rename historical CSS recovery source paths without rebas…
masarray Nov 4, 2026
d44de32
test(gui): migrate archived CSS audit paths to sole canonical source
masarray Nov 4, 2026
69fe7e3
test(gui): redirect current operator and visual test fixtures to one …
masarray Nov 4, 2026
a505eab
test(gui): exercise only approved /preview/ published HTML instead of…
masarray Nov 4, 2026
f763829
test(gui): retire rejected CSS-only and V34 hardware controls; enforc…
masarray Nov 4, 2026
65f1c94
test(gui): correct PNG signature and exact CSS link assertions on one…
masarray Nov 4, 2026
eae3b6c
test(gui): correct PNG signature and exact CSS link assertions on one…
masarray Nov 4, 2026
2137333
ci(gui): stop restoring rejected historical GUI skins into current so…
masarray Nov 4, 2026
e2a0871
fix(gui): lock single-source native descriptor and smart current-only…
masarray Nov 4, 2026
df6de0b
test(wire): resolve canonical graph model from sole site/preview source
masarray Nov 4, 2026
161a52a
fix(native): resolve one physical site/preview source in approved Win…
masarray Nov 4, 2026
8a6e7e3
test(native): validate canonical Pages builder source, not removed bu…
masarray Nov 4, 2026
88bc723
docs(gui): direct all engineers to single physical approved site/prev…
masarray Nov 4, 2026
979ccba
test(gui): fail CI when obsolete preview-v2/buttons/V33/V34 source di…
masarray Nov 4, 2026
File filter

Filter by extension

Filter by extension


Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
171 changes: 7 additions & 164 deletions .github/workflows/ui-smoke.yml

Large diffs are not rendered by default.

6 changes: 3 additions & 3 deletions AGENTS.md
Original file line number Diff line number Diff line change
Expand Up @@ -3,12 +3,12 @@

**ONLY approved/public/product GUI: https://masarray.github.io/arsonmix/preview/**. There must be ONE public preview, ONE actual rendered GUI, and ONE native Windows GUI. **/preview-v2/ is rejected**: do not display, promote, publish or base native design on it as a separate UI. Do not substitute another console from `web/index.html`, `web/mixer-layout.js`, `web/console-native.html`, PR #278 or old M3/V48 mock. **The JUCE ENGINE must stitch into the EXACT approved /preview/ GUI**, never redesign it.

## Verified current published GUI implementation
`site/preview/index.html` was merely a wrapper/iframe pointing at a generated `/preview-buttons/index.html`. `scripts/build_pages.py` generates that **approved PNG hardware-button variant** using current `site/preview-v2/index.html` as an INTERNAL HTML/WIRE/FX/fader source, with specifically `site/preview-buttons/assets/mixer-control-keys.css`, `mixer-control-keys.js` and `mute-solo-pfl-56x37.png` as approved button source. **The assembled result behind /preview/ is the visual authority, not /preview-v2/ in isolation.** There must be exactly ONE deterministic assembled output and no independent published variant. Internal source files may survive only as build inputs until safely consolidated; they are NOT alternate product GUIs. **Current approved visual including PNG keys must never be silently replaced by the base variant.**
## Single physical GUI source (consolidated)
**ONLY `site/preview/index.html` and `site/preview/assets/**` own the approved source**, including PNG MUTE/SOLO/PFL and all WIRE/FX/fader CSS/JS. `scripts/build_pages.py` publishes exactly those bytes with two content-addressed CSS/JS link revisions. `scripts/build_approved_native_gui.py` invokes the SAME builder for JUCE resources. Retired `site/preview-v2/`, `site/preview-buttons/`, and V33/V34 snapshot directories have been deleted from current source; their old public URLs are redirect-only. Do not reintroduce copied GUI files or variant skins.

## Active contract and ownership
- [P0 native GUI stitch #389](https://github.com/masarray/arsonmix/issues/389) — compile the **exact /preview/ assembled GUI** and component assets into JUCE WebView2, no new layout/renderer. Update the issue from earlier incorrect preview-v2 wording.
- GUI reference maintenance: currently reviewed `main` component/source changes. Publish ONLY `/preview/` and no independent `/preview-v2/`, `/preview-buttons/` or historical Vxx GUI. Old URLs may redirect to /preview/ but never contain another mixer UI.
- GUI reference maintenance: currently reviewed `main/site/preview/**` component/source changes. Publish ONLY `/preview/` and no independent `/preview-v2/`, `/preview-buttons/` or historical Vxx GUI. Old URLs may redirect to /preview/ but never contain another mixer UI.
- ENGINE [#266](https://github.com/masarray/arsonmix/pull/266) + [#387](https://github.com/masarray/arsonmix/pull/387) keep ONE primary JUCE realtime callback, ONE accepted ChannelId/EdgeId PCM graph, ONE genuine native VST3 lease/editor; do not ship ENGINE's own `web/console-native.*` visual renderer.
- FAT [#270](https://github.com/masarray/arsonmix/pull/270), native epic #192, hardware crackle #15. One integrated exact-SHA Windows EXE; exact approved generated `/preview/` HTML/assets SHA256 and screenshot/interaction parity; native PCM + VST3 + actual hardware FAT.

Expand Down
3 changes: 1 addition & 2 deletions CMakeLists.txt
Original file line number Diff line number Diff line change
Expand Up @@ -22,8 +22,7 @@ juce_add_gui_app(ARMixConsole
find_package(Python3 REQUIRED COMPONENTS Interpreter)
set(ARMIX_APPROVED_GUI_DIR "${CMAKE_CURRENT_BINARY_DIR}/approved_gui")
file(GLOB_RECURSE ARMIX_APPROVED_GUI_SOURCE_INPUTS CONFIGURE_DEPENDS
"${CMAKE_CURRENT_SOURCE_DIR}/site/preview-v2/*"
"${CMAKE_CURRENT_SOURCE_DIR}/site/preview-buttons/assets/*")
"${CMAKE_CURRENT_SOURCE_DIR}/site/preview/*")
list(APPEND ARMIX_APPROVED_GUI_SOURCE_INPUTS
"${CMAKE_CURRENT_SOURCE_DIR}/web/approved-native-bridge.js"
"${CMAKE_CURRENT_SOURCE_DIR}/scripts/build_approved_native_gui.py")
Expand Down
2 changes: 1 addition & 1 deletion README.md
Original file line number Diff line number Diff line change
Expand Up @@ -29,7 +29,7 @@ Choose device once, then directly from the console:
One accepted stable-ChannelId graph, one JUCE realtime callback, one native VST3 owner, one request/ACK truth. Continuous controls do not trigger device restart; structural edits prepare safely off callback. Native accepted capability gates UI; **no fake CH11/FX/PCM**. Operator-selected legal I/O only; correct device buffering and plugin latency disclosures, not '0ms' guarantees.

## Browser preview, native builds and QA
**ONLY approved GUI:** https://masarray.github.io/arsonmix/preview/ (visual UI reference, **NO REAL AUDIO**). Old `/preview-v2/`, `/preview-buttons/` and `/preview/mixer.html` redirect to this one approved screen. Source: https://github.com/masarray/arsonmix. Windows x64 native packages: [Windows Actions workflow](https://github.com/masarray/arsonmix/actions/workflows/p1-windows.yml). Download only a successful exact-source-SHA artifact; verify `BUILD_PROVENANCE.json` and EXE SHA-256, install WebView2/real device driver, test at safe headphone volume.
**ONLY approved GUI/source:** `site/preview/index.html` + `site/preview/assets/**` → https://masarray.github.io/arsonmix/preview/ (visual UI reference, **NO REAL AUDIO**). Old `/preview-v2/`, `/preview-buttons/` and `/preview/mixer.html` redirect to this one approved screen. Source: https://github.com/masarray/arsonmix. Windows x64 native packages: [Windows Actions workflow](https://github.com/masarray/arsonmix/actions/workflows/p1-windows.yml). Download only a successful exact-source-SHA artifact; verify `BUILD_PROVENANCE.json` and EXE SHA-256, install WebView2/real device driver, test at safe headphone volume.

Use owner CSS `web/styles-src/**` and deterministic `scripts/build_ui_css.py` regeneration; avoid manual generated HTML drift. Read full failing CI logs, run targeted tests, then one Windows/CTest and Chromium gate at meaningful vertical checkpoints. For physical clicks use SIGNAL CHECK → MARK CRACKLE → COPY FULL REPORT. Real-device 0FX and loaded-FX performance must be signed off before release.

Expand Down
2 changes: 1 addition & 1 deletion docs/ARD_WIRE_FIRST_ZERO_ADDED_LATENCY_20261104.md
Original file line number Diff line number Diff line change
Expand Up @@ -6,7 +6,7 @@

## A. Verified current-state inventory — main 0215986fbbe2c67971680952f75f069950ac653e

- GUI reference site/preview-v2/index.html is simulated. Current JS stores routes in wireEdges, track.output, sendSlots/activeSend and track.input split markers. wireDisplayRoutes excludes default CH->MAIN. wireIsCycle does not traverse all legacy sends. Sends-on-Faders and Copy/Paste/Scene can bypass unified cycle/duplicate validation. A screen that looks linked can differ from the actual intended signal graph.
- GUI reference site/preview/index.html is simulated. Current JS stores routes in wireEdges, track.output, sendSlots/activeSend and track.input split markers. wireDisplayRoutes excludes default CH->MAIN. wireIsCycle does not traverse all legacy sends. Sends-on-Faders and Copy/Paste/Scene can bypass unified cycle/duplicate validation. A screen that looks linked can differ from the actual intended signal graph.
- WIRE SVG #wireLayer sits inside #viewport (banks), whereas pinned #master is a sibling. Current geometry cannot represent a true MAIN endpoint; MAIN receiver specifically omits incoming WIRE edge handling in wireTray/pointerdown. requestWireConnection blocks some drops and toggleDirectMain mutates track.output independently.
- engine/core/DynamicChannelRoster.h has stable ChannelId and ChannelSendRef(primaryOutput). DynamicConsoleRoutingView.h is an accepted-session *projection*. DynamicPreparedMixerBlock.h is an offline prepared PCM kernel, NOT the installed callback. Current production remains 10 CH + 4 AUX/CH1 special VST path. ENGINE #266 is sole owner of native cutover; native GUI #389, FAT #270 are drafts; #15 physical 0FX crackle OPEN.
- contracts/console-puzzle-v8.json schemaVersion 6 already defines native requestId, deviceEpoch, baseGraphRevision, baseRosterRevision, operation, targetChannelId, ACK and accepted graph snapshot. Preserve that envelope. Do not invent a parallel browser-native protocol.
Expand Down
Original file line number Diff line number Diff line change
Expand Up @@ -3,8 +3,7 @@
**Final user decision:** https://masarray.github.io/arsonmix/preview/ is the **one and only** approved GUI/UX and the only publicly displayed preview. The previously referenced /preview-v2/ is rejected as a **separate GUI** and must not be published or used as native design target. The JUCE engine adapts to this finished GUI. This document's filename is historical for old links; its authority is **/preview/**.

## How the approved screen is currently built
- `site/preview/index.html` was a wrapper using iframe `../preview-buttons/index.html`, generated by `scripts/build_pages.py`.
- The **approved rendered visual** is the assembled PNG-button variant: internal `site/preview-v2/index.html` and its CSS/JS/WIRE/fader/meter/FX content combined with **approved** `site/preview-buttons/assets/mixer-control-keys.css`, `mixer-control-keys.js`, and PNG sprite `mute-solo-pfl-56x37.png`.
- The **only checked-in GUI source** is `site/preview/index.html` + `site/preview/assets/**`, including approved PNG MUTE/SOLO/PFL, WIRE, FX, faders and meters. Pages and native JUCE both compile exactly these assets through `scripts/build_pages.py`. Retired `site/preview-v2` and `site/preview-buttons` are removed; legacy URLs redirect only.
- These names are **internal build inputs only**, not two product UI variants. Build/publish ONE assembled `/preview/` artifact, and optionally redirect old URLs to /preview/ without serving different GUI. Preserve approved source material until source migration is safe. All future native bundling must consume this assembled output, not the base HTML or the former `/preview-v2/` rendering.

## P0 milestones / real code work
Expand Down
2 changes: 1 addition & 1 deletion docs/workstreams/START_HERE_WIRE_FIRST_20261104.md
Original file line number Diff line number Diff line change
Expand Up @@ -2,7 +2,7 @@

**Final owner decision:** https://masarray.github.io/arsonmix/preview/ is the ONLY approved preview and Windows GUI/UX. **/preview-v2/ was explicitly rejected** and may not be shown as another public GUI or native design target. The actual approved /preview/ screen includes **PNG hardware MUTE/SOLO/PFL controls** that are not the bare preview-v2 rendering.

**How to source exactly the approved visual:** `scripts/build_pages.py` assembles ONE `/preview/` HTML+assets from internal `site/preview-v2/index.html` and shared FX/WIRE/fader/meter assets but overlays `site/preview-buttons/assets/mixer-control-keys.css`, `mixer-control-keys.js`, `mute-solo-pfl-56x37.png`. Internal source names are **not separate product GUIs**. The published /preview/ assembly, not /preview-v2/ alone, must be deterministically embedded in JUCE WebView2. Old public preview URLs are redirect-only. See [canonical handoff](HANDOFF_APPROVED_PREVIEW_V2_NATIVE_20261104.md) (filename historic), root AGENTS.md, PRD, ARD and P0 #389.
**How to source the approved visual:** the ONE checked-in source is `site/preview/index.html` with `site/preview/assets/**` (approved PNG keys included). `scripts/build_pages.py` publishes it; `scripts/build_approved_native_gui.py` consumes the same Pages output for JUCE. Do not resurrect retired preview-v2/buttons sources.

## Four meaningful milestones (do not re-plan)
1. **One public preview:** `python scripts/build_pages.py` generates /preview/index.html directly. `python tests/single_preview_publication_contract_test.py dist-pages` must verify PNG buttons, WIRE and all legacy redirects. Never serve a separate /preview-v2/ mixer.
Expand Down
4 changes: 2 additions & 2 deletions scripts/build_approved_native_gui.py
Original file line number Diff line number Diff line change
Expand Up @@ -19,7 +19,7 @@
import tempfile

ROOT = Path(__file__).resolve().parents[1]
CANONICAL = ROOT / "site" / "preview-v2"
CANONICAL = ROOT / "site" / "preview"
NATIVE_ADAPTER = ROOT / "web" / "approved-native-bridge.js"
ADAPTER_MARKER = '<script defer src="assets/approved-native-bridge.js"></script>'
SCHEMA = "arsonmix.approved-native-pages-bundle.v2"
Expand Down Expand Up @@ -123,7 +123,7 @@ def stage(out: Path) -> dict:
"schema": SCHEMA,
"authoritativePagesRoute": "/preview/",
"authoritativePagesOutput": "preview/index.html",
"canonicalSource": "site/preview-v2/index.html",
"canonicalSource": "site/preview/index.html",

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

P1 Badge Update CANONICAL before hashing the relocated GUI source

The manifest label now points to site/preview/index.html, but CANONICAL still resolves to site/preview-v2, which this commit deletes. Consequently, stage() raises FileNotFoundError when calculating canonicalSourceSha256; both staging tests in tests/approved_native_gui_bundle_test.py reproduce this failure. Because CMakeLists.txt invokes this script during configuration and treats a nonzero result as fatal, native builds cannot configure. Update the actual CANONICAL path, not just the manifest label, to the sole approved source.

AGENTS.md reference: AGENTS.md:L7-L7

Useful? React with 👍 / 👎.

"canonicalSourceSha256": sha256((CANONICAL / "index.html").read_bytes()),
"approvedPagesHtmlSha256": sha256(approved),
"nativeHtmlSha256": sha256(native),
Expand Down
Loading
Loading