Repository navigation
P0 — ONE physical GUI source site/preview + same Pages/JUCE assets, no v2 forks #393
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Closed
masarray
wants to merge
19
commits into
main
from
gui/one-canonical-source-approved-preview-20261104
+3,168
−21,309
Closed
Changes from all commits
Commits
Show all changes
19 commits
Select commit
Hold shift + click to select a range
67ad8bd
refactor(gui): consolidate exact PNG-approved GUI into sole site/prev…
masarray 8748763
build(gui): emit /preview/ from ONE approved physical source with PNG…
masarray 7d94da9
refactor(gui): route Pages, JUCE BinaryData, and contracts to single …
masarray f3f389a
test(gui): port canonical WIRE/FX/meter tests to sole approved source
masarray 15ebfec
test(gui): bind WIRE positions, responsive fold, and physical fader t…
masarray a43899b
tests(gui): rename historical CSS recovery source paths without rebas…
masarray d44de32
test(gui): migrate archived CSS audit paths to sole canonical source
masarray 69fe7e3
test(gui): redirect current operator and visual test fixtures to one …
masarray a505eab
test(gui): exercise only approved /preview/ published HTML instead of…
masarray f763829
test(gui): retire rejected CSS-only and V34 hardware controls; enforc…
masarray 65f1c94
test(gui): correct PNG signature and exact CSS link assertions on one…
masarray eae3b6c
test(gui): correct PNG signature and exact CSS link assertions on one…
masarray 2137333
ci(gui): stop restoring rejected historical GUI skins into current so…
masarray e2a0871
fix(gui): lock single-source native descriptor and smart current-only…
masarray df6de0b
test(wire): resolve canonical graph model from sole site/preview source
masarray 161a52a
fix(native): resolve one physical site/preview source in approved Win…
masarray 8a6e7e3
test(native): validate canonical Pages builder source, not removed bu…
masarray 88bc723
docs(gui): direct all engineers to single physical approved site/prev…
masarray 979ccba
test(gui): fail CI when obsolete preview-v2/buttons/V33/V34 source di…
masarray File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
Large diffs are not rendered by default.
Oops, something went wrong.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Oops, something went wrong.
Oops, something went wrong.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
The manifest label now points to
site/preview/index.html, butCANONICALstill resolves tosite/preview-v2, which this commit deletes. Consequently,stage()raisesFileNotFoundErrorwhen calculatingcanonicalSourceSha256; both staging tests intests/approved_native_gui_bundle_test.pyreproduce this failure. BecauseCMakeLists.txtinvokes this script during configuration and treats a nonzero result as fatal, native builds cannot configure. Update the actualCANONICALpath, not just the manifest label, to the sole approved source.AGENTS.md reference: AGENTS.md:L7-L7
Useful? React with 👍 / 👎.