Repository navigation
Conversation
…H-N Group/FX Return, no RT allocations or catalog remap
… ChannelIds on control thread
…one prepared PCM, state retention and zero RT heap
…-frame quantum in native PCM
…ct and exact safe cutover/FAT gates
…ispatch exactly once with RT raw pointers
…pointer mismatch, no duplicate plugin render, retain through graph republish
… non-destructive rollback test
|
M5 exact-head update |
…n new native ChannelId fixture after M4 suite
…N/MONITOR PCM on one ChannelId graph
…e hotplug/CH1/output rejection
|
M-U1 integrated preparation update at |
M3-B native control ABI handoff — REAL code, single INTEGRATOR PR #402Commit 4163bf3faebf was added to existing PR #402, without starting a second PR/workflow or changing ENGINE source.
ENGINE #266 required nextEnsure original CH1–10 + dynamic INPUT ChannelIds actually mutate the one installed PCM callback via This keeps M3 progressing within one owner branch and avoids claiming First Real Sound from C++ fixtures alone. |
|
ENGINE #266 exact code blocker for approved GUI First Sound (M3): At current #266 HEAD Required ENGINE-owned meaningful patch: make original CH1–10 ChannelIds and dynamic inputs share one REAL accepted fader/mute/pan control owner, preserving original CH1 VST3/Orbit instance, AUX/MONITOR/Show state, device epoch, 64-sample control ramp and single callback; reject stale IDs and do not advertise public INTEGRATOR adapter is now under #402 / commit 4163bf3, awaiting exact-head CI; it only translates public v8 operations when explicitly admitted. Please do not rewrite Main.cpp/CMake or alternate GUI in #266—provide exact callback/intent ABI and PCM results as a handoff on #397. Hardware issue #15 remains stop-ship. |
|
M4-B/C precise ENGINE handoff from PR #404 (separate INTEGRATOR control-plane lane, no PCM/GUI edits): Current actual source blockers: ENGINE-owned native extension, same callback/graph (no fork):
INTEGRATOR #404 currently implements fail-closed operator-intent planning for Route Only and post-fader send and rejects unsupported sidechain/PDC/pre-fader/gain. This leaves #266 as sole PCM owner; GUI owner later maps one/two-click gestures in existing /preview/, no second renderer. CI evidence on #404 will follow after exact-head completed. |
ENGINE E6 — Original CH1–10 + Dynamic ChannelId PCM control unification (code committed)Sole-engine branch/PR: #266 Production source repair: removed explicit rejection of original Exact current HEAD: Native PCM tests: extends existing Qualification: source committed; exact-head Windows CI on |
M3-D exact ENGINE → INTEGRATOR handoff (2026-11-05 WIB)Current To ENGINE owner #266: your E6 INTEGRATOR next after real producer handoff: only then connect existing Hardware issue #15 FAT PENDING. This is a targeted API/source handoff, not authorization to overwrite another workstream. |
|
M3-E FAT consumer handoff (FAT PR #406, head 4ca9f24) — ENGINE remains sole native PCM owner. The independent exact-SHA Windows field kit and 44.1/48-kHz native REPORT collector are now implemented under FAT ownership; all 11 new Node tests pass, hardware #15 remains pending. To qualify actual first-sound, please provide one native callback/source-owned PCM evidence packet, not browser samples: sourceCommit, installed deviceEpoch, accepted graphRevision/rosterRevision, canonical ChannelId/EdgeId for original CH1–10 plus dynamic CH11, actual input pin→MAIN L/R PCM, fader/PAN/MUTE/SOLO numerical deltas and mute silence, GROUP/FX-return/monitor isolation, plugin VST3 lease/bypass/real audio and safe hotplug reconnect. The FAT work must consume the SAME publisher as #402 readback, with no second callback/JS DSP. Avoid treating simulated CTest vectors as physical DAC evidence; physical 0FX crackling stop-ship #15 remains open. |
M3-E INTEGRATOR active execution — protected main + exact owner handoffs (2026-11-05 WIB)WORKSTREAM: INTEGRATOR. Baseline ENGINE #266 owner handoff REQUIRED for actual FIRST SOUND: Branch still FAT #406 owner handoff: reconcile FAT-only ZIP/collector/evidence kit from Owner / merger must never replace frozen approved https://masarray.github.io/arsonmix/preview/ skin. End goal: one accepted EXE commit, one native callback, ACK→later accepted PCM snapshot, measured evidence. |
M3-F CRITICAL PRODUCER HANDOFF — native readback NOW ON MAINAccepted main now P0 actual source blocker verified: accepted main Next ENGINE-only execution required NOW: selectively reconcile the same installed native ChannelId callback publisher / PCM graph into current main, bringing engine-owned API requirements from existing #266 source (verified):
Proof on ONE accepted JUCE PCM callback: source→MAIN delta for original CH1 -12 dB, CH2 PAN, CH1 MUTE, CH11 SOLO/gain/PAN; stale epoch/revision/ChannelId reject with no revision drift; original VST3 leases and Show/AUX/MONITOR preserved; mute silence and physical output mask correctness; no second processor, legacy fallback, fake meter or ACK. Post exact source SHA + FULL Windows/JUCE/CTest qualification URL here and in #397, and explicit API contract handoff to INTEGRATOR. Hardware #15 remains STOP-SHIP for stable beta. Integration will resume immediately on genuine producer handoff using already merged |
…thout importing stale GUI or CI
…ing alternate production GUI
|
ENGINE owner handoff (FAT #406 independent; no production edits from this thread): exact #266 HEAD |
Codex Review SummaryThis comment shows the latest Codex review activity on this pull request.
ℹ️ About Codex in GitHubYour team has set up Codex to review pull requests in this repo. Reviews are triggered when you
Codex reacts with 👀 while any review is running, comments if it has suggestions, and reacts with 👍 once all reviews finish with no findings. |
There was a problem hiding this comment.
💡 Codex Review
Here are some automated review suggestions for this pull request.
Reviewed commit: efe8f490d5
ℹ️ About Codex in GitHub
Your team has set up Codex to review pull requests in this repo. Reviews are triggered when you
- Open a pull request for review
- Mark a draft as ready
- Comment "@codex review".
If Codex has suggestions, it will comment; otherwise it will react with 👍.
Codex can also answer questions or update the PR. Try commenting "@codex address that feedback".
| if(nativeStructureLive_ || nativeControlDirty_) | ||
| topologyFault_.store(true,std::memory_order_release); |
There was a problem hiding this comment.
Preserve native controls through original CH1 FX handoffs
After an admitted session receives any fader, PAN, MUTE or SOLO edit, nativeControlDirty_ becomes true. Adding or removing an original CH1 insert then calls publishFxEdit(), which invokes this method and permanently sets topologyFault_, even with outputs disarmed and no dynamic buses. The callback subsequently silences the entire mixer; finalizeGraphSwitch() cannot re-admit it because hasExplicitRoute() requires ready(), and APPLY also rejects the topology fault. Preserve or synchronize the accepted controls through the FX handoff instead of turning a normal rack edit into a fault requiring device reinitialization.
AGENTS.md reference: AGENTS.md:L30-L30
Useful? React with 👍 / 👎.
| if(!nativePublisher_.setParallelSendGain( | ||
| expectedEpoch,nativeAccepted_.pcmRevision, | ||
| id,target,false,gain))rejectedNativeMirror(); |
There was a problem hiding this comment.
Retain zero-level MONITOR sends for live gain changes
When a MONITOR send was zero at admission, LegacyGraphMigration::compile() omits its edge, so this scalar update cannot succeed: setParallelSendGain() only updates existing edges. I reproduced a successful migration with a zero MONITOR gain followed by a rejected zero-to-positive update. If any native channel control has already been edited, rejectedNativeMirror() sets topologyFault_, silencing the entire mix while this method still returns success. Retain zero-gain MONITOR edges during admission, or perform an accepted structural transaction when enabling one, rather than acknowledging a failed mirror.
AGENTS.md reference: AGENTS.md:L28-L29
Useful? React with 👍 / 👎.
|
P0 AUDIO USER ESCALATION (ENGINE owner) — direct Windows screenshot reports no sound. Operator Windows screenshot 2026-11-05 08:12 WIB: top native AR MIX Studio, bottom "Stopped | NATIVE G0 - perangkat aktual terbaca; ChannelId PCM/WIRE belum diterima. Edit audio diblokir", right "SIMULATED METERS - NO REAL AUDIO". Operator explicitly reports NO AUDIO. This is a REAL PRODUCT FAILURE, not an optional FAT paperwork item. Main |
ENGINE PR #266 — Native AUX FX-send / return-fader production milestone, 1 Nov 2026
HEAD:
40a059785993cc6a4bb593020bf9749de92746f9; exact-head Windows CI #41303154353 pending. This PR remains DRAFT.Implemented in actual one JUCE callback: PRE/POST AUX send-level changes now alter genuine native PCM. Prior code incorrectly kept static AUX dispatch after an accepted atomic gain edit. The DSP keeps optimized compiled static dispatch until first send automation, then uses target-driven 64-sample gain ramps across callback blocks; same plugin instance, no restart. A second post-VST3 AUX1–4 return fader is now reachable through native
SET_AUX_FADERand smooths over 64 samples, even with short ASIO buffers, before MAIN/MONITOR. Existing nativeSET_SEND_LEVELhandler is deduplicated.Installed renderer:
LiveAudioEngine::audioDeviceIOCallbackWithContext → LiveDryRoutingLab → LiveChannelFxGraph → PreparedMixerBlock(legacy M4 fixed 10 inputs+4 AUX); preserves occupied CH01 vendor/Orbit/editor, CH2–10 hosted VST3 and Show. No fake JS audio or dual callback.Universal readiness: FALSE; no stable ChannelId callback cutover, dynamic CH11, real serial Group/wet FX Return; canonical universal
supportedOps=[]. S0 fixture hash unchanged:4cbded2c7ada3be511c0e9a09b1949979638eb274c432f89b673a98ce55c7718. No customer UAT or HW crackle certification. Complete ENGINE #192 handoff.ENGINE current checkpoint — PRD/ARD v5.2, 2026-11-01
HEAD:
157bf6950b6cf3943b60ea45daf6e142a9f14cb7; basemain@fe3f8add; Windows native exact-head run #41286591056 in progress — PASS NOT YET VERIFIED.Implemented runtime DSP:
PreparedMixerBlock::processnow carries a fixed 64-sample MUTE/PRE-send transition across variable 4/16/32-frame JUCE callback blocks (zero callback allocations/locks).NativeVerifiedSourcePatchnow emits complete schema-v2 SOURCE fields without confusing mono physical capture with stereo processing.LiveDryRoutingLab::repatchPhysicalSourcealready routes SOURCE through actual accepted M4 FX graph/Show/MAIN/Monitor path with prepared-state rollback and vendor lease reuse.Expanded native tests: accepted one physical pin → CH07 → MAIN PCM, channel MUTE fade and steady silence, native JUCE
GainFxinstance lifetime unchanged across pin switch 5→7, old graph retirement, sample amplitudes/zero-heap renderer. This in-memory JUCE processor test is not physical vendor VST3 or hardware evidence.S0 native four-event fixture SHA-256:
4cbded2c7ada3be511c0e9a09b1949979638eb274c432f89b673a98ce55c7718;ARMixLiveChannelFxTests.exe --emit-console-s0-json; no schema changes. GUI/FAT joint exact-head consumer gate still required.Critical limitation:
LiveAudioEngine::audioDeviceIOCallbackWithContextstill invokes M4dryRoutingLab_.process(...processLegacyChannelOne); native v8 universalsupportedOps=[]andproductionCallbackLive=false. NO ChannelId callback cutover, CH11, serial Group, wet FX Return, or hardware/click/crackle release PASS. Remain DRAFT. Integration owner #270 must not claim product UAT. Owner handoff #192.PUZZLE A S0 native producer checkpoint — v8 (1 November 2026)
HEAD
7a3c1e082c5b079056aa69af95ee54f23387470e(reconciled current v8 main atfe3f8add). Exact shared 4-event C++-generated fixture SHA-2564cbded2c7ada3be511c0e9a09b1949979638eb274c432f89b673a98ce55c7718.engine/core/ConsolePuzzleV8Wire.his included by real JUCEsrc/ConsoleLiveBridgeV6.h. Existing native test executableARMixLiveChannelFxTests.exe --emit-console-s0-jsonnow emits EXACT v8Snapshot → Intent → Rejected ACK → Snapshotcontract for FAT #270, with byte-equality checks against the native adapter. Local GNU C++20 generator negative checks + strict v8 four-event schema/ACK validation passed. Windows MSVC/CTest exact-head #41279178032 in progress; no PASS claim until completion.Capability boundary: installed
LiveAudioEngine::audioDeviceIOCallbackWithContextSTILL renders original M4dryRoutingLab_.process(...processLegacyChannelOne).productionCallbackLive=false, no universal ChannelIds,supportedOps=[]; CH11/Group/wet FX Return/Show parity under ChannelId NOT IMPLEMENTED. No hardware crackle claim, no customer UAT. S0 only becomes GREEN after GUI #271 and FAT #270 consume the exact native-generated trace on same SHA, not mock adapter. Engine S1 remains high-priority blocked by that integration gate and occupied CH01 vendor ownership/Show parity.Owner handoff (issue #192): #192 (comment)
Latest ENGINE checkpoint — 4e80c4b (M-U1 migration fidelity)
8364d53epassed Windows 41266492864 including MSVC/CTest and verified packaging. Current SHA4e80c4b561e3625b7515f25d3a6fffb2f719961chas Windows 41267321438 in progress; its outcome has not been inferred.main@bb6dff6b10CH+4AUX Windows artifact 41263965810; [ENGINE SOLE OWNER] One native callback → full-fidelity ChannelId cutover (draft) #266 CI deliberately does not upload a PR artifact. Do not describe the M4 artifact as a universal ChannelId shipping executable.LiveAudioEnginecallback cutover, vendor/Orbit editor and Show state lifetime under swaps, M4 live mute/solo/source/FX update parity, secondary output pin/meter fidelity. CH11/Group/wet Return/MONITOR still offline on [ENGINE SOLE OWNER] One native callback → full-fidelity ChannelId cutover (draft) #266, no native capability may advertise them yet. Hardware P0 — Crackling with 0 VST3: diagnose WASAPI clock/input/output buffering before engine expansion #15 remains open.Engine v6 checkpoint — source-grounded (2026-11-01)
Head:
8364d53e387c4a5eb2ffa929bf7bb0791c27efff— DRAFT, NOT PRODUCTION CALLBACK CUTOVER. Native Windows validation: workflow 41266492864 (running at checkpoint; do not infer PASS).main@b911c072as a two-parent commit, retaining main's unpatched FX silent-preparation and FAT-X tests. Main has since moved one docs-only commit; keep reconciling before merge.DynamicChannelFxLeaseBank::ExternalLease+ M-U1 admission of occupied CH1 external processor owner on the acceptedChannelIdgraph, rejecting missing/stale/aliased owner and incompatible native CH1 rack. One RT dispatch, no callback refcount or duplicated vendor FX.GainFxPCM golden parity of M4 external vs dynamic publisher, owner survival after old graph retirement, bounded RT allocation and stale-epoch fail-silent test.LiveAudioEngine::audioDeviceIOCallbackWithContextswitch, original occupied vendor/Orbit host Graph lease construction, realtime controls/Show state wired into one publisher, physical CH11/Group/Return/monitor hardware proof or P0 — Crackling with 0 VST3: diagnose WASAPI clock/input/output buffering before engine expansion #15 crackle FAT. No +CHANNEL capability/LIVE flag is authorized by this PR yet.Current exact-head milestone (2026-11-01)
M5 + M-U1 full 10CH/4AUX candidate in ONE native PCM+VST3 publisher:
UnifiedLegacyProductionAdmission.hconsumes the existing legacy graph migration and exact hardware callback pin pairs, transfers real M4 plugin owners (CH1–10+AUX1–4), preserves MAIN/MONITOR PCM and PRE/POST sends, commits an epoch/revision-bound immutable snapshot, and rejects external CH1/Orbit, hotplug, output alias, and armed output without altering previous accepted audio. New native golden comparison uses real JUCE GainFx before/after legacy-owner retirement. Still not yet the actual production callback cutover and not hardware FAT. Exact-head Windows CTest: https://github.com/masarray/arsonmix/actions/runs/41252951831 — pending. The previous M5 core snapshot atf34334a3passed Windows CTest: https://github.com/masarray/arsonmix/actions/runs/41252379363.M5 — substantive universal VST3 owner migration toward Studio Console
The real M4 processor state/identity must survive the universal ChannelId graph: karaoke/live Show users must NOT be forced to remove all FX to use a Group (#263 M3E dry-only). This PR replaces that missing seam with a stable native
ChannelId → VST3 rack ownerconversion, not a fake GUI +BUS or another audio callback.Changes
DynamicChannelFxLeaseBank: one control-thread prepared, immutable owner map across CH1, CH11+, GROUP and FX Return. Retains the actual M4LiveChannelFxGraph::FxInstanceobject via its opaque instance token and shared owner only off realtime. Keeps parameter state, reverb tail, bypass, native VST3 editor and device preparation, no catalog reload.ChannelId, looks up immutable rack and calls native JUCE processor(s) once per PCM graph node. No callback refcount, mutex, allocation, VST scan or plugin clone. Reject invalid/duplicate ID, reused simultaneous processor, missing lease, invalid format or nonstereo vendor bus.LiveDryRoutingLab::captureDynamicFxLeasesexports M4's actual accepted CH1..10 + four AUX racks guarded by exact device epoch/revision; no effect on live M4 path.juce::AudioProcessor, then independent Group FX and parallel FX Return POST SEND each with native FX; verifies actual output samples/no doubled dry, Group fader changes, stable M4 opaque token across old graph retirement, zero heap in audio render, stale device fail-silent and duplicate-plugin reject. Uses existing MSVC CTest target to avoid CI fanout.Integration truth / dependencies
This is the universal native VST3 bridge for M4→M5, not yet the actual replacement of M4's production callback. #263 dry-only pilot stays DRAFT: cannot be merged into a user's normal VST/AUX/MONITOR Show as-is. Next vertical integration must publish this bank as part of the same prepared dynamic PCM snapshot, transfer the special CH1 external FX owner, retain AUX/PRE/POST/MONITOR/secondary output and real Show, then expose dynamic channel strips. Source details & FAT gates in M5 engineering document.
Studio/Fender Console: https://fenderstudiopromanual.fender.com/en/Content/Mixing_Topics/The_Console.htm
Waves eMotion LV1: https://www.waves.com/emotion-lv1-tutorial-4-2-mixer-channels-groups-aux
Related #192 #263 #265 #15.
Merge gate: exact-head Windows native MSVC + CTest pass, no device/GUI regression. Avoid unnecessary new workflows or duplicate CI.
Coordination #397 — workstream ownership
SOLE ENGINE PCM producer; continue engine-owned files. Hand off Main.cpp, CMake and native bridge edits to INTEGRATOR #397.