Repository navigation
P0: one fail-closed Product Qualification check + precise native Windows CI coverage - #407
Conversation
|
FAT-owner coordination from independent M3-E #406, exact HEAD Windows Node gate #41924085798 currently reads 236 PASS, 1 FAIL: the only failing test is the known M2.6 CRLF-sensitive For your new Product Qualification native-scope gate, please confirm a FAT PR changing Once #407 passes and merges, FAT #406 will reconcile with its main SHA and rerun the single exact-head Windows contract/CTest before any merge; physical hardware #15 stays PENDING. |
Codex Review SummaryThis comment shows the latest Codex review activity on this pull request.
ℹ️ About Codex in GitHubYour team has set up Codex to review pull requests in this repo. Reviews are triggered when you
Codex reacts with 👀 while any review is running, comments if it has suggestions, and reacts with 👍 once all reviews finish with no findings. |
…epair PowerShell verifier and two-rate field safety
P0 CI hardening — single product qualification, no duplicate Windows build
Base main:
6b51caf07dd4ae04047c04717adcb3f53e3f673fHead SHA:
9a4e441610d520f982f144b7e8ac6f3ca3a77fbeOwner: INTEGRATOR. Other active owners (#266 ENGINE, #402 M3 INTEGRATOR, FAT) remain untouched.
Implementation
ui-smoke.yml; policy preflight now classifiesrun_uiandrun_nativefrom exact GitHub PR changed filenames.p1-windows.ymlis now reusable viaworkflow_callfor PRs, invoked once only for a qualified native scope; existing push-main and manual packaging retained. No duplicated Windows PR trigger/runner; no new workflow.Product Qualificationfan-in rejects failed/skipped/cancelled required domain jobs; requires real Chromium PASS for GUI changes, Windows/JUCE/CTest PASS for native changes, both for bridge, coordination only for docs.integration/**/*.h/.hpp/.cppand release-admission scripts, with matching native main push trigger expansion.Acceptance / do not merge prematurely
PR coordination admissionPASS,Product QualificationPASS, actual nested Windows/JUCE CTest PASS and Chromium PASS if invoked./preview/, one native callback, existing routing controls, no additional audio implementation or release claim.Manual admin task AFTER first successful check appears
Add GitHub Actions check
Product Qualificationto main ruleset, alongside existingPR coordination admission, retainstrict_required_status_checks_policy=true. GitHub App cannot configure rulesets.WORKSTREAM: INTEGRATOR
OWNED FILES CHANGED:
scripts/check_workstream_coordination.mjs, 2 existing contract tests, existing Chromium/Windows workflows,docs/workstreams/MULTI_AGENT_COORDINATION.md.NATIVE ABI: unchanged.
BLOCKER: exact-head CI and admin ruleset selection.
NEXT SINGLE MEANINGFUL MILESTONE: production M3-D
#402+ ENGINE PCM#266joined exact-head native sound.