Repository navigation
First Real Sound: native ChannelId GUI controls → actual JUCE PCM mutation - #408
Conversation
…tive ACK/readback
|
FAT coordination notice: current base ENGINE |
…tegration candidate
Codex Review SummaryThis comment shows the latest Codex review activity on this pull request.
ℹ️ About Codex in GitHubYour team has set up Codex to review pull requests in this repo. Reviews are triggered when you
Codex reacts with 👀 while any review is running, comments if it has suggestions, and reacts with 👍 once all reviews finish with no findings. |
There was a problem hiding this comment.
💡 Codex Review
Here are some automated review suggestions for this pull request.
Reviewed commit: 22c5f31a4f
ℹ️ About Codex in GitHub
Your team has set up Codex to review pull requests in this repo. Reviews are triggered when you
- Open a pull request for review
- Mark a draft as ready
- Comment "@codex review".
If Codex has suggestions, it will comment; otherwise it will react with 👍.
Codex can also answer questions or update the PR. Try commenting "@codex address that feedback".
| const bool applied=!replay&&translated.ok()&& | ||
| armix::console::executeApprovedNativeControl(engine_,translated.translated); |
There was a problem hiding this comment.
Keep Show capture synchronized with accepted native controls
For the original CH1–10 topology, an accepted fader/PAN/mute/solo edit now calls the native setters directly, which update the PCM target and native roster but not LiveDryRoutingLab::channelEdits_. However, LiveDryRoutingLab::status() still builds channelControls from channelEdits_, and NativeLiveShowCapture::captureDry() saves those values rather than the native roster. Because a nonstructural control edit does not set nativeBusStructural, the existing routingDryShowSave handler permits the save and silently records the pre-edit controls; recalling that Show can therefore restore an old gain or unmute a channel the user saved muted. Synchronize the original-channel save baseline after successful mutations, or make Show capture read the accepted native controls.
AGENTS.md reference: AGENTS.md:L30-L30
Useful? React with 👍 / 👎.
|
P0 AUDIO USER ESCALATION (INTEGRATOR owner) — real Windows native screenshot reports no sound. Operator Windows screenshot 2026-11-05 08:12 WIB: top native AR MIX Studio, bottom "Stopped | NATIVE G0 - perangkat aktual terbaca; ChannelId PCM/WIRE belum diterima. Edit audio diblokir", right "SIMULATED METERS - NO REAL AUDIO". Operator explicitly reports NO AUDIO. This is a REAL PRODUCT FAILURE, not an optional FAT paperwork item. Main |
Accept qualified sole ENGINE producer with original CH1-10 and dynamic ChannelId PCM, genuine native bus readback, single callback, VST3 leases and original AUX/Show. Windows/MSVC/CTest and scoped Product Qualification passed on exact engine source head efe8f49. Preserve ancestry for stacked INTEGRATOR #408. Physical hardware FAT remains pending.
…m, truthful native footer
FIRST REAL SOUND — direct product code, stacked on sole ENGINE #266
Base ENGINE commit:
e15aefec648f7450e6f2d2afa1c6397dd5f68395Exact INTEGRATOR commit:
e37dcc23c64bcc9292fed35b7290b8241bd24567Approved GUI: https://masarray.github.io/arsonmix/preview/ unchanged
This is a temporary stacked PR against the active sole ENGINE branch #266, not a second PCM owner or duplicate renderer. Once #266's selective core code passes MSVC/CTest and is merged on current main, retarget this same PR to
main(no new PR). The PR's own change set is only four INTEGRATOR files:src/Main.cpp,integration/ApprovedNativeControlIntent.h,integration/ApprovedNativeRuntimeSnapshot.h,tests/approved_native_v8_projection_test.cpp.Actual code
arMixConsoleIntentWebView2 event now invokestranslateApprovedNativeControland the same installed ENGINE settersetNativeInputMix,setNativeInputMuteSoloorsetNativeBusMixfrom the one JUCE callback producer.SET_FADER/PAN/MUTE/SOLOafter the true native callback positively admits and exposes matching native operations, never for G0/legacy/static JSON. WIRE remains gated (no fake supportedOps).productionCallbackLiveintentionally false until FAT.Test / release guard
No new governance milestone, no second engine/callback, no new GUI, no force-push, no raw historical merge.