Skip to content

First Real Sound: native ChannelId GUI controls → actual JUCE PCM mutation - #408

Merged
masarray merged 6 commits into
mainfrom
integration/first-real-sound-native-control-20261105
Nov 5, 2026
Merged

masarray merged 6 commits into
mainfrom
integration/first-real-sound-native-control-20261105

Conversation

@masarray

@masarray masarray commented Nov 5, 2026

Copy link
Copy Markdown
Owner

FIRST REAL SOUND — direct product code, stacked on sole ENGINE #266

Base ENGINE commit: e15aefec648f7450e6f2d2afa1c6397dd5f68395
Exact INTEGRATOR commit: e37dcc23c64bcc9292fed35b7290b8241bd24567
Approved GUI: https://masarray.github.io/arsonmix/preview/ unchanged

This is a temporary stacked PR against the active sole ENGINE branch #266, not a second PCM owner or duplicate renderer. Once #266's selective core code passes MSVC/CTest and is merged on current main, retarget this same PR to main (no new PR). The PR's own change set is only four INTEGRATOR files: src/Main.cpp, integration/ApprovedNativeControlIntent.h, integration/ApprovedNativeRuntimeSnapshot.h, tests/approved_native_v8_projection_test.cpp.

Actual code

  • Existing approved arMixConsoleIntent WebView2 event now invokes translateApprovedNativeControl and the same installed ENGINE setter setNativeInputMix, setNativeInputMuteSolo or setNativeBusMix from the one JUCE callback producer.
  • Canonical uint64 decimal ID/epoch/revision decoding, validation, stale revision/role/capability rejection, original linear gain preservation, bounded replay defense.
  • Only advertise SET_FADER/PAN/MUTE/SOLO after the true native callback positively admits and exposes matching native operations, never for G0/legacy/static JSON. WIRE remains gated (no fake supportedOps).
  • ACK accepted only on genuine setter success and a still-installed callback; no immediate optimistic snapshot. Existing browser asks for LATER readback and verifies the actual channel state before repaint.
  • Existing approved preview art, native VST3, FX, M4 routing, CI workflow, FAT packaging remain untouched. Product productionCallbackLive intentionally false until FAT.

Test / release guard

No new governance milestone, no second engine/callback, no new GUI, no force-push, no raw historical merge.

masarray commented Nov 5, 2026

Copy link
Copy Markdown
Owner Author

FAT coordination notice: current base ENGINE e15aefec failed exact-head Windows 41941850022 due to tests/live_channel_fx_graph_test.cpp:8 including missing ../src/ConsoleLiveBridgeV6.h (C1083). I handed the fix to ENGINE #266, not applying cross-owner edits. M3F #408 should not claim joined PCM PASS until that producer compiles and passes CTest. FAT #406 remains independent and is testing its own Windows evidence collector; physical hardware #15 PENDING.

@masarray
masarray marked this pull request as ready for review November 5, 2026 01:05
@chatgpt-codex-connector

chatgpt-codex-connector Bot commented Nov 5, 2026 •

Copy link
Copy Markdown

Codex Review Summary

This comment shows the latest Codex review activity on this pull request.

Review Status Commit Review trigger
📝 Code Review ✅ Completed 2026-11-05T01:07:56.249165Z 22c5f31 Draft marked ready
ℹ️ About Codex in GitHub

Your team has set up Codex to review pull requests in this repo. Reviews are triggered when you

  • Open a pull request for review
  • Mark a draft as ready
  • Comment "@codex review" or "@codex security review".

Codex reacts with 👀 while any review is running, comments if it has suggestions, and reacts with 👍 once all reviews finish with no findings.

@chatgpt-codex-connector chatgpt-codex-connector Bot left a comment

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

💡 Codex Review

Here are some automated review suggestions for this pull request.

Reviewed commit: 22c5f31a4f

ℹ️ About Codex in GitHub

Your team has set up Codex to review pull requests in this repo. Reviews are triggered when you

  • Open a pull request for review
  • Mark a draft as ready
  • Comment "@codex review".

If Codex has suggestions, it will comment; otherwise it will react with 👍.

Codex can also answer questions or update the PR. Try commenting "@codex address that feedback".

Comment thread src/Main.cpp
Comment on lines +741 to +742
const bool applied=!replay&&translated.ok()&&
armix::console::executeApprovedNativeControl(engine_,translated.translated);

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

P1 Badge Keep Show capture synchronized with accepted native controls

For the original CH1–10 topology, an accepted fader/PAN/mute/solo edit now calls the native setters directly, which update the PCM target and native roster but not LiveDryRoutingLab::channelEdits_. However, LiveDryRoutingLab::status() still builds channelControls from channelEdits_, and NativeLiveShowCapture::captureDry() saves those values rather than the native roster. Because a nonstructural control edit does not set nativeBusStructural, the existing routingDryShowSave handler permits the save and silently records the pre-edit controls; recalling that Show can therefore restore an old gain or unmute a channel the user saved muted. Synchronize the original-channel save baseline after successful mutations, or make Show capture read the accepted native controls.

AGENTS.md reference: AGENTS.md:L30-L30

Useful? React with 👍 / 👎.

masarray commented Nov 5, 2026

Copy link
Copy Markdown
Owner Author

P0 AUDIO USER ESCALATION (INTEGRATOR owner) — real Windows native screenshot reports no sound.

Operator Windows screenshot 2026-11-05 08:12 WIB: top native AR MIX Studio, bottom "Stopped | NATIVE G0 - perangkat aktual terbaca; ChannelId PCM/WIRE belum diterima. Edit audio diblokir", right "SIMULATED METERS - NO REAL AUDIO". Operator explicitly reports NO AUDIO. This is a REAL PRODUCT FAILURE, not an optional FAT paperwork item.

Main 5f4915680b7a1406c8565620041e517f568a5d7d still intentionally calls armix::native_console_m2::reject() on EVERY arMixConsoleIntent (Main.cpp native WebView event), so the user's G0 status is expected despite green EXE/ZIP CI. Your active #408 22c5f31a4fa9c57acac935cb9f1618a466859acb switches this to handleApprovedNativeControl(args) but is stacked on still-unmerged ENGINE #266. Please repair your unresolved P1 first: accepted native fader/PAN/MUTE/SOLO edits are NOT reflected in LiveDryRoutingLab::channelEdits_/original Show capture, so Save/Recall can silently restore pre-edit levels. Keep owner-only Main.cpp/integration changes, no alternate GUI/callback; then qualify joined exact HEAD on Windows JUCE/CTest, merge ENGINE FIRST and #408 second with fresh base. Publish executable sourceSHA and ACTUAL sound/ACK evidence. QA/packaging PASS is not Native Sound PASS; don't send G0 build as runnable mixer.

masarray added a commit that referenced this pull request Nov 5, 2026
Accept qualified sole ENGINE producer with original CH1-10 and dynamic ChannelId PCM, genuine native bus readback, single callback, VST3 leases and original AUX/Show. Windows/MSVC/CTest and scoped Product Qualification passed on exact engine source head efe8f49. Preserve ancestry for stacked INTEGRATOR #408. Physical hardware FAT remains pending.
@masarray
masarray changed the base branch from milestone/m5-universal-channelid-vst3-lease-migration-20261101 to main November 5, 2026 01:17
@masarray
masarray merged commit 6084d1e into main Nov 5, 2026
4 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant