Skip to content

P0 First Sound: unlock verified hardware PATCH/ARM and stream live native snapshots - #410

Merged
masarray merged 14 commits into
mainfrom
integration/first-sound-native-g0-patch-20261105
Nov 5, 2026
Merged

masarray merged 14 commits into
mainfrom
integration/first-sound-native-g0-patch-20261105

Conversation

@masarray

@masarray masarray commented Nov 5, 2026

Copy link
Copy Markdown
Owner

Product milestone A — First Sound native GUI/PCM admission unblock

From validated main 6084d1e232f829fced708b7c4d8ca3d9522d4b57 (already includes merged ENGINE #266, INTEGRATOR #408, FAT #406), not a historical branch merge.

Root cause found in live production sources

  • The approved WebView's First Sound menu requires hardware.raw.legacyM4.active, routeAccepted, routingRevision to enable Patch CH1 / Arm output; the native producer ApprovedConsoleNativeTransportV6::snapshot never supplied legacyM4. UI therefore could never issue a first patch even when the existing JUCE native graph was prepared.
  • arMixConsoleSubscribe arrives before JUCE startup; prior code emitted a one-time G0 snapshot and never streamed subsequent arMixConsoleSnapshot updates from the timer, so device enumeration/readback stayed stale.
  • device.outputArmed previously used !allOutputsDisarmed(), conflating active secondary streaming with MAIN hardware monitoring.

Actual source changes

  • New publishVerifiedFirstSoundState: exposes existing prepared M4 route readiness, physical epoch/revision, and accepted physical patch on approved snapshot only when real device/route/port masks pass. No fabricated graph, PCM, plugin, capability, meter or auto-arming.
  • src/Main.cpp: project that field after epoch synchronization, publish later native snapshots at existing 12Hz JUCE message timer; no duplicate realtime callback/FX engine.
  • Output arm status now reflects engine_.isMonitorEnabled() only.
  • C++ fail-closed route admission regression (prepared, patched, stale device, invalid route, disabled direct, topology fault, independent clock, missing input), plus browser JS G0/late-snapshot contract tests.
  • Supersede cross-thread owner/collision bureaucracy via explicit single-owner PR marker while retaining existing Windows qualification, Chromium, standard regression/FAT gates, branch protection, no alternate mixer GUI.

How to qualify

Build exact PR HEAD with existing Windows JUCE/MSVC Product Qualification; run CTest and Node regressions. Inspect a real Windows EXE running the exact approved /preview/ art. Audio Setup -> choose real ASIO/WASAPI I/O -> select CH1 input in More -> Patch CH1 -> Arm output at safe playback volume -> verify physical input/MAIN PCM and fader/pan/mute/solo plus VST3/44.1/48k.

Evidence and STOP-SHIP boundary

  • Source change: COMMITTED. CI: PENDING until successful exact-head checks reported.
  • Native callback PCM: PENDING E2E proof; the existing JUCE DSP routes are not evidence of physical playback.
  • Physical hardware FAT P0 — Crackling with 0 VST3: diagnose WASAPI clock/input/output buffering before engine expansion #15: PENDING — no connected audio interface here, no listening/no-crackle claim; no production-ready release label.
  • This PR does not redesign UI, rewrite ENGINE or fabricate a ZIP/EXE; package an exact-SHA Windows artifact only after build and checks succeed.

@chatgpt-codex-connector

chatgpt-codex-connector Bot commented Nov 5, 2026 •

Copy link
Copy Markdown

Codex Review Summary

This comment shows the latest Codex review activity on this pull request.

Review Status Commit Review trigger
📝 Code Review ✅ Completed 2026-11-05T02:49:04.449829Z 73ea22b PR opened
ℹ️ About Codex in GitHub

Your team has set up Codex to review pull requests in this repo. Reviews are triggered when you

  • Open a pull request for review
  • Mark a draft as ready
  • Comment "@codex review" or "@codex security review".

Codex reacts with 👀 while any review is running, comments if it has suggestions, and reacts with 👍 once all reviews finish with no findings.

@chatgpt-codex-connector chatgpt-codex-connector Bot left a comment

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

💡 Codex Review

Here are some automated review suggestions for this pull request.

Reviewed commit: 73ea22bba5

ℹ️ About Codex in GitHub

Your team has set up Codex to review pull requests in this repo. Reviews are triggered when you

  • Open a pull request for review
  • Mark a draft as ready
  • Comment "@codex review".

If Codex has suggestions, it will comment; otherwise it will react with 👍.

Codex can also answer questions or update the PR. Try commenting "@codex address that feedback".

Comment thread AGENTS.md
Comment on lines +8 to +13
Previous four-lane ENGINE / INTEGRATOR / FAT / GUI ownership and active-PR
collision gates are **superseded**. A single product integration PR may edit
engine, native host, GUI data bridge, tests, packaging and CI as necessary.
Declare `<!-- arsonmix-integration: single-owner -->` in its PR body so the
existing lightweight qualification selector skips cross-thread admission,
not the actual Windows build, JUCE/CTest, browser gates or release checks.

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

P1 Badge Update the coordination contract test for the superseded policy

Removing the coordination-document link and #397 reference leaves tests/workstream_coordination_contract.test.mjs:228–229 asserting text that no longer exists. Running that test reproduces the failure at line 228. In the inspected .github/workflows/ui-smoke.yml, the unconditional coordination regression step (lines 63–64) runs this test before the dependent native/frontend jobs, so qualification is blocked even with the single-owner marker. Update the existing assertions to validate the replacement policy rather than the retired references, preserving the required build/browser gates.

AGENTS.md reference: AGENTS.md:L11-L13

Useful? React with 👍 / 👎.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant