Repository navigation
P0 First Sound: unlock verified hardware PATCH/ARM and stream live native snapshots - #410
Conversation
…tartup and hotplug
Codex Review SummaryThis comment shows the latest Codex review activity on this pull request.
ℹ️ About Codex in GitHubYour team has set up Codex to review pull requests in this repo. Reviews are triggered when you
Codex reacts with 👀 while any review is running, comments if it has suggestions, and reacts with 👍 once all reviews finish with no findings. |
There was a problem hiding this comment.
💡 Codex Review
Here are some automated review suggestions for this pull request.
Reviewed commit: 73ea22bba5
ℹ️ About Codex in GitHub
Your team has set up Codex to review pull requests in this repo. Reviews are triggered when you
- Open a pull request for review
- Mark a draft as ready
- Comment "@codex review".
If Codex has suggestions, it will comment; otherwise it will react with 👍.
Codex can also answer questions or update the PR. Try commenting "@codex address that feedback".
| Previous four-lane ENGINE / INTEGRATOR / FAT / GUI ownership and active-PR | ||
| collision gates are **superseded**. A single product integration PR may edit | ||
| engine, native host, GUI data bridge, tests, packaging and CI as necessary. | ||
| Declare `<!-- arsonmix-integration: single-owner -->` in its PR body so the | ||
| existing lightweight qualification selector skips cross-thread admission, | ||
| not the actual Windows build, JUCE/CTest, browser gates or release checks. |
There was a problem hiding this comment.
Update the coordination contract test for the superseded policy
Removing the coordination-document link and #397 reference leaves tests/workstream_coordination_contract.test.mjs:228–229 asserting text that no longer exists. Running that test reproduces the failure at line 228. In the inspected .github/workflows/ui-smoke.yml, the unconditional coordination regression step (lines 63–64) runs this test before the dependent native/frontend jobs, so qualification is blocked even with the single-owner marker. Update the existing assertions to validate the replacement policy rather than the retired references, preserving the required build/browser gates.
AGENTS.md reference: AGENTS.md:L11-L13
Useful? React with 👍 / 👎.
Product milestone A — First Sound native GUI/PCM admission unblock
From validated main
6084d1e232f829fced708b7c4d8ca3d9522d4b57(already includes merged ENGINE #266, INTEGRATOR #408, FAT #406), not a historical branch merge.Root cause found in live production sources
hardware.raw.legacyM4.active,routeAccepted,routingRevisionto enable Patch CH1 / Arm output; the native producerApprovedConsoleNativeTransportV6::snapshotnever suppliedlegacyM4. UI therefore could never issue a first patch even when the existing JUCE native graph was prepared.arMixConsoleSubscribearrives before JUCE startup; prior code emitted a one-time G0 snapshot and never streamed subsequentarMixConsoleSnapshotupdates from the timer, so device enumeration/readback stayed stale.device.outputArmedpreviously used!allOutputsDisarmed(), conflating active secondary streaming with MAIN hardware monitoring.Actual source changes
publishVerifiedFirstSoundState: exposes existing prepared M4 route readiness, physical epoch/revision, and accepted physical patch on approved snapshot only when real device/route/port masks pass. No fabricated graph, PCM, plugin, capability, meter or auto-arming.src/Main.cpp: project that field after epoch synchronization, publish later native snapshots at existing 12Hz JUCE message timer; no duplicate realtime callback/FX engine.engine_.isMonitorEnabled()only.single-ownerPR marker while retaining existing Windows qualification, Chromium, standard regression/FAT gates, branch protection, no alternate mixer GUI.How to qualify
Build exact PR HEAD with existing Windows JUCE/MSVC Product Qualification; run CTest and Node regressions. Inspect a real Windows EXE running the exact approved
/preview/art. Audio Setup -> choose real ASIO/WASAPI I/O -> select CH1 input in More -> Patch CH1 -> Arm output at safe playback volume -> verify physical input/MAIN PCM and fader/pan/mute/solo plus VST3/44.1/48k.Evidence and STOP-SHIP boundary