Skip to content

P0 First Sound: real RAW input and MAIN PCM diagnostics in native mixer - #411

Merged
masarray merged 8 commits into
mainfrom
integration/first-sound-signal-evidence-20261105
Nov 5, 2026
Merged

masarray merged 8 commits into
mainfrom
integration/first-sound-signal-evidence-20261105

Conversation

@masarray

@masarray masarray commented Nov 5, 2026

Copy link
Copy Markdown
Owner

Meaningful milestone — first sound is diagnosable instead of an unexplained silent mixer

Builds directly on merged #410 (main 7ad33efc4c2d6b9fbc2bf139404692414316ac21). Uses ONE production JUCE audio callback and ONE approved /preview/ WebView. No new audio engine, C++ thread, UI or mock PCM.

Observed problem

src/ApprovedConsoleNativeTransportV6.h still hardcoded rawCapturePresent=false, rawCapturePeak=0.0, mainPcmPresent=false for G0 even when the real LiveAudioEngine::status() reported measured callback PCM. This hides the difference between silent source, patch failure, output mute and routed MAIN silence in the FIRST SOUND GUI.

Changes

  • integration/FirstSoundSignalEvidence.h: read-only JUCE message-thread projection of actual callback capture signal, compact callback channel peaks, and post-output-gate MAIN PCM. Fail closed on missing callbacks, bad device/port counts, wrong mode, route fault or disarmed MAIN; UNKNOWN is not falsely shown as 0 measured PCM.
  • Source ApprovedConsoleNativeTransportV6 telemetry from that evidence instead of fake constants. Nothing is generated on the realtime thread, no auto-arm.
  • web/approved-native-contract.js: pure diagnoseFirstSound, associating the chosen physical ASIO input pin with its exact compact JUCE callback ordinal rather than assuming physical pin = callback index. Distinguish capture silent, missing patch, output muted, MAIN silent and post-gate PCM measured.
  • Display compact RAW input / MAIN PCM figures and operator action in existing approved More → First Sound controls. No visual redesign. Explicitly state that MAIN PCM does NOT prove audible speakers.
  • C++ and Node regression tests for verified signal, unpatched capture, muted output, missing/stale callback, sparse pin mapping, and silent MAIN.

Qualification

Windows MSVC/JUCE build + 55+ native CTests, Node contracts, Chromium UI gate, exact /preview/ GUI provenance. Main hardware-FAT ZIP from #410 remains the verified starting candidate until this PR qualifies and merges.

Honesty / stop-ship

No physical audio interface is available to this CI runner. Listening / 0FX 30-minute crackle / ASIO physical MAIN FAT remains PENDING. Do not claim hardware PASS or a stable product release based on source-only telemetry.

@chatgpt-codex-connector

chatgpt-codex-connector Bot commented Nov 5, 2026 •

Copy link
Copy Markdown

Codex Review Summary

This comment shows the latest Codex review activity on this pull request.

Review Status Commit Review trigger
📝 Code Review ✅ Completed 2026-11-05T03:45:54.562860Z 3f56b97 PR opened
ℹ️ About Codex in GitHub

Your team has set up Codex to review pull requests in this repo. Reviews are triggered when you

  • Open a pull request for review
  • Mark a draft as ready
  • Comment "@codex review" or "@codex security review".

Codex reacts with 👀 while any review is running, comments if it has suggestions, and reacts with 👍 once all reviews finish with no findings.

@chatgpt-codex-connector chatgpt-codex-connector Bot left a comment

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

💡 Codex Review

Here are some automated review suggestions for this pull request.

Reviewed commit: 3f56b97734

ℹ️ About Codex in GitHub

Your team has set up Codex to review pull requests in this repo. Reviews are triggered when you

  • Open a pull request for review
  • Mark a draft as ready
  • Comment "@codex review".

If Codex has suggestions, it will comment; otherwise it will react with 👍.

Codex can also answer questions or update the PR. Try commenting "@codex address that feedback".

Comment on lines +173 to +174
d.outputArmed?(next.admitted?"NATIVE PCM · HARDWARE FAT PENDING":
"MAIN ARMED · PCM NOT YET ADMITTED"):

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

P2 Badge Update the contract assertion for the changed status text

Changing this status text leaves tests/approved_native_m2_contract.test.cjs:449 asserting /REAL NATIVE PCM · FAT PENDING/, which no longer appears in the bridge. Running node --test tests/approved_native_m2_contract.test.cjs fails on that assertion. Both .github/workflows/ui-smoke.yml and .github/workflows/p1-windows.yml run this contract suite, so the change breaks qualification even when the native implementation is otherwise correct. Update the assertion to match the intended new wording.

Useful? React with 👍 / 👎.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant