Repository navigation
Conversation
…ive visible IN selectors from physical ports
…udio I/O and ten-track IN controls
…proved native WebView
…DAW-style per-track selectors
…ve Audio I/O dialog and MAIN input monitor toggle
… masks to native JUCE
… ACK, one setup and monitor
Codex Review SummaryThis comment shows the latest Codex review activity on this pull request.
ℹ️ About Codex in GitHubYour team has set up Codex to review pull requests in this repo. Reviews are triggered when you
Codex reacts with 👀 while any review is running, comments if it has suggestions, and reacts with 👍 once all reviews finish with no findings. |
…epted hardware source
There was a problem hiding this comment.
💡 Codex Review
Here are some automated review suggestions for this pull request.
Reviewed commit: 0e6c0be5da
ℹ️ About Codex in GitHub
Your team has set up Codex to review pull requests in this repo. Reviews are triggered when you
- Open a pull request for review
- Mark a draft as ready
- Comment "@codex review".
If Codex has suggestions, it will comment; otherwise it will react with 👍.
Codex can also answer questions or update the PR. Try commenting "@codex address that feedback".
| const physicalUiIds=(scope?.tracks||[]).filter(t=>t.kind==="audio") | ||
| .slice(0,10).map(t=>String(t.id)); |
There was a problem hiding this comment.
Refresh physical strip identities after native graph projection
Once an admitted native snapshot reaches projection(), it creates replacement tracks through scope.make() and installs them with new UI IDs, but physicalUiIds permanently retains the initial demo IDs. Consequently, subsequent syncDawNativeInputs() calls cannot find the rendered strips, leaving their IN selectors with demo options and no nativeChannel binding; further physical input changes are rejected. An in-memory execution of the bridge reproduced captured IDs 1–10 versus projected IDs 13–22. Rebuild the physical-strip mapping from the accepted projection rather than caching startup identities.
AGENTS.md reference: AGENTS.md:L36-L36
Useful? React with 👍 / 👎.
| function createAudioDeviceDialog(){ | ||
| if(deviceDialog)return deviceDialog; | ||
| const style=document.createElement("style"); | ||
| style.id="armix-native-device-style"; | ||
| style.textContent=` |
There was a problem hiding this comment.
Keep new visual components out of the native-only adapter
Opening Audio I/O settings now renders a separately styled dialog defined entirely inside the native bridge, and syncDawNativeInputs() also injects a new MAIN monitoring button absent from the assembled public preview. These are native-only appearance and interaction changes, not data/event-authority substitutions, so the Windows GUI no longer matches the sole approved /preview/ GUI. AGENTS.md explicitly restricts the adapter to authority changes; introduce any approved visual components in the shared assembled GUI and bind native behavior to those components instead.
AGENTS.md reference: AGENTS.md:L34-L34
Useful? React with 👍 / 👎.
| if(!deviceDraft){ | ||
| deviceDraft={backend:active.backend||types[0]?.name||"", | ||
| captureDevice:active.captureDevice||"",playbackDevice:active.playbackDevice||"", | ||
| sampleRate:0,bufferSize:0}; |
There was a problem hiding this comment.
Initialize device drafts to the displayed endpoint selections
When the inventory has available devices but no active capture/playback names, the draft stores empty strings while fillSelect() visually selects each list's first option. Apply then remains disabled because those empty draft values are not in the device lists. On a backend with only one input or output, the user cannot even trigger a change to select that already-displayed sole option, preventing recovery through the replacement setup dialog. Initialize missing draft endpoints from the selected backend's actual lists, respecting duplex pairing, or synchronize the draft with the populated selects.
Useful? React with 👍 / 👎.
…ports, stale epoch and post-ACK readback
…proved Pages demo output
…trols, bound input transaction timeout
…back and callback PCM meters
…sured PCM meters to native ACK/readback
…ck meters, reject invalid pins
…poch PCM readback
…ontrol ACK feedback
Closes a central UX disconnect in #412. Built on HEAD
e477b3eand merged #411, not historical feature branches.Source-grounded root cause
The actual shipped
/preview/WebView2 bundle loads onlyweb/approved-native-bridge.jsand its transport contract, not the legacyweb/mixer-io.js/monitor.jssetup/routing UI. Its approved on-stripINdropdown was still a browser DEMO control that native G0 intercepted as unsupported; only separate More > PATCH CH1 > ARM was wired. This was why the app remained complicated and why changing unshipped mixer-io.js would not solve the operator's screenshots.One integrated DAW workflow, no second DSP or GUI
INselector on CH1–CH10 uses verified mono and adjacent stereo hardware ports, and sends the exact selected strip ordinal to the existingroutingSourceSwitchreal DSP kernel. Uses native epoch/revision and source ACK/readback; no patch-wizard, no JS virtual audio engine. Nonadjacent advanced stereo routing is out of scope.audioDeviceInventoryandaudioDeviceApplyevents. Existing stock JUCEAudioDeviceSelectorComponentremains available in source for advanced recovery, not the default operator workflow.I ON / I OFFswitch on MAIN offers a single explicit monitoring control; native preflight still rejects wrong output, stale device, or unaccepted routing. Hardware reconfiguration internally mutes output before changing device, without putting the user through a multi-step START/ARM sequence.Actual ten-channel + MAIN mixing control (not merely selectors)
requestId, exact device epoch/revision, verified native ACK plus a subsequent producer readback before the GUI displays acceptance. Fail/reopen/hotplug rolls back the view, with no UI-owned audio DSP. The normal fader/pan/mute/solo workflow is no longer blocked merely because newer universal ChannelId graph is not admitted.routingM4ChannelControldelegates to the existingLiveDryRoutingLab::setChannelParameter;routingM4MasterControldelegates to existingLiveAudioEngineatomic MASTER controls. Main volume and panic MUTE remain usable without extra START wizard.Qualification and stop-ship
Windows MSVC/JUCE build + 55 native tests, JS native contracts, approved GUI provenance and Chromium. Real live performance hardware FAT remains pending: wired MAIN output, source/fader/mute, 0FX ≥30 minutes and VST3. Do not mark product ready based only on CI. Do not merge until exact head checks pass.
Adobe benchmarks: https://helpx.adobe.com/audition/desktop/importing-recording-and-playing/recording-audio.html ; https://www.image-line.com/fl-studio-learning/fl-studio-online-manual/html/mixer.htm
2026-11-08 reconciliation: ARCHIVED, NOT MERGED
Superseded competing first-sound branch based on pre-#418 source. Current main has one native approved input/WIRE/ACK flow; retaining this as an active merge candidate risks regressing newer routing code. Keep user acceptance questions in #412.
Current authority: main, #418. Historical branch retained; hardware FAT not inferred.