Skip to content

P0 DAW workflow: native hardware IN on every mixer strip, one Audio I/O entrypoint - #420

Closed
masarray wants to merge 15 commits into
mainfrom
integration/daW-direct-input-workflow-20261105
Closed

masarray wants to merge 15 commits into
mainfrom
integration/daW-direct-input-workflow-20261105

Conversation

@masarray

@masarray masarray commented Nov 5, 2026 •

Copy link
Copy Markdown
Owner

Closes design/workflow items in #412; builds on merged #410 / #411, current main 591444d.

User-reported failure

The approved mixer displays a familiar DAW-style IN row but it contains IN None demo choices. A second mini native hardware selector was appended to .ch-id, while More > First Sound offered CH1-only Patch + ARM + a giant generic JUCE device selector. This contradicts Audition / FL Studio's one-per-strip hardware input selection. The existing web/mixer-io.js and web/monitor.js already contain a guarded all-channel source controller with atomic same-format input crossfades and safe structural MUTE/route ACK/re-arm sequencer; the missing part was using those controls in the expected visible strip.

Real code change

  • Replace the native WebView only select.route-select[data-field="input"] (demo input) with select.route-select.arChannelQuickInput, visually in the same existing IN row on every source strip. decorate()/refreshStrip()/changeSource()/commitSourceInOneGesture use the single existing verified M4 routing authority for CH01–CH10. Multiple channels can select the same physical pin if needed. Never guess an ASIO pin.
  • Remove duplicate CH-header picker; match existing compact CSS IN row. /preview/ public DOM/skin remains unchanged; native generated bundle keeps exact approved source provenance.
  • Main status shows actual playback endpoint, marks known VB-Cable playback as VIRTUAL / NO SPEAKERS, rather than “Output armed” without destination.
  • More > Audio I/O now opens the existing custom WebView overlay backed by the real native Device Apply ACK instead of a second generic JUCE dialog; generic JUCE driver settings are still available under collapsed Advanced diagnostics, alongside legacy First Sound controls.
  • Regress native per-strip selector placement regression; do not introduce another audio callback, JS PCM, new process or plugin graph.

DAW reference

Adobe Audition: hardware Input is selectable on every mixer track; input-monitoring [I] is not recording [R]. https://helpx.adobe.com/audition/desktop/importing-recording-and-playing/recording-audio.html
FL Studio: external audio input selector on every mixer track. https://www.image-line.com/fl-studio-learning/fl-studio-online-manual/html/mixer.htm

Qualification

Use existing Chromium geometry, UI/node contracts, Windows JUCE/MSVC and native CTest exact SHA. Validate CH01, CH05, CH10 have independent source selectors; Mono IN1, Stereo IN1/2 and None; live same-format input source switch; first source selection and output not requiring a separate operator Patch/Arm/Start; output driver hotplug safe. Physical sound, 44.1/48k and 30min clean 0FX FAT remain PENDING.

Do not merge on red CI; existing advanced controls are a recovery fallback only; product is not hardware certified.

SUPERSEDED (2026-11-05): Single approved operator target is compiled /preview/ inside native JUCE WebView2, NOT the legacy standalone web/mixer-io.js. Actual 10-channel native I/O and safety ACK changes live in #418. Closing this competing PR to avoid a conflicting/duplicate UI workflow; do not merge this standalone-only approach.

@chatgpt-codex-connector

chatgpt-codex-connector Bot commented Nov 5, 2026 •

Copy link
Copy Markdown

Codex Review Summary

This comment shows the latest Codex review activity on this pull request.

Review Status Commit Review trigger
📝 Code Review ✅ Completed 2026-11-05T08:43:21.845019Z 78cc926 PR opened
ℹ️ About Codex in GitHub

Your team has set up Codex to review pull requests in this repo. Reviews are triggered when you

  • Open a pull request for review
  • Mark a draft as ready
  • Comment "@codex review" or "@codex security review".

Codex reacts with 👀 while any review is running, comments if it has suggestions, and reacts with 👍 once all reviews finish with no findings.

@chatgpt-codex-connector chatgpt-codex-connector Bot left a comment

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

💡 Codex Review

Here are some automated review suggestions for this pull request.

Reviewed commit: 78cc92697c

ℹ️ About Codex in GitHub

Your team has set up Codex to review pull requests in this repo. Reviews are triggered when you

  • Open a pull request for review
  • Mark a draft as ready
  • Comment "@codex review".

If Codex has suggestions, it will comment; otherwise it will react with 👍.

Codex can also answer questions or update the PR. Try commenting "@codex address that feedback".

Comment thread web/mixer-io.js Outdated
Comment on lines +785 to +789
const demoInput=strip.querySelector('select.route-select[data-field="input"]');
if(isNative()&&demoInput){
const picker=node('select','route-select arChannelQuickInput');
picker.dataset.channel=strip.dataset.strip;
picker.setAttribute('aria-label','CH '+(Number(strip.dataset.strip)+1)+' hardware input');

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

P1 Badge Regenerate the standalone artifact after changing mixer sources

The modified mixer JS and CSS are embedded in AR-MIX-Live-FX-Host-Standalone-v0.3.html, but that artifact still contains their parent-commit versions. python scripts/build_ui_css.py --check now fails with “Outdated generated GUI artifact: standalone HTML”. This blocks more than standalone parity: scripts/build_pages.py:17 runs that check unconditionally, and CMake invokes the Pages assembler through build_approved_native_gui.py, so native configuration and Pages generation fail for this commit. Regenerate and commit the standalone artifact alongside these source changes.

AGENTS.md reference: AGENTS.md:L19-L20

Useful? React with 👍 / 👎.

Comment thread web/approved-native-bridge.js Outdated
Comment on lines +255 to +257
if(typeof window.__arMixOpenAudioIO==="function")
window.__arMixOpenAudioIO("device");
else status("AUDIO I/O unavailable; use the mixer AUDIO I/O button.");

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

P2 Badge Connect Audio I/O to a handler shipped in the native bundle

In the shipped native WebView, this button always takes the unavailable branch instead of opening device selection. Repository-wide search finds __arMixOpenAudioIO defined only in web/mixer-io.js, whereas scripts/build_approved_native_gui.py bundles the approved Pages assets plus the native contract and bridge, not that legacy mixer controller. The replacement therefore makes the former working Audio Setup entry a dead end; only the separately renamed advanced JUCE button still opens settings. Wire this entry to a device-selection implementation actually included in the approved bundle, or retain the working native action until that implementation exists.

AGENTS.md reference: AGENTS.md:L16-L18

Useful? React with 👍 / 👎.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant