Skip to content

P0 product recovery: real physical MAIN routing + single-owner native mixer delivery - #409

Closed
masarray wants to merge 21 commits into
mainfrom
integration/product-recovery-main-output-and-direct-owner-20261105
Closed

masarray wants to merge 21 commits into
mainfrom
integration/product-recovery-main-output-and-direct-owner-20261105

Conversation

@masarray

@masarray masarray commented Nov 5, 2026 •

Copy link
Copy Markdown
Owner

P0 ArSonMix — single-owner working audio product recovery

Base main: 6084d1e232f829fced708b7c4d8ca3d9522d4b57 (already includes ENGINE #266 + First Real Sound #408 selective integration, and Windows/Chromium PASS on that exact base).

Real implementation, not a GUI simulation

  • Add verified physical MAIN L/R output assignment from the existing approved /preview/ More/Audio Setup workflow. Enumerates enabled JUCE output endpoint masks and lets the user patch the chosen stereo pair while muted.
  • New routingMainOutput command in the existing WebView2→JUCE arMixAction bridge; native repatchDryRoutingLabMainOutputs() uses the same LiveDryRoutingLab::publishRevisedTopology compiler, graph publisher, VST3 lease and callback. Source persists as the native accepted topology and validates sparse hardware output mask.
  • Native ACK/REJECT + subsequent readback. Reject stale epoch/revision, unavailable ports, output already armed, Show/backup work, competing graph handoff and independent-clock unsafe mode.
  • No second DSP, no hardcoded ASIO/WASAPI ports, no synthetic meter, no GUI re-skin. Existing CH1 input patch + hardware arm and native PCM route preserved.
  • Add targeted regression to prevent a fake browser-only MAIN assignment.

Remove product-blocking agent bureaucracy without weakening safety

  • One accountable integration owner may modify audio-engine, native bridge, GUI wiring, tests and packaging in this PR.
  • Replace mandatory workstream/PR-collision checks with lightweight --scope classification of actual PR changed files, still selecting required native MSVC/CTest, Chromium and exact-SHA Product Qualification.
  • Archive outdated four-lane documentation and replace old PR template. Retain main protection, visual authority, native contract, regression and physical hardware FAT requirements.

Engineering reference behavior

Grounded in Adobe Audition's Audio Hardware and multitrack device I/O, FL Studio's Audio Settings and mixer hardware I/O routing, and JUCE AudioDeviceManager/AudioIODeviceCallback. Driver and plugin latency are nonzero; goal is practical lowest stable monitoring latency, no UI-callback DSP or unbounded RT work.

Acceptance, strict evidence split

  1. BUILD/CTest: Require Windows native pipeline SUCCESS for this exact PR SHA, not base main.
  2. GUI: Require approved /preview/ parity + Chromium SUCCESS.
  3. Software PCM: Require existing native routing/ChannelId/FX regression and new physical MAIN patch contract. A source-level test is NOT physical playback proof.
  4. Physical Hardware FAT: PENDING until a real ASIO and/or Windows Audio interface is patched input→MAIN L/R, user-arm, meters/fader/MUTE/SOLO observed and 44.1/48 kHz 0FX/1FX soaks checked. Do not claim listening PASS from CI.

No stable release declaration before exact Windows artifact + physical audio testing. This is the one substantive product-recovery PR; do not split into workstream PRs.

Next: on exact-head green Windows qualification, land one integrated branch and produce user-testable EXE/ZIP using the main Windows packaging workflow; resolve first-sound physical issues from real diagnostics, not guessed audio patches.


2026-11-08 reconciliation: ARCHIVED, NOT MERGED

Historical P0 recovery proposal has been incorporated or displaced by the merged #418 native integration and single-owner rules in current AGENTS.md. Its old M4/CI coordination edits conflict with today's approved source. Residual hardware issues are still open in #412/#15.

Current authority: main, #418. Historical branch retained; hardware FAT not inferred.

@chatgpt-codex-connector

chatgpt-codex-connector Bot commented Nov 5, 2026 •

Copy link
Copy Markdown

Codex Review Summary

This comment shows the latest Codex review activity on this pull request.

Review Status Commit Review trigger
📝 Code Review ✅ Completed 2026-11-05T02:00:08.259867Z d62c6d4 PR opened
ℹ️ About Codex in GitHub

Your team has set up Codex to review pull requests in this repo. Reviews are triggered when you

  • Open a pull request for review
  • Mark a draft as ready
  • Comment "@codex review" or "@codex security review".

Codex reacts with 👀 while any review is running, comments if it has suggestions, and reacts with 👍 once all reviews finish with no findings.

@chatgpt-codex-connector chatgpt-codex-connector Bot left a comment

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

💡 Codex Review

Here are some automated review suggestions for this pull request.

Reviewed commit: d62c6d4436

ℹ️ About Codex in GitHub

Your team has set up Codex to review pull requests in this repo. Reviews are triggered when you

  • Open a pull request for review
  • Mark a draft as ready
  • Comment "@codex review".

If Codex has suggestions, it will comment; otherwise it will react with 👍.

Codex can also answer questions or update the PR. Try commenting "@codex address that feedback".

Comment thread src/LiveDryRoutingLab.h
Comment on lines +603 to +604
staged.getDynamicObject()->setProperty("mainOutputs",juce::var(outputPins));
return publishRevisedTopology(staged,expectedEpoch,expectedRevision,

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

P1 Badge Refresh the cloned route's revision before publishing MAIN outputs

After PATCH CH1 succeeds, choosing any MAIN output pair fails because sourceTemplate_ retains the command's pre-publication revision, while the accepted publisher revision has already advanced by one. This clone changes only mainOutputs; publishRevisedTopology() checks the current revision argument but then calls apply(), which reads the stale revision from staged, causing RealtimeRoutePublisher::publish() to reject it. Consequently, the new MAIN assignment workflow cannot succeed even with valid hardware pins and muted outputs. The failed attempt also clears channelIdPcmEpoch_ before publication, disabling the previously admitted ChannelId renderer. Update the staged revision to expectedRevision before invoking the compiler, as NativeVerifiedSourcePatch::prepare() does for input patches.

Useful? React with 👍 / 👎.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant