Skip to content
Closed
Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
21 commits
Select commit Hold shift + click to select a range
b186dc7
ENGINE: expose physical MAIN L/R repatch using existing verified spar…
masarray Nov 5, 2026
5319b00
ENGINE: disarmed user MAIN output selection through one native PCM ca…
masarray Nov 5, 2026
503b32e
INTEGRATION: route explicit MAIN hardware output pair to native engin…
masarray Nov 5, 2026
7122efe
GUI integration: choose verified physical MAIN output pair with JUCE …
masarray Nov 5, 2026
35cd2d1
TEST: enforce real physical MAIN patch through native source-of-truth…
masarray Nov 5, 2026
8c33e1a
PRODUCT: replace blocking multi-agent ownership with one accountable …
masarray Nov 5, 2026
29439e9
DOCS: archive superseded four-lane coordination policy without erasin…
masarray Nov 5, 2026
eb85c02
PRODUCT: remove cross-agent handoff template and require tangible aud…
masarray Nov 5, 2026
583c7c3
CI: choose Windows and Chromium validation from exact changed paths, …
masarray Nov 5, 2026
cf87e42
CI: replace blocking ownership admission with exact-file product qual…
masarray Nov 5, 2026
d382ae1
CI: replace blocking ownership admission with exact-file product qual…
masarray Nov 5, 2026
8deb82f
CI: replace blocking ownership admission with exact-file product qual…
masarray Nov 5, 2026
a09b295
TEST: repair JS test line break and single-owner workflow pattern
masarray Nov 5, 2026
d62c6d4
TEST: reflect new exact-file qualification job name, keep native gates
masarray Nov 5, 2026
110098a
FAT: qualify actual installed M3-F native ChannelId producer and ACK …
masarray Nov 5, 2026
2787e73
TEST: require current installed native ChannelId producer/ACK and rej…
masarray Nov 5, 2026
d33da26
FAT: verify actual installed callback admission predicate, not absent…
masarray Nov 5, 2026
96f21b5
TEST: verify V6 contextual button behavior on sole approved /preview/…
masarray Nov 5, 2026
b74c03d
CI: keep obsolete V8–V27 frozen-migration comparisons manual-only; cu…
masarray Nov 5, 2026
847bb65
TEST: freeze historical CSS fixture migration but retain current sing…
masarray Nov 5, 2026
04131de
TEST: fix regex counting manual historical CSS cases
masarray Nov 5, 2026
File filter

Filter by extension

Filter by extension


Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
33 changes: 13 additions & 20 deletions .github/PULL_REQUEST_TEMPLATE.md
Original file line number Diff line number Diff line change
@@ -1,24 +1,17 @@
## Why this work is not duplicated
Current main SHA: `...`
Related issue / existing PRs reviewed:
## ArSonMix — one product integration owner

## REQUIRED agent ownership (replace CHANGE_ME before opening)
<!-- arsonmix-workstream: CHANGE_ME -->
<!-- arsonmix-issue: #397 -->
**Current main SHA:**
**Branch origin / existing PRs reconciled:**
**Product behavior fixed:**
**Native signal path, device and VST3 impact:**

Allowed workstream: GUI / ENGINE / INTEGRATOR / FAT.
Only the owning lane edits each production file. See [coordination #397](https://github.com/masarray/arsonmix/issues/397) and [workstream rules](../docs/workstreams/MULTI_AGENT_COORDINATION.md).
## Implementation and evidence

## Meaningful implementation and handoff
- Owned files changed:
- Existing implementation reused (PR/SHA):
- Native producer/consumer ABI change (if any):
- Exact-head targeted CI URL and demonstrated behavior:
- Real PCM/GUI/physical FAT proof or **PENDING**:
- Next blocked dependency + receiving workstream:
- Code paths changed (and existing implementation reused):
- Audio callback owner remains ONE JUCE producer:
- Real PCM test and expected input → MAIN → output behavior:
- Windows MSVC / CTest / Chromium results at the **exact PR SHA**:
- Windows EXE / ZIP source SHA and integrity:
- Physical ASIO/WASAPI listening FAT: **PASS with evidence** or **PENDING** (never inferred from CI):

Do not create another GUI, PCM engine, duplicate routing graph, or second CI workflow. Avoid changing CMake/src/Main.cpp outside INTEGRATOR; test evidence is not an audio-LIVE claim.

If this older PR has been parked pending reconciliation, include:
<!-- arsonmix-coordination: parked -->
Remove the parked marker only after an owner-scoped diff and conflict audit.
Protect the approved /preview/ GUI, proper physical port enumeration, native PCM, and user-safe output mute. No parallel browser DSP or speculative hardcoded devices. A single integrator may edit any required subsystem; no legacy workstream marker or owner approval is required.
4 changes: 2 additions & 2 deletions .github/workflows/p1-windows.yml
Original file line number Diff line number Diff line change
Expand Up @@ -60,11 +60,11 @@ jobs:
timeout-minutes: 50
steps:
- uses: actions/checkout@v4
- name: Cheap one-owner / overlapping-PR preflight (read-only)
- name: Cheap exact changed-file product scope (read-only)
if: ${{ github.event_name == 'pull_request' }}
env:
GH_TOKEN: ${{ github.token }}
run: node scripts/check_workstream_coordination.mjs --pr ${{ github.event.pull_request.number }}
run: node scripts/check_workstream_coordination.mjs --pr ${{ github.event.pull_request.number }} --scope
- name: Cheap canonical Console v6 puzzle socket gate (no JUCE)
run: node scripts/check_console_puzzle.mjs
- name: Stop incomplete integrated product promotion before JUCE checkout
Expand Down
62 changes: 31 additions & 31 deletions .github/workflows/ui-smoke.yml
Original file line number Diff line number Diff line change
Expand Up @@ -41,20 +41,20 @@ permissions:

jobs:
coordination:
name: PR coordination admission
name: PR qualification scope (single product owner)
runs-on: ubuntu-latest
timeout-minutes: 5
outputs:
run_ui: ${{ steps.pr_scope.outputs.run_ui || steps.push_scope.outputs.run_ui }}
run_native: ${{ steps.pr_scope.outputs.run_native }}
steps:
- uses: actions/checkout@v4
- name: Audit PR metadata, file ownership and runtime collisions
- name: Select exact changed-file validation; no cross-agent file lock
id: pr_scope
if: ${{ github.event_name == 'pull_request' }}
env:
GH_TOKEN: ${{ github.token }}
run: node scripts/check_workstream_coordination.mjs --pr ${{ github.event.pull_request.number }}
run: node scripts/check_workstream_coordination.mjs --pr ${{ github.event.pull_request.number }} --scope
- name: Main push retains Chromium verification
id: push_scope
if: ${{ github.event_name != 'pull_request' }}
Expand Down Expand Up @@ -193,7 +193,7 @@ jobs:
# pretending the intentional V50 layout/stylesheet changes are V22.
# Restore PR files before ALL current GUI/function/geometry smoke tests.
- name: Mount pinned V24 historical CSS fixture (reversible, no CI rebaseline)
if: ${{ github.event_name == 'workflow_dispatch' || (github.event_name == 'pull_request' && startsWith(github.head_ref, 'integration/product-')) }}
if: ${{ github.event_name == 'workflow_dispatch' }}
shell: bash
run: |
set -euo pipefail
Expand All @@ -206,58 +206,58 @@ jobs:
git show "$baseline:$path" > "$path"
done
- name: Verify V8 FX rack and Plugin Manager CSS ownership
if: ${{ github.event_name == 'workflow_dispatch' || (github.event_name == 'pull_request' && startsWith(github.head_ref, 'integration/product-')) }}
if: ${{ github.event_name == 'workflow_dispatch' }}
run: python tests/pages_css_ownership_v8_smoke.py
- name: Verify V9 PAN/fader/meter CSS ownership and geometry
if: ${{ github.event_name == 'workflow_dispatch' || (github.event_name == 'pull_request' && startsWith(github.head_ref, 'integration/product-')) }}
if: ${{ github.event_name == 'workflow_dispatch' }}
run: python tests/pages_css_ownership_v9_smoke.py
- name: Verify V10 cascade ownership and rendered console geometry
if: ${{ github.event_name == 'workflow_dispatch' || (github.event_name == 'pull_request' && startsWith(github.head_ref, 'integration/product-')) }}
if: ${{ github.event_name == 'workflow_dispatch' }}
run: python tests/pages_css_architecture_v10_smoke.py
- name: Validate V11 section ownership, cascade and computed visual styles
if: ${{ github.event_name == 'workflow_dispatch' || (github.event_name == 'pull_request' && startsWith(github.head_ref, 'integration/product-')) }}
if: ${{ github.event_name == 'workflow_dispatch' }}
run: python tests/pages_css_architecture_v11_smoke.py
- name: Verify V12 removed shadow declarations and old/new visual + control parity
if: ${{ github.event_name == 'workflow_dispatch' || (github.event_name == 'pull_request' && startsWith(github.head_ref, 'integration/product-')) }}
if: ${{ github.event_name == 'workflow_dispatch' }}
run: python tests/pages_css_architecture_v12_smoke.py
- name: Verify V13 owned CSS conflicts and physical control visual parity
if: ${{ github.event_name == 'workflow_dispatch' || (github.event_name == 'pull_request' && startsWith(github.head_ref, 'integration/product-')) }}
if: ${{ github.event_name == 'workflow_dispatch' }}
run: python tests/pages_css_architecture_v13_smoke.py
- name: Verify V14 canonical 45 material tokens and V13 browser parity
if: ${{ github.event_name == 'workflow_dispatch' || (github.event_name == 'pull_request' && startsWith(github.head_ref, 'integration/product-')) }}
if: ${{ github.event_name == 'workflow_dispatch' }}
run: python tests/pages_css_architecture_v14_smoke.py
- name: Verify V15 clean cross-owner CSS and actual interactive visual parity
if: ${{ github.event_name == 'workflow_dispatch' || (github.event_name == 'pull_request' && startsWith(github.head_ref, 'integration/product-')) }}
if: ${{ github.event_name == 'workflow_dispatch' }}
run: python tests/pages_css_architecture_v15_smoke.py
- name: Verify V16 WIRE single CSS owner, 241-rule exact source and visual parity
if: ${{ github.event_name == 'workflow_dispatch' || (github.event_name == 'pull_request' && startsWith(github.head_ref, 'integration/product-')) }}
if: ${{ github.event_name == 'workflow_dispatch' }}
run: python tests/pages_css_architecture_v16_smoke.py
- name: Verify V17 Plugin Manager and Fast FX Picker single CSS owner
if: ${{ github.event_name == 'workflow_dispatch' || (github.event_name == 'pull_request' && startsWith(github.head_ref, 'integration/product-')) }}
if: ${{ github.event_name == 'workflow_dispatch' }}
run: python tests/pages_css_architecture_v17_smoke.py
- name: Verify V18 physical Chrome ownership and four cascade conflict removals
if: ${{ github.event_name == 'workflow_dispatch' || (github.event_name == 'pull_request' && startsWith(github.head_ref, 'integration/product-')) }}
if: ${{ github.event_name == 'workflow_dispatch' }}
run: python tests/pages_css_architecture_v18_smoke.py
- name: Verify V19 shared operator key ownership and six shadowed declarations
if: ${{ github.event_name == 'workflow_dispatch' || (github.event_name == 'pull_request' && startsWith(github.head_ref, 'integration/product-')) }}
if: ${{ github.event_name == 'workflow_dispatch' }}
run: python tests/pages_css_architecture_v19_smoke.py
- name: Verify V20 elimination of 53 shadowed declarations and Chromium state parity
if: ${{ github.event_name == 'workflow_dispatch' || (github.event_name == 'pull_request' && startsWith(github.head_ref, 'integration/product-')) }}
if: ${{ github.event_name == 'workflow_dispatch' }}
run: python tests/pages_css_architecture_v20_smoke.py
- name: Verify V21 physical console chassis geometry owner and visual parity
if: ${{ github.event_name == 'workflow_dispatch' || (github.event_name == 'pull_request' && startsWith(github.head_ref, 'integration/product-')) }}
if: ${{ github.event_name == 'workflow_dispatch' }}
run: python tests/pages_css_architecture_v21_smoke.py
- name: Verify V22 legacy key material migration and M3 visual parity
if: ${{ github.event_name == 'workflow_dispatch' || (github.event_name == 'pull_request' && startsWith(github.head_ref, 'integration/product-')) }}
if: ${{ github.event_name == 'workflow_dispatch' }}
run: python tests/pages_css_architecture_v22_smoke.py
- name: Verify V23 exact cascade deletions and browser parity
if: ${{ github.event_name == 'workflow_dispatch' || (github.event_name == 'pull_request' && startsWith(github.head_ref, 'integration/product-')) }}
if: ${{ github.event_name == 'workflow_dispatch' }}
run: python tests/pages_css_architecture_v23_smoke.py
- name: Verify V24 Fader/Meter/FX cascade pruning and browser parity
if: ${{ github.event_name == 'workflow_dispatch' || (github.event_name == 'pull_request' && startsWith(github.head_ref, 'integration/product-')) }}
if: ${{ github.event_name == 'workflow_dispatch' }}
run: python tests/pages_css_architecture_v24_smoke.py
- name: Restore and verify exact V50 PR assets before current UI smoke
if: ${{ github.event_name == 'workflow_dispatch' || (github.event_name == 'pull_request' && startsWith(github.head_ref, 'integration/product-')) }}
if: ${{ github.event_name == 'workflow_dispatch' }}
shell: bash
run: |
set -euo pipefail
Expand All @@ -270,7 +270,7 @@ jobs:
# The V25 historical test is an immutable exact-byte migration gate.
# Do not rebaseline it after deliberate V26 dead-rule removals.
- name: Mount pinned V25 original CSS before historical V25 migration test
if: ${{ github.event_name == 'workflow_dispatch' || (github.event_name == 'pull_request' && startsWith(github.head_ref, 'integration/product-')) }}
if: ${{ github.event_name == 'workflow_dispatch' }}
shell: bash
run: |
set -euo pipefail
Expand All @@ -283,10 +283,10 @@ jobs:
git show "$baseline:$path" > "$path"
done
- name: Verify V25 exact V51 physical-key owner migration and zero visual regression
if: ${{ github.event_name == 'workflow_dispatch' || (github.event_name == 'pull_request' && startsWith(github.head_ref, 'integration/product-')) }}
if: ${{ github.event_name == 'workflow_dispatch' }}
run: python tests/pages_css_architecture_v25_smoke.py
- name: Restore and verify current V26 source before latest GUI tests
if: ${{ github.event_name == 'workflow_dispatch' || (github.event_name == 'pull_request' && startsWith(github.head_ref, 'integration/product-')) }}
if: ${{ github.event_name == 'workflow_dispatch' }}
shell: bash
run: |
set -euo pipefail
Expand All @@ -298,7 +298,7 @@ jobs:
git diff --exit-code -- site/preview-v2/index.html site/preview-v2/assets/mixer-control-keys.css site/preview-v2/assets/mixer-chrome-material.css site/preview-v2/assets/mixer-plugin-browser.css site/preview-v2/assets/mixer-pan-controls.css site/preview-v2/assets/mixer-fader-assembly.css site/preview-v2/assets/mixer-meter-display.css site/preview-v2/assets/mixer-utility-controls.css
# Byte-exact V26 historical CSS check is pinned, not rebaselined.
- name: Mount V26 approved source before historical regression
if: ${{ github.event_name == 'workflow_dispatch' || (github.event_name == 'pull_request' && startsWith(github.head_ref, 'integration/product-')) }}
if: ${{ github.event_name == 'workflow_dispatch' }}
shell: bash
run: |
set -euo pipefail
Expand All @@ -311,10 +311,10 @@ jobs:
git show "$baseline:$path" > "$path"
done
- name: Verify V26 retired socket dead rules and exact V25 visual/control parity
if: ${{ github.event_name == 'workflow_dispatch' || (github.event_name == 'pull_request' && startsWith(github.head_ref, 'integration/product-')) }}
if: ${{ github.event_name == 'workflow_dispatch' }}
run: python tests/pages_css_architecture_v26_smoke.py
- name: Restore P0 current WIRE source after historical V26 regression
if: ${{ github.event_name == 'workflow_dispatch' || (github.event_name == 'pull_request' && startsWith(github.head_ref, 'integration/product-')) }}
if: ${{ github.event_name == 'workflow_dispatch' }}
shell: bash
run: |
set -euo pipefail
Expand All @@ -327,7 +327,7 @@ jobs:
# V27 is a byte-exact historical CSS migration proof; it must run
# against its original qualified GUI, never rebaseline a newer FX/rail.
- name: Mount pinned V27 GUI and CSS owners for immutable parity
if: ${{ github.event_name == 'workflow_dispatch' || (github.event_name == 'pull_request' && startsWith(github.head_ref, 'integration/product-')) }}
if: ${{ github.event_name == 'workflow_dispatch' }}
shell: bash
run: |
set -euo pipefail
Expand All @@ -340,10 +340,10 @@ jobs:
git show "$baseline:$path" > "$path"
done
- name: Verify V27 scoped material and 37 owned loser declarations with Chromium parity
if: ${{ github.event_name == 'workflow_dispatch' || (github.event_name == 'pull_request' && startsWith(github.head_ref, 'integration/product-')) }}
if: ${{ github.event_name == 'workflow_dispatch' }}
run: python tests/pages_css_architecture_v27_smoke.py
- name: Restore and verify exact V53 current sources after historical V27
if: ${{ github.event_name == 'workflow_dispatch' || (github.event_name == 'pull_request' && startsWith(github.head_ref, 'integration/product-')) }}
if: ${{ github.event_name == 'workflow_dispatch' }}
shell: bash
run: |
set -euo pipefail
Expand Down
11 changes: 4 additions & 7 deletions AGENTS.md
Original file line number Diff line number Diff line change
Expand Up @@ -3,16 +3,13 @@

**ONLY approved/public/product GUI: https://masarray.github.io/arsonmix/preview/**. There must be ONE public preview, ONE actual rendered GUI, and ONE native Windows GUI. **/preview-v2/ is rejected**: do not display, promote, publish or base native design on it as a separate UI. Do not substitute another console from `web/index.html`, `web/mixer-layout.js`, `web/console-native.html`, PR #278 or old M3/V48 mock. **The JUCE ENGINE must stitch into the EXACT approved /preview/ GUI**, never redesign it.

## Multi-agent GitHub coordination — REQUIRED (issue #397)
## Single integration owner — active product recovery (2026-11-05)

Before touching ArSonMix code, read [workstream ownership and collaboration contract](docs/workstreams/MULTI_AGENT_COORDINATION.md) and [coordination control tower #397](https://github.com/masarray/arsonmix/issues/397). GitHub main, active PRs, changed-file overlap and accepted native ABI are the shared state; independent ChatGPT threads cannot see each other's private unpushed work.
**Product delivery is owned end-to-end by ONE integration thread and ONE product PR.** The old four-workstream restrictions in [MULTI_AGENT_COORDINATION.md](docs/workstreams/MULTI_AGENT_COORDINATION.md) and issue [#397](https://github.com/masarray/arsonmix/issues/397) are historical guidance, **not blocking admission criteria**. Any single integrator can edit ENGINE, DEVICE, GUI BRIDGE, tests and packaging together when the change is necessary for a working product. Do not require cross-thread handoff, agent-lane metadata or other PRs to approve file changes.

- **GUI** owns `site/**` and browser presentation. ONLY the assembled `/preview/`, no alternative renderer.
- **ENGINE** owns `engine/**` and realtime DSP/PCM/device/VST3 sources; **#266** remains sole callback producer.
- **INTEGRATOR** alone owns `src/Main.cpp`, `CMakeLists.txt`, `integration/**` and `web/approved-native*` and assembles one Windows application.
- **FAT** owns native Windows evidence, packaging and independent QA; FAT must not edit production DSP or GUI to claim PASS.
Before modifying code, inspect current main SHA, existing implementations, active PR diffs and exact native callback authority. Reuse verified ENGINE #266/M3-F native code rather than raw-merging historical branches. Resolve same-file overlaps deliberately and never force-push over another contributor. Maintain a single authoritative JUCE I/O callback and PCM graph. Retain the approved /preview/ appearance, genuine ASIO/Windows Audio port masks, native ACK + later readback, VST3 lifecycle ownership, and fail-silent output on hotplug and stale routes.

New PRs require the owner and linked issue metadata from `.github/PULL_REQUEST_TEMPLATE.md`. Existing Windows and Chromium workflows run the cheap, read-only source-owner/collision preflight; no extra workflow. Cross-owner changes must be handed off to the owner through issue #397, **not** implemented in parallel. Mark superseded older PRs `<!-- arsonmix-coordination: parked -->` while extracting unique verified changes. Pre-policy PRs #399 and earlier receive nonblocking findings while DRAFT; when marked ready_for_review they must meet the SAME strict gate and re-run CI. This is not permission to merge conflicting code. One exact-SHA integrator gates a Windows EXE on real native PCM + visual parity + FAT; missing hardware evidence is PENDING.
**CI still enforces evidence, not bureaucracy:** selected Windows MSVC/CTest and Chromium checks, native/visual regression tests, genuine provenance and exact-source ZIP integrity. PR qualification must fetch the changed paths and run the relevant lanes; no artificial owner collision or mandatory workstream comment. Physical audio FAT is PENDING without independently measured input→MAIN→output playback and crackle/latency checks. Do not label a browser or unit-test PASS as working hardware.

## Verified current published GUI implementation
`site/preview/index.html` was merely a wrapper/iframe pointing at a generated `/preview-buttons/index.html`. `scripts/build_pages.py` generates that **approved PNG hardware-button variant** using current `site/preview-v2/index.html` as an INTERNAL HTML/WIRE/FX/fader source, with specifically `site/preview-buttons/assets/mixer-control-keys.css`, `mixer-control-keys.js` and `mute-solo-pfl-56x37.png` as approved button source. **The assembled result behind /preview/ is the visual authority, not /preview-v2/ in isolation.** There must be exactly ONE deterministic assembled output and no independent published variant. Internal source files may survive only as build inputs until safely consolidated; they are NOT alternate product GUIs. **Current approved visual including PNG keys must never be silently replaced by the base variant.**
Expand Down
Loading
Loading