Repository navigation
M2.5: prevent cross-owner edits to release-admission and hardware FAT gates - #403
Conversation
Codex Review SummaryThis comment shows the latest Codex review activity on this pull request.
ℹ️ About Codex in GitHubYour team has set up Codex to review pull requests in this repo. Reviews are triggered when you
Codex reacts with 👀 while any review is running, comments if it has suggestions, and reacts with 👍 once all reviews finish with no findings. |
There was a problem hiding this comment.
💡 Codex Review
Here are some automated review suggestions for this pull request.
Reviewed commit: bab4fd0c67
ℹ️ About Codex in GitHub
Your team has set up Codex to review pull requests in this repo. Reviews are triggered when you
- Open a pull request for review
- Mark a draft as ready
- Comment "@codex review".
If Codex has suggestions, it will comment; otherwise it will react with 👍.
Codex can also answer questions or update the PR. Try commenting "@codex address that feedback".
| path === 'scripts/console_v6_fat_gate.mjs' || | ||
| path === 'scripts/verify_console_s0_native_fixture.mjs' || | ||
| path === 'scripts/run_console_native_s0.mjs' || | ||
| (/^(scripts\/(package_native_windows|verify_native_windows_artifact)\.ps1)$/.test(path) || |
There was a problem hiding this comment.
Remove the unmatched parenthesis from the FAT ownership condition
The added opening parenthesis leaves the outer if condition unclosed, so Node fails to load this module with SyntaxError: Unexpected token 'return'. Confirmed by running node --test tests/workstream_coordination_contract.test.mjs. Both .github/workflows/ui-smoke.yml and .github/workflows/p1-windows.yml execute this script as their PR preflight, so every triggered PR run fails before performing the required ownership audit or subsequent validation. Remove this extra opening parenthesis to preserve the mandatory Windows/Chromium coordination gate specified in AGENTS.md.
AGENTS.md reference: AGENTS.md:L15-L15
Useful? React with 👍 / 👎.
M2.5 architecture reconciliation — extend the existing owner gate
Base: main
8ade8df7e151c421c736ff1c87ed9b0f2e7eef61, current coordination policy #397 / merged #400. NO duplicate coordinator, workflow, GUI, native bridge or audio engine.Root cause fixed
The already-merged
scripts/check_workstream_coordination.mjstreated critical release-admission and physical FAT scripts as unclassified. An unrelated workstream could change release acceptance or hardware evidence without tripping CROSS-OWNER. Fix path ownership and add three regression tests, including a different-filename release-admission domain collision.scripts/check_console_puzzle.mjs,scripts/check_approved_native_gui_release.mjs,scripts/check_pr278_console_authority.mjs.scripts/collect_hardware_fat_windows.ps1,scripts/console_v6_fat_gate.mjs,scripts/run_console_native_s0.mjs,scripts/verify_console_s0_native_fixture.mjs.tests/workstream_coordination_contract.test.mjs; no extra CI jobs added.src/**,engine/**,web/approved-native*, CMake, GUI appearance, or FAT evidence.Current reconciliation ownership
approved-native-bridgeruntime domain; do not duplicate).src/Main.cppand native glue to INTEGRATOR.Gate: Chromium exact-head tests; merge only if source-owner preflight and regression pass.