Skip to content
Merged
Show file tree
Hide file tree
Changes from all commits
Commits
File filter

Filter by extension

Filter by extension

Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 2 additions & 0 deletions docs/workstreams/MULTI_AGENT_COORDINATION.md
Original file line number Diff line number Diff line change
Expand Up @@ -12,6 +12,8 @@
| INTEGRATOR | `src/Main.cpp`, `CMakeLists.txt`, `integration/**`, `web/approved-native*`, native GUI resource builder, workflow/coordination policy | Reconciles accepted GUI and ENGINE ABI; no second GUI/PCM; owns merged Windows assembly |
| FAT | Native Windows package/verification scripts, hardware and QA regression evidence | Independent end-to-end exact-SHA verdict; never rewrites DSP or GUI for PASS |

Release-admission scripts (`scripts/check_console_puzzle.mjs`, `scripts/check_approved_native_gui_release.mjs`, `scripts/check_pr278_console_authority.mjs`) belong ONLY to INTEGRATOR. Independent hardware-evidence scripts (`scripts/collect_hardware_fat_windows.ps1`, `scripts/console_v6_fat_gate.mjs`, `scripts/run_console_native_s0.mjs`, `scripts/verify_console_s0_native_fixture.mjs`) belong ONLY to FAT. Neither workstream can weaken the other's release gate without a targeted handoff.

Unclassified docs and isolated tests can be authored by their domain owner. A change to a source file outside a lane **must be handed to the owning lane**. Example: ENGINE can propose a diff to `src/Main.cpp` but INTEGRATOR applies it with the accepted native ABI. FAT files cannot silently turn off safety checks. "Working on a PR" does not grant a file lock against GitHub account credentials: this is enforceable-by-CI collaboration policy, not a security boundary.

## Before every coding session (GitHub is the live coordination bus)
Expand Down
13 changes: 11 additions & 2 deletions scripts/check_workstream_coordination.mjs
Original file line number Diff line number Diff line change
Expand Up @@ -14,6 +14,11 @@ export function ownerOf(path) {
path.startsWith('.github/workflows/') ||
path === 'docs/workstreams/MULTI_AGENT_COORDINATION.md' ||
path === 'scripts/check_workstream_coordination.mjs' ||
// Release admission is INTEGRATOR-owned; other lanes must not
// silently weaken the approved GUI/native stop-ship evidence.
path === 'scripts/check_console_puzzle.mjs' ||
path === 'scripts/check_approved_native_gui_release.mjs' ||
path === 'scripts/check_pr278_console_authority.mjs' ||
path === 'tests/workstream_coordination_contract.test.mjs')
return 'INTEGRATOR';
if (path === 'CMakeLists.txt' || path === 'src/Main.cpp' ||
Expand All @@ -23,7 +28,11 @@ export function ownerOf(path) {
path === 'web/bridge.js' || path === 'web/monitor.js' ||
path === 'scripts/build_approved_native_gui.py')
return 'INTEGRATOR';
if (/^(scripts\/(package_native_windows|verify_native_windows_artifact)\.ps1)$/.test(path) ||
if (path === 'scripts/collect_hardware_fat_windows.ps1' ||
path === 'scripts/console_v6_fat_gate.mjs' ||
path === 'scripts/verify_console_s0_native_fixture.mjs' ||
path === 'scripts/run_console_native_s0.mjs' ||
/^(scripts\/(package_native_windows|verify_native_windows_artifact)\.ps1)$/.test(path) ||
/^tests\/(hardware_fat|native_artifact|fat_|windows_fat)/.test(path))
return 'FAT';
if (path.startsWith('site/') || path.startsWith('web/') ||
Expand Down Expand Up @@ -52,7 +61,7 @@ export function runtimeDomain(path) {
return 'native-host-dispatch';
if (path.startsWith('site/preview') || path === 'scripts/build_pages.py')
return 'approved-visual';
if (/^scripts\/(?:check_console_puzzle|check_approved_native_gui_release)\.mjs$/.test(path))
if (/^scripts\/(?:check_console_puzzle|check_approved_native_gui_release|check_pr278_console_authority)\.mjs$/.test(path))
return 'release-admission';
if (path.startsWith('.github/workflows/') ||
path === 'AGENTS.md' || path === 'scripts/check_workstream_coordination.mjs')
Expand Down
40 changes: 40 additions & 0 deletions tests/workstream_coordination_contract.test.mjs
Original file line number Diff line number Diff line change
Expand Up @@ -36,6 +36,46 @@ test('only one approved GUI has GUI ownership; no accidental native source autho
assert.equal(ownerOf('README.md'),null);
});

test('release-admission scripts belong to INTEGRATOR, not unclassified shared code',()=>{
for(const path of [
'scripts/check_console_puzzle.mjs',
'scripts/check_approved_native_gui_release.mjs',
'scripts/check_pr278_console_authority.mjs'
]) {
assert.equal(ownerOf(path),'INTEGRATOR',path);
for(const lane of ['GUI','ENGINE','FAT']) {
const result=check(pr(405,lane,lane.toLowerCase()+'/gate'),[path]);
assert.equal(result.ok,false,lane+' wrongly edited '+path);
assert.match(result.errors.join(' '),/CROSS-OWNER/);
}
}
});
test('hardware FAT evidence remains exclusively independent FAT owned',()=>{
for(const path of [
'scripts/collect_hardware_fat_windows.ps1',
'scripts/console_v6_fat_gate.mjs',
'scripts/run_console_native_s0.mjs',
'scripts/verify_console_s0_native_fixture.mjs'
]) {
assert.equal(ownerOf(path),'FAT',path);
assert.equal(check(pr(406,'INTEGRATOR','coord/release'),[path]).ok,false);
assert.equal(check(pr(406,'FAT','fat/evidence'),[path]).ok,true);
}
});
test('different release-admission script filenames still collide in one runtime domain',()=>{
const owner=pr(410,'INTEGRATOR','coord/release');
const peer=pr(411,'INTEGRATOR','integration/admission');
const result=check(owner,['scripts/check_approved_native_gui_release.mjs'],
[peer],{'411':['scripts/check_console_puzzle.mjs']});
assert.equal(result.ok,false);
assert.match(result.errors.join(' '),/ACTIVE DOMAIN COLLISION.*release-admission/);
const previousGate=pr(412,'INTEGRATOR','coord/old-gate');
const differentScript=check(owner,['scripts/check_pr278_console_authority.mjs'],
[previousGate],{'412':['scripts/check_console_puzzle.mjs']});
assert.equal(differentScript.ok,false);
assert.match(differentScript.errors.join(' '),/ACTIVE DOMAIN COLLISION.*release-admission/);
});

test('new GUI PR may edit approved source but cannot change native CMake or PCM',()=>{
assert.equal(check(pr(401,'GUI','gui/fader'),
['site/preview/index.html','site/preview/assets/meter.css']).ok,true);
Expand Down
Loading