Repository navigation
Conversation
Codex Review SummaryThis comment shows the latest Codex review activity on this pull request.
ℹ️ About Codex in GitHubYour team has set up Codex to review pull requests in this repo. Reviews are triggered when you
Codex reacts with 👀 while any review is running, comments if it has suggestions, and reacts with 👍 once all reviews finish with no findings. |
There was a problem hiding this comment.
💡 Codex Review
Here are some automated review suggestions for this pull request.
Reviewed commit: 1a752f2074
ℹ️ About Codex in GitHub
Your team has set up Codex to review pull requests in this repo. Reviews are triggered when you
- Open a pull request for review
- Mark a draft as ready
- Comment "@codex review".
If Codex has suggestions, it will comment; otherwise it will react with 👍.
Codex can also answer questions or update the PR. Try commenting "@codex address that feedback".
…failed raster tile
|
Backlog reconciliation — archived as SUPERSEDED (NOT merged). Optional Canvas2D preview-meter A/B is an old unqualified GPU experiment and overlaps owner-accepted L2 strip layout; preserve test idea under #176 only after measured low-spec profiling. Current PRD v5 / ARD v5. Active owners: native #266 / epic #192, UI #265, physical #15, Show #180 and owner GUI #176. This PR's historical commits remain accessible, and no head is blindly merged into modern engine. |
Milestone: test 14 DOM meter bars versus one Canvas2D surface
Previous #58 simplified hover/layer hints but root cause of owner-reported Firefox pointer stutter has no measured user-hardware trace. This PR adds a reversible performance candidate, not an unproven default speedup.
?mixperf=canvas: render 12 channel + 2 master simulated meter bars with a single transparent canvas in browser preview. Original DOM fill/peak nodes stay in place but visually hidden; interactive CLIP LED buttons, 1600ms peak hold, MASTER simulated readouts, routing and fader positions are preserved.drawImage, cache meter rectangles until rebuild/resize/scroll. Avoid the 14 per-frame CSS scale and peak style writes only in canvas mode. Clip LEDs remain fully interactive (pointer-events:nonecanvas).optimizedmode remains the canonical approved DOM renderer; no new pointer listeners nor canvas overhead in normal GUI. Native JUCE/WebView2 meter path is unchanged because the canvas requires explicit preview-only query flag and is disabled whenever native backend exists./preview/perf.htmlfor apples-to-apples user PC recordings vs DOM (optimized).web/styles.cssand offline standalone byte parity.Acceptance
UI smoke (Chromium & Firefox), WebView2/native Windows + realtime primitive tests GREEN on exact PR head, GUI design checkpoint preserved. Field p95/paint/GPU trace on the affected Firefox/Windows machine remains required before promoting Canvas to default. Issue #56 stays open.