Skip to content

perf(gui): phase 2 single-canvas preview meters + Firefox A/B functional CI (#56) - #60

Closed
masarray wants to merge 22 commits into
mainfrom
perf/issue56-phase2-canvas-meter-20261026
Closed

masarray wants to merge 22 commits into
mainfrom
perf/issue56-phase2-canvas-meter-20261026

Conversation

@masarray

Copy link
Copy Markdown
Owner

Milestone: test 14 DOM meter bars versus one Canvas2D surface

Previous #58 simplified hover/layer hints but root cause of owner-reported Firefox pointer stutter has no measured user-hardware trace. This PR adds a reversible performance candidate, not an unproven default speedup.

  • ?mixperf=canvas: render 12 channel + 2 master simulated meter bars with a single transparent canvas in browser preview. Original DOM fill/peak nodes stay in place but visually hidden; interactive CLIP LED buttons, 1600ms peak hold, MASTER simulated readouts, routing and fader positions are preserved.
  • Precompute meter fill gradients/stripes per unique geometry, reuse drawImage, cache meter rectangles until rebuild/resize/scroll. Avoid the 14 per-frame CSS scale and peak style writes only in canvas mode. Clip LEDs remain fully interactive (pointer-events:none canvas).
  • The normal optimized mode remains the canonical approved DOM renderer; no new pointer listeners nor canvas overhead in normal GUI. Native JUCE/WebView2 meter path is unchanged because the canvas requires explicit preview-only query flag and is disabled whenever native backend exists.
  • Add seventh Canvas entry to /preview/perf.html for apples-to-apples user PC recordings vs DOM (optimized).
  • Keep canonical CSS source ownership / compiled web/styles.css and offline standalone byte parity.
  • Extend Chromium UI smoke for Canvas draw, meter geometry, unchanged controls, view switching; add real Playwright Firefox functional smoke in CI. No FPS assertions based on headless CI.

Acceptance

UI smoke (Chromium & Firefox), WebView2/native Windows + realtime primitive tests GREEN on exact PR head, GUI design checkpoint preserved. Field p95/paint/GPU trace on the affected Firefox/Windows machine remains required before promoting Canvas to default. Issue #56 stays open.

@chatgpt-codex-connector

chatgpt-codex-connector Bot commented Oct 26, 2026 •

Copy link
Copy Markdown

Codex Review Summary

This comment shows the latest Codex review activity on this pull request.

Review Status Commit Review trigger
📝 Code Review ✅ Completed 2026-10-26T07:42:11.187686Z 1a752f2 PR opened
ℹ️ About Codex in GitHub

Your team has set up Codex to review pull requests in this repo. Reviews are triggered when you

  • Open a pull request for review
  • Mark a draft as ready
  • Comment "@codex review" or "@codex security review".

Codex reacts with 👀 while any review is running, comments if it has suggestions, and reacts with 👍 once all reviews finish with no findings.

@chatgpt-codex-connector chatgpt-codex-connector Bot left a comment

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

💡 Codex Review

Here are some automated review suggestions for this pull request.

Reviewed commit: 1a752f2074

ℹ️ About Codex in GitHub

Your team has set up Codex to review pull requests in this repo. Reviews are triggered when you

  • Open a pull request for review
  • Mark a draft as ready
  • Comment "@codex review".

If Codex has suggestions, it will comment; otherwise it will react with 👍.

Codex can also answer questions or update the PR. Try commenting "@codex address that feedback".

Comment thread web/app.js Resolved

Copy link
Copy Markdown
Owner Author

Backlog reconciliation — archived as SUPERSEDED (NOT merged). Optional Canvas2D preview-meter A/B is an old unqualified GPU experiment and overlaps owner-accepted L2 strip layout; preserve test idea under #176 only after measured low-spec profiling.

Current PRD v5 / ARD v5. Active owners: native #266 / epic #192, UI #265, physical #15, Show #180 and owner GUI #176. This PR's historical commits remain accessible, and no head is blindly merged into modern engine.

@masarray masarray closed this Oct 31, 2026
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant