Skip to content

P0 GUI rendering: 7px LED dirty-write gate and idempotent native status (#56) - #96

Merged
masarray merged 2 commits into
mainfrom
perf/p0-led-dirty-paint-telemetry-20261027
Oct 27, 2026
Merged

masarray merged 2 commits into
mainfrom
perf/p0-led-dirty-paint-telemetry-20261027

Conversation

@masarray

Copy link
Copy Markdown
Owner

Reconciliation / basis

Based on latest green main@0dc201c after Orbit PR #94, without overwriting its FX motion logic. User observed only a slight pointer improvement after PR #93. GPU/driver and compositor traces are still missing: no claim of measured frame improvement.

Implementation

  • web/app.js whole-cell LED painter keeps raw level in WeakMap, but changes CSS --level and --led-lit only if the visible quantized 7px cell count changes. Zero per-frame DOM writes for changes inside the same painted row. The native metering source, timing, clip latches, peak hold and stereo channels are not modified.
  • ?mixperf=meter-raw in perf lab reproduces pre-P1 raw --level writes without changing color, geometry or scheduling. Controlled optimized vs meter-raw on the affected PC separates this optimization from hover and meter-off tests.
  • web/bridge.js and web/monitor.js avoid replacing unchanged native footer/device/status labels at 12Hz; no change to audio engine or Orbit PR feat(orbit): preserve LFO across FX edits + real circle/ellipse/height motion with synced preview #94.
  • Exact web/app.js ↔ offline standalone embedded JS parity (checked before commit). CSS was not touched.
  • Browser Chromium and Firefox functional smoke cover 1 → 1.1 raw level: same whole-row LED should not change style in optimized, but should change in opt-in meter-raw. New ARD documents evidence, rejected alternatives and physical validation gate.

Acceptance

  • Commit source and offline JavaScript byte parity verified.
  • Conservatively scoped changes, no new runtime scheduler/dependencies.
  • Chromium/Firefox functional UI CI PASS on PR exact head.
  • Windows MSVC/CTest native build and GUI packaging PASS on PR exact head.
  • Owner's affected Windows PC A/B (p95/p99/slow frames and GPU paint).
  • Main CI, Pages SHA, and hardware evidence tracked in Issue P0: Cross-browser pointer stutter on standard Windows GPU (WebView2 + web mixer) #56.

Do not merge PR #60 Canvas on assumption; do not close #56 until user's physical standard-GPU hardware confirms improvement.

@chatgpt-codex-connector

chatgpt-codex-connector Bot commented Oct 27, 2026 •

Copy link
Copy Markdown

Codex Review Summary

This comment shows the latest Codex review activity on this pull request.

Review Status Commit Review trigger
📝 Code Review ✅ Completed 2026-10-27T13:04:05.319264Z 5875f21 PR opened
ℹ️ About Codex in GitHub

Your team has set up Codex to review pull requests in this repo. Reviews are triggered when you

  • Open a pull request for review
  • Mark a draft as ready
  • Comment "@codex review" or "@codex security review".

Codex reacts with 👀 while any review is running, comments if it has suggestions, and reacts with 👍 once all reviews finish with no findings.

@chatgpt-codex-connector chatgpt-codex-connector Bot left a comment

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

💡 Codex Review

Here are some automated review suggestions for this pull request.

Reviewed commit: 5875f21a9f

ℹ️ About Codex in GitHub

Your team has set up Codex to review pull requests in this repo. Reviews are triggered when you

  • Open a pull request for review
  • Mark a draft as ready
  • Comment "@codex review".

If Codex has suggestions, it will comment; otherwise it will react with 👍.

Codex can also answer questions or update the PR. Try commenting "@codex address that feedback".

Comment thread web/bridge.js Resolved
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

P0: Cross-browser pointer stutter on standard Windows GPU (WebView2 + web mixer)

1 participant