Skip to content

Commit de4dd81

Browse files
authored
perf(gui): coalesce whole-row LED paint and unchanged native telemetry (#56)
Keep full precision in meter cache but avoid unchanged 7px CSS clip invalidations; add isolated meter-raw A/B mode. Idempotent native header/status DOM writes, Chromium/Firefox functional tests, Orbit regression and Windows native green. Standard GPU physical acceptance pending.
1 parent 0dc201c commit de4dd81

9 files changed

Lines changed: 129 additions & 23 deletions

‎AR-MIX-Live-FX-Host-Standalone-v0.3.html‎

Lines changed: 16 additions & 3 deletions
Original file line numberDiff line numberDiff line change
@@ -1228,14 +1228,27 @@
12281228
const meterNodes=new Map();
12291229
// Shared preview/native painter: preserve fixed colors; light only whole 7px LEDs.
12301230
const LED_PITCH_PX=7,ledMeterCache=new WeakMap();
1231+
// Opt-in performance A/B: reproduce pre-P1 raw-level DOM writes, with the
1232+
// exact same meter visuals. Production only writes CSS on visible LED changes.
1233+
const meterRawStyleWrites=new URLSearchParams(location.search).get('mixperf')==='meter-raw';
12311234
function setLedMeterLevel(el,rawLevel){
12321235
if(!el)return;
12331236
const level=clamp(Number(rawLevel)||0,0,100);
12341237
let state=ledMeterCache.get(el);
12351238
if(!state){state={height:el.getBoundingClientRect().height,level:-1,lit:-1};ledMeterCache.set(el,state)}
1236-
if(state.level!==level){state.level=level;el.style.setProperty('--level',level+'%')}
1239+
const levelChanged=state.level!==level;
1240+
state.level=level; // Full precision remains cached for ResizeObserver / telemetry.
12371241
const lit=level>=100?state.height:Math.floor((level*state.height/100+1e-7)/LED_PITCH_PX)*LED_PITCH_PX;
1238-
if(state.lit!==lit){state.lit=lit;el.style.setProperty('--led-lit',lit+'px')}
1242+
if(state.lit!==lit){
1243+
state.lit=lit;
1244+
// --led-lit drives the clip; --level remains the compatible fallback,
1245+
// updated only when the visible whole-row LED state actually changes.
1246+
el.style.setProperty('--level',level+'%');
1247+
el.style.setProperty('--led-lit',lit+'px');
1248+
}else if(meterRawStyleWrites&&levelChanged){
1249+
// Diagnostics only: old unconditional raw-level style invalidation.
1250+
el.style.setProperty('--level',level+'%');
1251+
}
12391252
}
12401253
window.__arMixSetLedMeterLevel=setLedMeterLevel;
12411254
// Observe only the stable mixer root, never disposable strips; no hot-path reflow.
@@ -1589,7 +1602,7 @@
15891602
document.addEventListener('keydown',e=>{if(e.ctrlKey&&e.key.toLowerCase()==='s'){e.preventDefault();if(persistSession())flash('UI state saved locally');else flash('Browser storage unavailable')}});
15901603
// Issue #56: no pointer profiler/event listener runs in normal preview or native.
15911604
const mixperfParam=new URLSearchParams(location.search).get('mixperf');
1592-
const mixperfModes=['optimized','baseline','hover-off','meters-off','layers-off','all-off'];
1605+
const mixperfModes=['optimized','baseline','hover-off','meters-off','layers-off','all-off','meter-raw'];
15931606
const mixperfMode=mixperfModes.includes(mixperfParam)?mixperfParam:'optimized';
15941607
document.documentElement.dataset.mixperf=mixperfMode;
15951608
if(mixperfParam&&mixperfModes.includes(mixperfParam)){
Lines changed: 32 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -0,0 +1,32 @@
1+
# ARD-056 P1: dirty LED-paint and idle telemetry DOM writes
2+
3+
**Base:** `main@0dc201c556623a55348abbb93d8dbd0d1cf08cb4` (Orbit PR #94 merged). **Issue:** [#56](https://github.com/masarray/arsonmix/issues/56). User confirmed **slight** pointer improvement after PR #93; not a hardware acceptance or measured p95 result.
4+
5+
## Audit: actual source paths (cost remains unmeasured on user's PC)
6+
7+
| Trigger | Current source | Identified avoidable work | Remediation |
8+
| --- | --- | --- | --- |
9+
| Preview meter 40/60ms demo tick and native 12Hz status | `web/app.js::setLedMeterLevel` | Writes CSS `--level` on every changed raw level even if the quantized 7px `--led-lit` clip remains **identical** | Preserve float telemetry in JS cache; only write `--level` and `--led-lit` when the displayed whole-row clip changes; opt-in `meter-raw` reproduces old behavior |
10+
| Native 12Hz status | `web/bridge.js` | Reassigns the same footer/audio labels each status event | Update those text nodes/data attribute only when changed |
11+
| Native 12Hz status | `web/monitor.js::repaint` | Rewrites invariant header/status labels regardless of equality | Idempotent `setTextIfChanged` for static or slow-changing labels |
12+
| FX Orbit (PR #94) | `web/bridge.js` | Animated path uses rAF **only when popover visible**, and normal live Orbit runs in native motion engine | Leave untouched; no competing animation scheduler introduced |
13+
| Meter `clip-path` / static painted shadows | `40-rail-pan.css`, `20-button-180.css` | May cost compositing but no verified profiler trace or proof of dominant cost | Preserve artwork and physical pad; no blind Canvas merge or removal of seven resting/pressed shadows |
14+
15+
## Engineering decision
16+
17+
`--led-lit` is the primary authored meter clip variable. The `--level` fallback is retained, but normal-mode writes it only when the visible 7px LED count changes. Full-precision measured level remains in the `WeakMap` cache for accurate resize reconstruction; DSP peaks, CLIP latch, 1600ms peak-hold, native meter update frequency and all L/R semantics are untouched. `?mixperf=meter-raw` restores **just** the legacy per-raw-level write, so same-machine A/B separates this change from BTN-180/hover experiments. No new timer, Canvas renderer, layer hint, hot-path DOM lookup or CPU/DSP callback changes.
18+
19+
Native status idempotency is a separate non-visual reduction: compare existing text before assigning; do not suppress state transitions, diagnostic panel measurements or audio device indicators.
20+
21+
## Evidence and acceptance
22+
23+
Deterministic functional smoke tests call `setLedMeterLevel(e,1)` then `setLedMeterLevel(e,1.1)`; displayed 7px LED row is identical. In production style attribute must remain unchanged while cache retains raw 1.1; in explicit `meter-raw` mode the style attribute must change. Chromium/Firefox and Windows-native CI plus source/offline HTML JavaScript byte-parity required. A deterministic DOM mutation count proves redundant writes eliminated **only for identical quantized levels**, not GPU performance gain.
24+
25+
Physical benchmark still needed on affected Windows PC: repeat matched 10-second pointer sweeps in Perf Lab **optimized** vs **meter-raw** and optionally **meters-off**, record p95/p99 and >33ms frames, actual compositor paint/gpu/driver, matched DPI/resolution/monitor/RDP. No claim that pointer stutter is resolved or that meter-raw mode is an accurate reproduction of every earlier build. Issue #56 stays OPEN until physical gate.
26+
27+
## Rejected shortcuts
28+
29+
- Directly replace DOM clip bars with Canvas PR #60 absent same-device evidence.
30+
- Degrade native meter update rate or L/R precision.
31+
- Force GPU `will-change` on all LED elements.
32+
- Rewrite Orbit PR #94, entire FX rack or audio callback for this unrelated GUI optimization.

‎site/preview/perf.html‎

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -2,7 +2,7 @@
22
<title>ArSonMix Mixer Performance Lab</title>
33
<style>*{box-sizing:border-box}body{margin:0;height:100dvh;display:flex;flex-direction:column;background:#101a22;color:#d5e8f1;font:12px Segoe UI,Arial,sans-serif}header{display:flex;gap:9px;align-items:center;flex-wrap:wrap;padding:9px 13px;background:#192b38;border-bottom:1px solid #395261}b{font-size:14px;color:#80e7c0}select,button{padding:7px 9px;border:1px solid #527789;border-radius:4px;color:#e3f4fa;background:#243946;font:inherit}button{cursor:pointer}button:disabled{opacity:.5}iframe{flex:1;min-height:220px;width:100%;border:0}aside{padding:7px 13px;color:#a0becc;background:#142630;font-size:11px}pre{margin:0;padding:9px 13px;max-height:110px;overflow:auto;background:#09131a;white-space:pre-wrap;font:11px Consolas,monospace}a{color:#8edaf4}</style></head><body>
44
<header><b>ArSonMix · Mixer Perf Lab</b><label for="mode">A/B</label>
5-
<select id="mode"><option value="optimized">Optimized (default)</option><option value="baseline">Baseline (old hover + GPU hints)</option><option value="hover-off">Hover off (old GPU hints)</option><option value="meters-off">Meters paused (old hover + GPU hints)</option><option value="layers-off">Layer hint off (old hover)</option><option value="all-off">All off (hover, meters, hint)</option></select>
5+
<select id="mode"><option value="optimized">Optimized (default)</option><option value="baseline">Baseline (old hover + GPU hints)</option><option value="hover-off">Hover off (old GPU hints)</option><option value="meters-off">Meters paused (old hover + GPU hints)</option><option value="layers-off">Layer hint off (old hover)</option><option value="all-off">All off (hover, meters, hint)</option><option value="meter-raw">Meter raw DOM writes (P0 comparison)</option></select>
66
<button id="record">Record 10s</button><button id="copy" disabled>Copy JSON</button>
77
<a id="direct" target="_blank" rel="noopener">Open direct mixer</a><span id="status">Loading…</span></header>
88
<aside>Move mouse over FX inserts, fader caps and PAN during 10s; also move over toolbar as control. Repeat each mode 2–3 times. The meter demo is not real audio.</aside>

‎tests/gui_workflow_contract_test.mjs‎

Lines changed: 9 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -55,3 +55,12 @@ test('native bridge does not inspect idle pointer movement',()=>{
5555
assert.ok(!guard.includes('"pointermove"'), 'idle pointer listener forbidden');
5656
assert.ok(guard.includes('typeof drag') && guard.includes('"pointerup"') && guard.includes('"pointercancel"'));
5757
});
58+
59+
test('quantised LED meter avoids redundant raw CSS writes while preserving diagnostics',()=>{
60+
assert.ok(app.includes('meterRawStyleWrites=new URLSearchParams(location.search)'));
61+
assert.ok(app.includes('if(state.lit!==lit)'));
62+
assert.ok(app.includes('else if(meterRawStyleWrites&&levelChanged)'));
63+
assert.ok(app.includes("'meter-raw'"));
64+
assert.ok(monitor.includes('const setTextIfChanged='));
65+
assert.ok(bridge.includes('footer.textContent!==text'));
66+
});

‎tests/ui_firefox_perf_smoke.py‎

Lines changed: 10 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -24,14 +24,23 @@ async def main():
2424
assert await page.evaluate('window.__arMixPerfProbe === undefined'), "No profiler in normal mode"
2525
await page.close()
2626

27-
for mode in ("optimized", "meters-off", "all-off"):
27+
for mode in ("optimized", "meters-off", "all-off", "meter-raw"):
2828
page = await browser.new_page(viewport={"width": 1440, "height": 820})
2929
page.on("pageerror", lambda error: errors.append(str(error)))
3030
await page.goto(PAGE + "?mixperf=" + mode)
3131
await page.wait_for_selector('[data-fader="master"] .cap')
3232
assert await page.locator('#mixer [data-fader]').count() == 11
3333
assert await page.locator('#mixer [data-meter]').count() == 16
3434
assert await page.locator('#mixer [data-clip]').count() == 16
35+
dirty = await page.evaluate("""() => {
36+
const el=document.querySelector('[data-meter="0"]');
37+
setLedMeterLevel(el,1);
38+
const first=el.getAttribute('style');
39+
setLedMeterLevel(el,1.1);
40+
return {changed:first!==el.getAttribute('style'),
41+
raw:ledMeterCache.get(el).level};
42+
}""")
43+
assert dirty == {"changed":mode=="meter-raw","raw":1.1}, (mode,dirty)
3544

3645
heads = await page.evaluate("""() => {
3746
const c = document.querySelector('[data-fader="0"] .cap');

‎tests/ui_smoke.py‎

Lines changed: 10 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -120,6 +120,16 @@ def shared_shadow_shape(shadow):
120120
assert all(x['palette']==meter['first']['palette'] for x in levels),levels
121121
assert all(x['lit']<=.9*x['height'] for x in levels[:4]),levels
122122
assert levels[-1]['lit']>.9*levels[-1]['height'],levels
123+
# The visible LED row must be the only normal-mode CSS mutation gate.
124+
# Two nearby raw levels with the same lit 7px row must not repaint.
125+
dirty=await page.evaluate("""()=>{
126+
const e=document.querySelector('[data-meter="0"]');
127+
setLedMeterLevel(e,1);
128+
const before=e.getAttribute('style'),lit=e.style.getPropertyValue('--led-lit');
129+
setLedMeterLevel(e,1.1);
130+
return {before,after:e.getAttribute('style'),lit,level:ledMeterCache.get(e).level};
131+
}""")
132+
assert dirty['before']==dirty['after'] and dirty['level']==1.1,dirty
123133
# Full mixer rebuild must restore held peaks and clip state on fresh DOM nodes.
124134
restored=await page.evaluate("""()=>{
125135
clipLatch['0']=true;

‎web/app.js‎

Lines changed: 16 additions & 3 deletions
Original file line numberDiff line numberDiff line change
@@ -35,14 +35,27 @@ function syncClipLeds(){document.querySelectorAll('[data-clip]').forEach(e=>e.cl
3535
const meterNodes=new Map();
3636
// Shared preview/native painter: preserve fixed colors; light only whole 7px LEDs.
3737
const LED_PITCH_PX=7,ledMeterCache=new WeakMap();
38+
// Opt-in performance A/B: reproduce pre-P1 raw-level DOM writes, with the
39+
// exact same meter visuals. Production only writes CSS on visible LED changes.
40+
const meterRawStyleWrites=new URLSearchParams(location.search).get('mixperf')==='meter-raw';
3841
function setLedMeterLevel(el,rawLevel){
3942
if(!el)return;
4043
const level=clamp(Number(rawLevel)||0,0,100);
4144
let state=ledMeterCache.get(el);
4245
if(!state){state={height:el.getBoundingClientRect().height,level:-1,lit:-1};ledMeterCache.set(el,state)}
43-
if(state.level!==level){state.level=level;el.style.setProperty('--level',level+'%')}
46+
const levelChanged=state.level!==level;
47+
state.level=level; // Full precision remains cached for ResizeObserver / telemetry.
4448
const lit=level>=100?state.height:Math.floor((level*state.height/100+1e-7)/LED_PITCH_PX)*LED_PITCH_PX;
45-
if(state.lit!==lit){state.lit=lit;el.style.setProperty('--led-lit',lit+'px')}
49+
if(state.lit!==lit){
50+
state.lit=lit;
51+
// --led-lit drives the clip; --level remains the compatible fallback,
52+
// updated only when the visible whole-row LED state actually changes.
53+
el.style.setProperty('--level',level+'%');
54+
el.style.setProperty('--led-lit',lit+'px');
55+
}else if(meterRawStyleWrites&&levelChanged){
56+
// Diagnostics only: old unconditional raw-level style invalidation.
57+
el.style.setProperty('--level',level+'%');
58+
}
4659
}
4760
window.__arMixSetLedMeterLevel=setLedMeterLevel;
4861
// Observe only the stable mixer root, never disposable strips; no hot-path reflow.
@@ -396,7 +409,7 @@ document.addEventListener('keydown',e=>{const pan=e.target.closest('[data-pan]')
396409
document.addEventListener('keydown',e=>{if(e.ctrlKey&&e.key.toLowerCase()==='s'){e.preventDefault();if(persistSession())flash('UI state saved locally');else flash('Browser storage unavailable')}});
397410
// Issue #56: no pointer profiler/event listener runs in normal preview or native.
398411
const mixperfParam=new URLSearchParams(location.search).get('mixperf');
399-
const mixperfModes=['optimized','baseline','hover-off','meters-off','layers-off','all-off'];
412+
const mixperfModes=['optimized','baseline','hover-off','meters-off','layers-off','all-off','meter-raw'];
400413
const mixperfMode=mixperfModes.includes(mixperfParam)?mixperfParam:'optimized';
401414
document.documentElement.dataset.mixperf=mixperfMode;
402415
if(mixperfParam&&mixperfModes.includes(mixperfParam)){

‎web/bridge.js‎

Lines changed: 22 additions & 8 deletions
Original file line numberDiff line numberDiff line change
@@ -27,7 +27,7 @@
2727
const percent = peak => Math.max(1,Math.min(100,(20*Math.log10(Math.max(1e-6,Number(peak)||0))+60)*100/60));
2828
const toStatus = text => {
2929
const footer = document.querySelector("#audioStatus");
30-
if(footer) footer.textContent = text;
30+
if(footer && footer.textContent!==text) footer.textContent = text;
3131
};
3232

3333
// The v0.3 cosmetic demo catalog and FX editor are replaced with the REAL
@@ -972,7 +972,11 @@
972972
state.monitor=!!d.monitor;
973973
syncNativeMixerControls(d);
974974
const b=document.querySelector('[data-native-action="monitor"]');
975-
if(b){b.textContent=state.monitor?"MUTE OUTPUT":"UNMUTE OUTPUT";b.classList.toggle("on",!state.monitor);}
975+
if(b){
976+
const label=state.monitor?"MUTE OUTPUT":"UNMUTE OUTPUT";
977+
if(b.textContent!==label)b.textContent=label;
978+
b.classList.toggle("on",!state.monitor);
979+
}
976980
const text=d.error?"AUDIO ERROR: "+d.error:
977981
d.connected?`${d.driver} · ${Math.round(d.rate)} Hz / ${d.buffer} · ${state.chain.length} LIVE VST3 · ${d.latencySamples||0} samples FX latency`
978982
:"NO AUDIO DEVICE · SELECT AUDIO SETUP";
@@ -995,26 +999,36 @@
995999
paintMeter(aux,liveOutputLevel);
9961000
// Design-only LUFS/true-peak fields have no native measurement yet.
9971001
const lufs=document.getElementById("masterLufs"),tp=document.getElementById("masterDbtp");
998-
if(lufs)lufs.textContent="—";
999-
if(tp)tp.textContent="—";
1002+
if(lufs&&lufs.textContent!=="—")lufs.textContent="—";
1003+
if(tp&&tp.textContent!=="—")tp.textContent="—";
10001004
// v0.8 Master stream LUFS-I/dBTP remains unimplemented; values stay
10011005
// em dashes rather than falsely claiming measured loudness.
10021006
const pk=document.getElementById("masterPeakDb");
10031007
if(pk)pk.textContent=Number(d.peak)>0
10041008
?(20*Math.log10(Math.max(1e-8,Number(d.peak)))).toFixed(1)+" dBFS":"−∞";
10051009
const driver=document.getElementById("headerDriver");
1006-
if(driver)driver.textContent=d.driver||"No device";
1010+
if(driver){
1011+
const label=d.driver||"No device";
1012+
if(driver.textContent!==label)driver.textContent=label;
1013+
}
10071014
// Preserve the latest main native device lamp.
10081015
const deviceButton=document.querySelector(".toolbar .spec-device");
10091016
if(deviceButton){
10101017
const ready=!!d.connected && !d.error;
10111018
deviceButton.classList.toggle("on",ready);
1012-
deviceButton.dataset.audioConnected=String(ready);
1019+
if(deviceButton.dataset.audioConnected!==String(ready))
1020+
deviceButton.dataset.audioConnected=String(ready);
10131021
}
10141022
const rate=document.getElementById("headerRate");
1015-
if(rate)rate.textContent=d.rate?(Number(d.rate)/1000).toLocaleString("en-US",{maximumFractionDigits:1}):"--";
1023+
if(rate){
1024+
const label=d.rate?(Number(d.rate)/1000).toLocaleString("en-US",{maximumFractionDigits:1}):"--";
1025+
if(rate.textContent!==label)rate.textContent=label;
1026+
}
10161027
const buffer=document.getElementById("headerBuffer");
1017-
if(buffer)buffer.textContent=d.buffer||"--";
1028+
if(buffer){
1029+
const label=String(d.buffer||"--");
1030+
if(buffer.textContent!==label)buffer.textContent=label;
1031+
}
10181032
});
10191033
backend.addEventListener("arMixScanProgress",p=>{
10201034
state.progress=p;

0 commit comments

Comments
 (0)