Repository navigation
docs(Factory FX): six first-party VST3 bundle architecture, sibling releases and verifiable manifest - #187
Conversation
Codex Review SummaryThis comment shows the latest Codex review activity on this pull request.
ℹ️ About Codex in GitHubYour team has set up Codex to review pull requests in this repo. Reviews are triggered when you
Codex reacts with 👀 while any review is running, comments if it has suggestions, and reacts with 👍 once all reviews finish with no findings. |
There was a problem hiding this comment.
💡 Codex Review
Here are some automated review suggestions for this pull request.
Reviewed commit: 75d210dccf
ℹ️ About Codex in GitHub
Your team has set up Codex to review pull requests in this repo. Reviews are triggered when you
- Open a pull request for review
- Mark a draft as ready
- Comment "@codex review".
If Codex has suggestions, it will comment; otherwise it will react with 👍.
Codex can also answer questions or update the PR. Try commenting "@codex address that feedback".
| "minItems": 1, | ||
| "maxItems": 6, |
There was a problem hiding this comment.
Require all six distinct products for production manifests
A manifest declaring distribution: "production-six" can contain just one plugin, or six entries repeating the same productId, and still satisfy this schema. That means schema validation does not enforce the distinction between an engineering partial bundle and the complete production bundle required by the new ADR. Add a conditional constraint for production-six that requires exactly one entry for each of the six canonical product IDs, while retaining partial manifests for engineering builds.
AGENTS.md reference: AGENTS.md:L3-L3
Useful? React with 👍 / 👎.
Owner product requirement
ArSonMix official portable ZIP/installer must ultimately bundle its six original factory plugins — ArSonEQ, ArSonComp, ArSonVerb, ArSonHarmony, ArSonColor, ArSonKuPik Enhancer — while preserving unrestricted user-imported VST3 and one public app feature set. No duplicated DSP host or fake UI buttons.
Code/source-grounded audit
Files
New docs/ADR_FACTORY_FX_BUNDLE_20261030.md and docs/PRD_FACTORY_FX_20261030.md specify read-only FactoryFX next to application vs Studio/Plugins/VST3 user vault, a unified native JUCE VST3 host, manifest/cached discovery by actual class ID, plugin-state URI, packaging/release provenance/legal checks, zero RT scanning, three significant FXF milestones, exact user acceptance.
New docs/factoryfx-release-manifest.schema.json is a valid parsed draft-2020-12 JSON schema for generated shipped-only manifests (no fake planned FX), version/commit, x64 VST3 class identity, complete hashes, license approval. Six canonical documents README, AGENTS, product roadmap, PRD/ARD and handoff now link it.
Product epic #185 and sibling issues askp-vst #60, arson-eq #6, arsonverb #4 align independent releases.
9 docs/schema files only. No native binary/FX code, packaging behavior or GUI changed, no expensive Windows CI requested for docs. Factory modules are NOT YET SHIPPED, licenses/artifacts/host FAT remain gates. Protect merged MS1/G5A, L2 #176, PDC #95, portability #85 and zero-VST hardware #15.