Skip to content

P2.3 Live VU only + real PAN DSP + one-click native VST3 bypass - #7

Closed
masarray wants to merge 10 commits into
fix/p2-realtime-glitch-telemetry-latest-guifrom
fix/p2-truthful-meter-pan-fx-toggle
Closed

masarray wants to merge 10 commits into
fix/p2-realtime-glitch-telemetry-latest-guifrom
fix/p2-truthful-meter-pan-fx-toggle

Conversation

@masarray

Copy link
Copy Markdown
Owner

Real Windows hardware feedback

  • Fake all-channel sine VUs still writing over native meter values, resulting in heavy flicker.
  • Horizontal PAN UI moves but did not control actual DSP.
  • Need Studio One-style one-click FX power/bypass beside plugin label in mixer without opening editor.
  • User's attached diagnostic log has 364 AUDIO_HEALTH entries truncated at exactly 511 characters; process/VST performance counters lost.
  • ArSonKuPik VST3 played smoothly in this session; preserve working host.

Changes

  1. Disable legacy requestAnimationFrame demo meters in native WebView; native JUCE input/master only; other 11 mock strips have inactive meters, no fabricated motion. Meter readings have fast attack and UI-only controlled release.
  2. Add actual Channel 1 PAN with atomic parameter and JUCE-independent stereo matrix, preserving stereo identity at center; hard left/right fold stereo to single side without increasing dual-mono amplitude.
  3. Add compact per-insert ⏻ ON/OFF toggle next to FX plugin name in mixer; click plugin body still opens editor. Native FX Rack power status synced and uses atomic bypass, no graph detachment on toggle.
  4. Expand diagnostics log slots to 4096 bytes, expose truncation counter and preserve performance JSON.
  5. Bring latest GUI styles from fix/fader-thumb-symmetry-polish (hash 0077d54) without replacing native host.
  6. Release-mode native pan matrix asserts and no-dependency Node UI contract tests in Windows CI.

Verification

Windows MSVC Release build, native RT unit tests, JavaScript syntax and Node UI contract tests MUST pass. Physical stereo headphone PAN, VU, bypass and log validity need Windows hardware test. Keep draft until confirmed.

Copy link
Copy Markdown
Owner Author

P2.3 — Windows CI GREEN, ready for physical test

Final commit: c973a9c27b91894c41f0edf2a87650b6494075a8

Evidence/root causes: legacy v0.3 synthetic VU oscillators (30 FPS) fought native JUCE VU updates (12 Hz). Uploaded 371-line log contains 364 health records all truncated at 511 chars, masking deadline/plugin metrics. Implemented native-only VU, left/right true output peaks (PAN-visible), CH1 stereo pan DSP, per-insert power toggle with atomic native bypass, and 4096-byte bounded health logs with truncation telemetry. Imported latest styles from GUI branch without replacing the actual audio host. ArSonKuPik sounded stable in user's latest physical trial; not claiming other plugins will be stable.

Physical Windows checks required: channel 2–12 meters remain silent, CH1 and master only follow genuine audio, PAN left/right changes headphones and distinct master L/R, power toggles effect immediately without graph detach, next diagnostic log is no longer 511-byte-truncated. Keep PR draft pending verification.

Copy link
Copy Markdown
Owner Author

Backlog reconciliation — 2026-11-01. Closing as SUPERSEDED/ARCHIVED, not merged. This early P1/P2 branch is a historical stacked baseline (2026-10-24/25) that targets obsolete parent branches and overlapping native/GUI files. Its useful product requirements are now covered by the merged live 10CH/VST code plus PRD/ARD v5 and active M-U1 #266 / GUI #265. It is NOT certified as safely cherry-pickable on current main.

Canonical workflow: PRD v5, ARD v5, dynamic engine issue #192. Any unique test, VST compatibility or safety insight should be deliberately ported to #266, #265, #180 or #15 against current main with fresh proof—never merge this historical stacked head blindly. Original commits remain accessible; branch is not deleted.

@masarray masarray closed this Oct 31, 2026
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant