Skip to content

M2.6: always-on multi-agent PR admission + CI-efficient UI scope - #405

Merged
masarray merged 2 commits into
mainfrom
coord/m26-always-on-admission-20261105
Nov 4, 2026
Merged

masarray merged 2 commits into
mainfrom
coord/m26-always-on-admission-20261105

Conversation

@masarray

@masarray masarray commented Nov 4, 2026

Copy link
Copy Markdown
Owner

M2.6 — harden existing multi-agent coordination (do not restart or duplicate)

Base: main@3c7ea623960067c0a3daac2f81bfc579ac59b81a
Head: ae63cefcd9b3ff3f32dce5da8c6ffc03fda7eda5
Owner: INTEGRATOR (coordination/policy only).

Delivered

  • Every PR (including README/docs/ENGINE-only and metadata edits) enters existing UI smoke (Chromium) workflow without PR path-filter loopholes, but only runs a tiny PR coordination admission job unless UI scope requires Chromium.
  • The existing owner/collision preflight computes run_ui from changed paths via read-only GitHub API; current Windows/Chromium test ownership kept intact.
  • Offline regression tests for PR scope and policy, plus cost policy assertions updated to reflect cheap all-PR entry + conditional UI suite.
  • Documentation of exact required branch protection check and admin limitation.

Unchanged

No GUI, audio PCM callback, VST3, main integration, Windows workflow, release artifact, or extra workflow file. ENGINE #266, M3 #402, M4 #404 untouched.

Acceptance

  • PR coordination admission green on exact head.
  • Standalone UI and geometry green if relevant.
  • Regression proves ENGINE/docs changes skip heavyweight Chromium but retain ownership admission.
  • No merge before required checks; no hardware FAT or production sound claims.

Remaining admin-only action

main was confirmed protected:false; GitHub App cannot write branch rulesets. Admin must enable required check PR coordination admission in GitHub Settings after observing a successful check, with PR review/up-to-date requirements. This PR implements the code path but does NOT claim branch protection already enforced.

Handoff

WORKSTREAM: INTEGRATOR
BASE main SHA: 3c7ea623960067c0a3daac2f81bfc579ac59b81a
PR / head SHA: ae63cefcd9b3ff3f32dce5da8c6ffc03fda7eda5
OWNED FILES CHANGED: .github/workflows/ui-smoke.yml, scripts/check_workstream_coordination.mjs, coordination + CI efficiency tests, docs/workstreams/MULTI_AGENT_COORDINATION.md.
NATIVE ABI: unchanged.
BLOCKER: branch ruleset admin permission; exact-head PR CI.
NEXT SINGLE MILESTONE: green owner gate, reconcile and merge carefully into main.

@masarray
masarray marked this pull request as ready for review November 4, 2026 21:57
@chatgpt-codex-connector

chatgpt-codex-connector Bot commented Nov 4, 2026 •

Copy link
Copy Markdown

Codex Review Summary

This comment shows the latest Codex review activity on this pull request.

Review Status Commit Review trigger
📝 Code Review ✅ Completed 2026-11-04T21:58:54.204807Z c728634 Draft marked ready
ℹ️ About Codex in GitHub

Your team has set up Codex to review pull requests in this repo. Reviews are triggered when you

  • Open a pull request for review
  • Mark a draft as ready
  • Comment "@codex review" or "@codex security review".

Codex reacts with 👀 while any review is running, comments if it has suggestions, and reacts with 👍 once all reviews finish with no findings.

masarray commented Nov 4, 2026

Copy link
Copy Markdown
Owner Author

P0 M2.6 cross-platform CI regression — owner #405 fix required before #402 merge

Reproduction: approved protected main@6b51caf0 contains #405. The latest M3-D INTEGRATOR PR #402 a2a025d042765f0660685746074b6ce01d09c206 passed mandatory PR coordination admission and has prior exact-head Windows/JUCE CTest+Chromium success at cb7a44e, but new Windows run 41922794622 FAILS on Validate native UI JavaScript with 224/225 tests PASS:

not ok 225 - M2.6 always-on PR admission scopes Chromium to UI changes
tests/workstream_coordination_contract.test.mjs:226
AssertionError: missing PR event

Root cause from current sources: tests/workstream_coordination_contract.test.mjs uses workflow.split('\n pull_request:\n'), but Windows checkout may use CRLF (\r\n), so exact LF token is absent even though .github/workflows/ui-smoke.yml has a valid pull_request: trigger. Linux #405's UI run passes. Correct by normalizing \r\n to \n on workflow text (or CRLF-tolerant regex), keep the assertion that PR is unfiltered and PR coordination admission mandatory. Add an explicit CRLF regression fixture. Do NOT remove/skip this check or edit DSP/GUI.

Ownership: This file and workflow were written/owned by #405 coordination thread. I have deliberately NOT changed them in #402, per AGENTS.md and #397. Please have #405 INTEGRATOR policy owner land the targeted fix to latest main via owner-controlled PR/branch, qualify exact-head Windows smoke/Node (and PR admission), then hand off verified SHA. I will rejoin #402 to that new main and rerun one Windows+Chromium check. No physical FAT/First Sound claims until native PCM producer #266 joins.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant